Regression: Weird overlapping is seen for 'No throttling' drop down of Network section.
Reported by
jshan...@etouch.net,
Jan 19 2017
|
|||||||||||
Issue descriptionChrome Version:57.0.2986.0 (Official Build) 12c8d70173fc1a04fa588b75be71ab5e80655c60-refs/heads/master@{#444600} 32/64-bit. OS:Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1) Steps: 1. Launch Chrome, open devtools on NTP and go to Network section. 2. Select any option like 'Regular 2G' from 'No throttling' drop down 3. Observe Actual: Weird overlapping is seen for 'No throttling' drop down Expected: No such overlapping should be for 'No throttling' drop down This is a regression issue, broken in 'M-57', will soon update the other info: Good Build: 57.0.2985.0 Bad Build: 57.0.2986.0
,
Jan 19 2017
Testing team: why did you not add a releaseblock label since it's an M57 regression?
,
Jan 19 2017
Reduced testcase:
<!doctype HTML>
<select style="position: relative; width: 100px; background: none; border: none; padding: 0px 15px 0px 5px;">
<option>
Test long texttttttttttttttttttttttttttttttt
</option>
</select>
When the <select> element has a PaintLayer, we use a clip for the contents of the option text
that does not exclude the dropdown arrow. When it does not have a PaintLayer, the clip is
adjusted to be smaller and exclude the dropdown arrow. This is why the text overlaps the arrow
in this bug.
My CL introduced this issue because it started using the PaintLayer path for control clips when
the <select> has a PaintLayer.
,
Jan 20 2017
As per comment# 2 and Comment# 3 verified the issue on 57.0.2986.0 on Windows 10, MAC 10.12.2, Ubuntu 14.04 using the reduced test case and able to reproduce it. Attached screenshot for the same. Removing Test confirmation label. Thanks.!
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b281bde16d4878454ed00e1335c80100c414a920 commit b281bde16d4878454ed00e1335c80100c414a920 Author: chrishtr <chrishtr@chromium.org> Date: Fri Jan 20 22:17:53 2017 Use control clip rather than overflow clip when present for PaintLayers. BUG= 682574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2645963003 Cr-Commit-Position: refs/heads/master@{#445182} [modify] https://crrev.com/b281bde16d4878454ed00e1335c80100c414a920/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/b281bde16d4878454ed00e1335c80100c414a920/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/b281bde16d4878454ed00e1335c80100c414a920/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
,
Jan 20 2017
,
Jan 20 2017
,
Jan 21 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 21 2017
@testing team: I add a request for test confirmation because of my question in comment 2. This bug should have been marked as release blocking - why wasn't it?
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebfed3ef47840592baebac907d4a3d7f44ab2b37 commit ebfed3ef47840592baebac907d4a3d7f44ab2b37 Author: Chris Harrelson <chrishtr@chromium.org> Date: Sat Jan 21 22:47:30 2017 Use control clip rather than overflow clip when present for PaintLayers. BUG= 682574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2645963003 Cr-Commit-Position: refs/heads/master@{#445182} (cherry picked from commit b281bde16d4878454ed00e1335c80100c414a920) Review-Url: https://codereview.chromium.org/2652513002 . Cr-Commit-Position: refs/branch-heads/2987@{#12} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/ebfed3ef47840592baebac907d4a3d7f44ab2b37/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/ebfed3ef47840592baebac907d4a3d7f44ab2b37/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/ebfed3ef47840592baebac907d4a3d7f44ab2b37/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
,
Jan 21 2017
,
Jan 24 2017
,
Jan 24 2017
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b41eb97c57735332189de2741c95db30ba62a307 commit b41eb97c57735332189de2741c95db30ba62a307 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Thu Jan 26 21:45:06 2017 Auto-rebaseline for r445182 https://chromium.googlesource.com/chromium/src/+/b281bde16d487 BUG= 682574 TBR=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/2654313004 . Cr-Commit-Position: refs/heads/master@{#446456} [modify] https://crrev.com/b41eb97c57735332189de2741c95db30ba62a307/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/b41eb97c57735332189de2741c95db30ba62a307/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select-popup/popup-menu-appearance-transform-expected.png [modify] https://crrev.com/b41eb97c57735332189de2741c95db30ba62a307/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-transform-expected.png
,
Feb 3 2017
With respect to the label added: Needs-triage-Mobile, triaged the issue and below are the observations. Unable to replicate the issue on Mobile device (Tablet and Handset) as the steps provided cannot be followed on it. Devices Used: ============= Device Nexus 7 Tablet Chrome Version: 57.0.2987.9 Android version: 5.0.2/LRX22G Device: Moto G Chrome Version: 58.0.2993.0 Android version: 6.0.0/MPB24 Reasons: ======== 1) Dev tool procedure is different than that on mobile and desktop. Need to connect the device externally to the desktop. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by hdodda@chromium.org
, Jan 19 2017Labels: hasbisect-per-revision
Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)