New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682571 link

Starred by 1 user
Status: Verified
Owner:
serg...@chromium.org
Closed: Feb 2017
Cc:
█ sshruthi@chromium.org
█ tyoshino@chromium.org
chanli@chromium.org
seanmccullough@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Update "Team ownership of test directories" for directories owned by the networking APIs team

Project Member Reported by tyoshino@chromium.org, Jan 19 2017 
It looks the Flakiness Surface is not correctly handling the directories owned by us, the Blink Networking APIs team. Maybe it's due to that we didn't enter the "Owning team" column but only entered our list to the "Email alias" column.

The following directories should be considered to be owned by:
- Owning team: Networking APIs team
- Email alias: blink-network-stack@google.com

fast/beacon
fast/domurl
fast/eventsource
fast/xmlhttprequest
http/tests/fetch
http/tests/eventsource
http/tests/xmlhttprequest/
http/tests/navigation/beacon-*
http/tests/websocket

Comment 1 by serg...@chromium.org, Jan 19 2017

Cc: sshruthi@chromium.org
Labels: Milestone-Dogfood
Owner: serg...@chromium.org
Status: Started (was: Untriaged)
Thank you for this report. I've updated both the spreadsheet and the database. Flakiness Surface should show your directories correctly after ~1 hour.

Regarding http/tests/navigation/beacon-*, we can not assign owners for specific tests, but only for entire directories. Can you please move your tests into a subdirectory of http/tests/navigation?

Comment 2 by serg...@chromium.org, Jan 19 2017

Labels: Pri-1

Comment 3 by serg...@chromium.org, Jan 25 2017

Cc: tyoshino@chromium.org

Comment 4 by serg...@chromium.org, Feb 3 2017

Owner: tyoshino@chromium.org
Status: Assigned (was: Started)
Please re-assign back to me after moving the tests into the subdirectory.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a75af1cd30519bd7205f0d9129eb8db8f29c48d

commit 8a75af1cd30519bd7205f0d9129eb8db8f29c48d
Author: tyoshino <tyoshino@chromium.org>
Date: Thu Feb 23 05:39:20 2017

Move tests for sendBeacon to a separate dedicated directory for clearer ownership

Not only because of the ownership clarification, but it's just good to
have a better home for them since they're closer to XHR and Fetch API.
It's not so reasonable to place them in navigation/ just because they
belongs to window.navigator.

The virtual test virtual/stable/http/tests/navigation/ is kept for a
different reason.

Moved redirection-respond.php to http/tests/resources as it's not
specific to the tests under http/tests/navigation/

BUG= 682571 , 619662 , 490015 , 694958 

Review-Url: https://codereview.chromium.org/2702113003
Cr-Commit-Position: refs/heads/master@{#452408}

[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/645ad78c4d429cda9591f9be1486b911d7076f59/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-expected.txt
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-301-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-302-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-303-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-307-response.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/resources/redirection-response.php
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked-expected.txt
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-blob-with-non-simple-type.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-blob.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-credentials.html
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/check-beacon.php
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/save-beacon.php
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/README.txt
[delete] https://crrev.com/645ad78c4d429cda9591f9be1486b911d7076f59/third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/beacon-cross-origin-redirect-blob-expected.txt
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/README.txt
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/beacon-cross-origin-redirect-blob-expected.txt

Comment 6 by tyoshino@chromium.org, Feb 23 2017

Owner: serg...@chromium.org
All the navigator.sendBeacon() related layout test files are now under http/tests/sendbeacon.

Comment 7 by serg...@chromium.org, Feb 28 2017

Status: Fixed (was: Assigned)
Thanks. Updated doc and database.

Comment 8 by tyoshino@chromium.org, Feb 28 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment