New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682556 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chrome browser crashes when OK is returned in FSP callbacks.

Project Member Reported by mtomasz@chromium.org, Jan 19 2017

Issue description

Crash confirmed.
 
This issue has been there since beginning of FSP API.
The problem happens when onError callback of any onXXXRequested callbacks is called with OK result code.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0891c24ebc475fb9b92c1d31a7e8d8e49a7de065

commit 0891c24ebc475fb9b92c1d31a7e8d8e49a7de065
Author: mtomasz <mtomasz@chromium.org>
Date: Tue Feb 21 06:36:11 2017

Don't crash browser process when OK passed as error code in FSP API.

This CL fixes it by adding a guard to both custom bindings, and
API implementation.

TEST=Tested with a testing extension.
BUG= 682556 

Review-Url: https://codereview.chromium.org/2643013002
Cr-Commit-Position: refs/heads/master@{#451711}

[modify] https://crrev.com/0891c24ebc475fb9b92c1d31a7e8d8e49a7de065/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
[modify] https://crrev.com/0891c24ebc475fb9b92c1d31a7e8d8e49a7de065/chrome/common/extensions/api/file_system_provider.idl
[modify] https://crrev.com/0891c24ebc475fb9b92c1d31a7e8d8e49a7de065/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js

Status: Fixed (was: Started)

Sign in to add a comment