New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682543 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Feb 2017
Cc:
█ kavvaru@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

treeview of chrome dev tool source panel workspace display incorrectly when creating new file and rename a file

Reported by liuway...@gmail.com, Jan 19 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce the problem:
issue#1
1. open chrome dev tool and switch to source panel 
2. add folder to workspace
3. rename a file within the folder just added to the workspace
4. new file with the new name is created and the old file with old name still exists

 issue#2 
1. open chrome dev tool and switch to source panel 
2. add folder to workspace and make the folder expanded
3. right click on the folder just added to the workspace and select 'new file'
4. enter a name for the new file and press enter
5. two files showing in the treevew, they are 'NewFile' and the one with the name just entered

What is the expected behavior?
issue#1
file with old file name should not appear in the treeview.

 issue#2 
the 'NewFile' should not appear in the treevew.

What went wrong?
However, the actual behaviours correctly when you check on the disk, the file is renamed and new file is created, no duplicated files. It's just the treeview not working properly.

Did this work before? N/A 

Chrome version: 55.0.2883.95  Channel: stable
OS Version: OS X 10.12.2
Flash Version: Shockwave Flash 24.0 r0
chrome-dev-tool-workspace-treeview-issue.jpg
39.3 KB View Download

Comment 1 by kavvaru@chromium.org, Jan 20 2017

Cc: kavvaru@chromium.org
Labels: -Type-Bug -Pri-2 M-55 OS-Linux OS-Windows Pri-1 Type-Bug-Regression
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.12.1 using chrome version 55.0.2883.87 and canary 57.0.2986.0.
This is regression issue broken in M55.Please find the bisect information as below

Narrow bisect::
Good :: 55.0.2880.0  ---  (build revision  422654)
Bad:: 55.0.2881.0  ---   (build revision 423030)

Change Log::
https://chromium.googlesource.com/chromium/src/+log/2ae51c4ea3e7b08e143df3a97017519bd3e2ca11..2eaab0b3ed3ccdb072e3f60a0ebcf0298841d01d

Possible suspect::
https://chromium.googlesource.com/chromium/src/+/2eaab0b3ed3ccdb072e3f60a0ebcf0298841d01d

lushnikov@ Could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue.

Thanks,

Comment 2 by lushnikov@chromium.org, Feb 11 2017

Status: Fixed (was: Assigned)
These both are fixed in https://codereview.chromium.org/2651043006
Should work beautifully in Chrome Canary.
Thanks for the bugreport though!

Comment 3 by liuway...@gmail.com, Feb 13 2017 

I tried the canary v58. 
I notice that when creating new file, the file name is default to `NewFile` and not been focused in editing mode. Now we should click the `NewFile` and manually rename it.  Previously this is working. Can we bring it back?
I think naming a file immediately after creating it is wanted behavior.

Comment 4 by lushnikov@chromium.org, Feb 13 2017 

@liuwayong: i can't reproduce it on 58.0.3012.0 - could you please file a separate bug and give more details?

Comment 5 by liuway...@gmail.com, Feb 14 2017 

hi @lushnikov, thanks for replying. 
never mind, I test it on chromium 58.0.3012.0 and everything's okay. it's the canary 58.0.3011.0 witch is broken.
creating_new_file.gif
798 KB View Download

Comment 6 by liuway...@gmail.com, Feb 24 2017 

hi @lushnikov, I filed an new bug about the issue mentioned above, it can be reproduced in recent 58.0.3021.0 https://bugs.chromium.org/p/chromium/issues/detail?id=695755
►

Sign in to add a comment