New issue
Advanced search Search tips

Issue 682540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Make ServiceTabLauncher have a reasonable behavior when WebAPKs are disabled

Project Member Reported by pkotw...@chromium.org, Jan 19 2017

Issue description

Make ServiceTabLauncher have a reasonable behavior when WebAPKs are disabled

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a2aee10eb115bb0e2d04b8343ce60b7b6936fa

commit f5a2aee10eb115bb0e2d04b8343ce60b7b6936fa
Author: pkotwicz <pkotwicz@chromium.org>
Date: Thu Jan 19 18:30:17 2017

WebAPKs: Handle WebAPK WebappRegistry info and WebAPKs being disabled in ServiceTabLauncher

WebAPKs can be disabled
- by the user via chrome://flags
- via Chrome variations

This CL handles a user having a WebAPK installed but WebAPKs being disabled in
ServiceTabLauncher. Currently, if the URL corresponds to a WebAPK, we attempt to
launch the WebAPK in webapp mode because there is a listing in WebappDataStorage.
This CL opens a regular browser tab if the URL corresponds to a WebAPK when
WebAPKs are disabled.

BUG= 682540 

Review-Url: https://codereview.chromium.org/2643813003
Cr-Commit-Position: refs/heads/master@{#444793}

[modify] https://crrev.com/f5a2aee10eb115bb0e2d04b8343ce60b7b6936fa/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java
[modify] https://crrev.com/f5a2aee10eb115bb0e2d04b8343ce60b7b6936fa/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java

Status: Fixed (was: Started)
Testing steps for the test team
1) Enable "improved add to home screen" in chrome://flags
2) Install a WebAPK for tests.peter.sh/notification-generator/
3) Launch the WebAPK
4) Disable "improved add to home screen" in chrome://flags
5) Navigate to tests.peter.sh/notification-generator/
6) Select "Only open a new window" from the action drop down
7) Tap the "display the notification" button
8) Swipe Chrome away
9) Tap on the notification
Expected:
The WebAPK's start page is opened in a new tab
Actual:
An intent picker is shown with weird options (none of them is the WebAPK or a Web Browser)

Sign in to add a comment