New issue
Advanced search Search tips

Issue 682534 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 682459
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 676187



Sign in to add a comment

media::mojom::RemoterFactory and media::mojom::Remoter leak

Project Member Reported by marc...@chromium.org, Jan 19 2017

Issue description

We are leaking these 2 bindings (media::mojom::RemoterFactory and media::mojom::Remoter). I did this change to disable media remoting and this specific leak seems to go away. We have many other leaks though but these are tracked in the master issue 676187.

diff --git a/media/media_options.gni b/media/media_options.gni
index 3aab0a04970f..04cbeff6ec27 100644
--- a/media/media_options.gni
+++ b/media/media_options.gni
@@ -142,5 +142,5 @@ declare_args() {
   # This switch defines whether the Media Remoting implementation will be built.
   # When enabled, media is allowed to be renderer and played back on remote
   # devices when the tab is being casted and other conditions are met.
-  enable_media_remoting = !is_chromecast && !is_ios && !is_android
+  enable_media_remoting = false
 }


 
Blocking: 676187

Comment 2 by w...@chromium.org, Jan 19 2017

Components: Internals>Cast
Labels: -Pri-3 M-57 OS-All Pri-1
Owner: m...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by m...@chromium.org, Jan 19 2017

Status: Started (was: Assigned)
Thanks. As discussed over IM, I'll look into this right away.
Mergedinto: 682459
Status: Duplicate (was: Started)
that's a duplicate of 682459 actually, the fix for the other one fixes this too.

Sign in to add a comment