New issue
Advanced search Search tips

Issue 682521 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 568218



Sign in to add a comment

Have some console log level that's disabled by default

Project Member Reported by rbyers@chromium.org, Jan 19 2017

Issue description

Talking with Pavel, there's a need for some level of logging that doesn't show up on the console by default (the way violations don't unless explicitly enabled).

Then other things (like some deprecation warnings - issue 568218) can use that level.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bcbc12230b01813e2cc5efb02f10a8da79f88ce

commit 2bcbc12230b01813e2cc5efb02f10a8da79f88ce
Author: pfeldman <pfeldman@chromium.org>
Date: Sat Jan 21 06:08:54 2017

DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' level.

BUG= 682521 
TBR=(api change)

Review-Url: https://codereview.chromium.org/2646033003
Cr-Commit-Position: refs/heads/master@{#445274}

[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/chrome/browser/installable/installable_logging.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/components/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/browser/browsing_data/clear_site_data_throttle.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/child/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/common/appcache_interfaces.h
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/public/common/console_message_level.h
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/renderer/pepper/host_globals.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/extensions/renderer/console.cc
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/fast/dom/Window/console-functions-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/fast/workers/worker-console-log-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-log-before-inspector-open-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-nested-group-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-preserve-log.html
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-tests-expected.txt
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/core/inspector/ConsoleTypes.h
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/common/Console.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/devtools/front_end/ui/smallBubble.css
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/public/web/ConsoleMessageStructTraits.cpp
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/public/web/WebConsoleMessage.h
[modify] https://crrev.com/2bcbc12230b01813e2cc5efb02f10a8da79f88ce/third_party/WebKit/public/web/console_message.mojom

Labels: Canary-Feedback Hotlist-ConOps
Just FYI, users have reported some confusion and feedback on this change.
https://productforums.google.com/forum/#!topic/chrome/ajMTAJootLY

Feedback could also mean that we might need to update  https://developers.google.com/web/tools/chrome-devtools/console/ to be inline with this change.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56239aafe60c06f1d9e72e5baf9ca0534671d5a5

commit 56239aafe60c06f1d9e72e5baf9ca0534671d5a5
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Jan 24 23:36:00 2017

DevTools: temporarily mute the console-tests.html while v8 updates its verbosity levels.

BUG= 682521 
TBR=dgozman

Review-Url: https://codereview.chromium.org/2657683002
Cr-Commit-Position: refs/heads/master@{#445860}

[modify] https://crrev.com/56239aafe60c06f1d9e72e5baf9ca0534671d5a5/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cafd655e448abc99cb991c9a19663da6c86505d

commit 1cafd655e448abc99cb991c9a19663da6c86505d
Author: pfeldman <pfeldman@chromium.org>
Date: Thu Jan 26 17:46:46 2017

DevTools: migrate v8 console client to the new API.

BUG= 682521 

Review-Url: https://codereview.chromium.org/2656633004
Cr-Commit-Position: refs/heads/master@{#446370}

[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/LayoutTests/inspector/console/console-clear-function-expected.txt
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/LayoutTests/inspector/console/console-command-clear-expected.txt
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/LayoutTests/inspector/console/console-tests-expected.txt
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/1cafd655e448abc99cb991c9a19663da6c86505d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/82ef9f75e343bb49f99a6f39f8c280bf3ef42b64

commit 82ef9f75e343bb49f99a6f39f8c280bf3ef42b64
Author: pfeldman <pfeldman@chromium.org>
Date: Fri Jan 27 18:49:09 2017

V8 Inspector: complete migration to the standard message level enum.

BUG= chromium:682521 

Review-Url: https://codereview.chromium.org/2659913002
Cr-Commit-Position: refs/heads/master@{#42747}

[modify] https://crrev.com/82ef9f75e343bb49f99a6f39f8c280bf3ef42b64/include/v8-inspector.h
[modify] https://crrev.com/82ef9f75e343bb49f99a6f39f8c280bf3ef42b64/src/inspector/v8-console-message.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e

commit 2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e
Author: pfeldman <pfeldman@chromium.org>
Date: Fri Jan 27 22:40:54 2017

DevTools: render console level filter as drop box.

BUG= 682521 
NOTRY=true

Review-Url: https://codereview.chromium.org/2650543002
Cr-Commit-Position: refs/heads/master@{#446802}

[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test-expected.txt
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-log-before-inspector-open-expected.txt
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-log-before-inspector-open.html
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet-expected.txt
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet.html
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-tests.html
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/LayoutTests/inspector/console/console-worklet-script.js
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/quick_open/filteredListWidget.css
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/ui/filter.css
[modify] https://crrev.com/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e/third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css

Status: Fixed (was: Assigned)

Comment 9 by kayce@google.com, Jan 31 2017

Labels: DevTools-Release-Notes-Change

Sign in to add a comment