Issue 682516 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sa...@chromium.org
Closed:	Jan 2017
Cc:	tapted@chromium.org
Components:	Internals>Mojo
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Blocking:
issue 687822

gen/device/serial/serial.mojom-shared.h should not use "NO" as an enum member

Project Member Reported by patricia...@chromium.org, Jan 19 2017

Issue description

gen/device/serial/serial.mojom-shared.h has a "ParityBit" enum class with an enum member named "NO" (https://cs.chromium.org/chromium/src/out/Debug/gen/device/serial/serial.mojom-shared.h?rcl=0&l=188).

This clashes with Objective C's "NO" keyword which is the equivalent of "false" in C++. Can this be changed?

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe5b80deb66d94a110ef347739f3f7e8d7d164c5

commit fe5b80deb66d94a110ef347739f3f7e8d7d164c5
Author: sammc <sammc@chromium.org>
Date: Thu Jan 19 06:15:53 2017

Rename device.serial.ParityBit.NO to avoid a clash with NO in objective C.

BUG= 682516 

Review-Url: https://codereview.chromium.org/2644543003
Cr-Commit-Position: refs/heads/master@{#444663}

[modify] https://crrev.com/fe5b80deb66d94a110ef347739f3f7e8d7d164c5/device/serial/serial.mojom
[modify] https://crrev.com/fe5b80deb66d94a110ef347739f3f7e8d7d164c5/device/serial/serial_io_handler.cc
[modify] https://crrev.com/fe5b80deb66d94a110ef347739f3f7e8d7d164c5/device/serial/serial_io_handler_posix.cc
[modify] https://crrev.com/fe5b80deb66d94a110ef347739f3f7e8d7d164c5/device/serial/serial_io_handler_win.cc
[modify] https://crrev.com/fe5b80deb66d94a110ef347739f3f7e8d7d164c5/extensions/browser/api/serial/serial_connection.cc

Comment 2 by sa...@chromium.org, Jan 19 2017

Status: Fixed (was: Untriaged)

Comment 3 by patricia...@chromium.org, Jan 20 2017

Thanks Sam!

Comment 4 by patricia...@chromium.org, Feb 2 2017

Blocking: 687822

►

Issue 682516 link

Issue metadata

gen/device/serial/serial.mojom-shared.h should not use "NO" as an enum member

Issue description

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

Comment 1 Deleted

Comment 2 by sa...@chromium.org, Jan 19 2017

Comment 2 Deleted

Comment 3 by patricia...@chromium.org, Jan 20 2017

Comment 3 Deleted

Comment 4 by patricia...@chromium.org, Feb 2 2017

Comment 4 Deleted

Sign in to add a comment