Issue metadata
Sign in to add a comment
|
A semantic bug in PPBNaClPrivate::DownloadNexe
Reported by
leanderz...@gmail.com,
Jan 19 2017
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36 Steps to reproduce the problem: 1. This is a bug revealed by a static analysis tool. 2. 3. What is the expected behavior? What went wrong? In the function PPBNaClPrivate::DownloadNexe, the fast path "OpenNaclExecutable" is executed first. If the returned handle is invalid, slow path is executed. Otherwise, function "DownloadNexeCompletion" is executed in fast path. However, this function may also return an invalid file handle. The current code cannot switch back to slow path when an invalid file handle is returned from "DownloadNexeCompletion". Do we need to check if out_file_info->handle is PP_kInvalidFileHandle before return in the fast path of OpenNaclExecutable? Did this work before? Yes Does this work in other browsers? Yes Chrome version: 55.0.2883.95 Channel: stable OS Version: OS X 10.12.2 Flash Version: Shockwave Flash 24.0 r0
,
Feb 12 2018
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Jan 19 2017Labels: TE-NeedsTriageHelp