Issue metadata
Sign in to add a comment
|
MacViews: Overlay scroller has mismatched scroller/track widths when scrolling over the track |
||||||||||||||||||||||
Issue descriptionChrome Version : 57.0.2985.0 OS Version: OS X 10.12.2 Pretty sure this used to work... may be a regression. #needs-bisect What steps will reproduce the problem? 0. System Preferences -> General -> Show Scroll bars -> When scrolling 1. Have lots of bookmark folders 2. chrome://flags/#secondary-ui-md 3. Edit a bookmark 4. Move mouse cursor to the edge of the scrollview hosting folders 5. Scroll with the trackpad What is the expected result? Scroller should match track width What happens instead of that? Scroller is more narrow than the track width. It's ok when scrolling over the middle of the scroll view, then hovering over the scroll track, and they animate together. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2985.0 Safari/537.36
,
Oct 4 2017
This bug's still live and should be fixed before we ship MacViews.
,
Oct 16 2017
spqchan, can you have a look at this? :)
,
Oct 20 2017
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/686faa29744c72562dd016a7960856138bceaa91 commit 686faa29744c72562dd016a7960856138bceaa91 Author: spqchan <spqchan@chromium.org> Date: Wed Nov 01 02:36:48 2017 [MacViews] Fix Cocoa Overlay Scrollbar Width There's a bug where the thumb in the Cocoa overlay scrollbar becomes more narrow than the track width. This bug is caused by BaseScrollBarThumb::SetLength() which sets the thumb's size according to its preferred size. Since the CocoaScrollBarThumb::CalculatePreferredSize() returns the thumb's minimum's size, SetLength() would set the thumb's size to be too small. This CL fixes this issue by returning the thumb's current thickness instead of the minimum size in CocoaScrollBarThumb::CalculatePreferredSize(). Additionally, this CL changes the logic so that the thumb and track bounds and size won't be insetted. Instead, the thumb's painting will be inset in the OnPaint() function. The kExpandedScrollbarThumbInset value is also removed. Bug:682466 Change-Id: I59411650df8acfb4e628efbb1a9f0646c2ce385b Reviewed-on: https://chromium-review.googlesource.com/741039 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#513047} [modify] https://crrev.com/686faa29744c72562dd016a7960856138bceaa91/ui/views/controls/scrollbar/cocoa_scroll_bar.h [modify] https://crrev.com/686faa29744c72562dd016a7960856138bceaa91/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
,
Nov 2 2017
spqchan@ Tested this issue on Mac OS 10.12.6 using the latest Chrome version 64.0.3256.0 following the steps mentioned in the original comment. Can observe that on editing a bookmark, scroll bar is not seen. And on Scrolling through the bookmarks list and the folders, can observe that the scroller fills the track width. Attached is the screen cast for reference. Can you pease check and confirm if the fix is working as intended or no? Thanks..
,
Nov 2 2017
Ah yes, we're testing the "Edit Bookmark" dialog, not the Bookmark Manager. Make sure you enable chrome://flags/#show-all-dialogs-with-views-toolkit
,
Nov 6 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Apr 12 2017