New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682460 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: ash::TabletPowerButtonController needs to observe stylus eject events

Project Member Reported by derat@chromium.org, Jan 18 2017

Issue description

ash::TabletPowerButtonController currently implements ui::InputDeviceObserver and registers with ui::InputDeviceManager to hear about stylus devices being ejected. ui::InputDeviceManager isn't initialized in mash, so this code has been disabled ( issue 682403 ). mash should provide an alternate way for these events to be observed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7493b52a7df965340262a60de51780cbf978dbff

commit 7493b52a7df965340262a60de51780cbf978dbff
Author: derat <derat@chromium.org>
Date: Thu Jan 19 00:45:37 2017

mash: Fix TabletPowerButtonController segfault.

Make TabletPowerButtonController check that
ui::InputDeviceManager exists before trying to register
itself with it.

BUG= 682403 , 682460 

Review-Url: https://codereview.chromium.org/2645523004
Cr-Commit-Position: refs/heads/master@{#444571}

[modify] https://crrev.com/7493b52a7df965340262a60de51780cbf978dbff/ash/system/chromeos/power/tablet_power_button_controller.cc

Cc: -jamescook@chromium.org kylec...@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
I think kylechar@ created a instance of ui::InputDeviceManager in mash that bridges to the UI service over mojo. I'll take a look.

Yep, there should be an InputDeviceClient instance that implements InputDeviceManager in mash.

https://cs.chromium.org/chromium/src/services/ui/public/cpp/input_devices/input_device_client.h

I think ash should have an instance, but maybe I'm thinking of mushrome?
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f336c50912b9f4e2e3e8ed401e87461715ab872

commit 6f336c50912b9f4e2e3e8ed401e87461715ab872
Author: James Cook <jamescook@chromium.org>
Date: Wed Oct 25 15:08:19 2017

cros: Fix ui::InputDeviceManager usage for mash

The ash process now has an InputDeviceManager, so we don't need to
check for null or skip tests that use it.

Convert PaletteTrayTests to avoid usage of DeviceDataManagerTestAPI,
since DeviceDataManager doesn't exist on mash.

Bug:  682460 ,  734812 
Test: ash_unittests
Change-Id: If0d75de124af664f530f6cce5af6f95588c8265c
Reviewed-on: https://chromium-review.googlesource.com/735130
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511462}
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_test_api.h
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/power/power_button_display_controller.cc
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/status_area_widget_unittest.cc
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mus.filter

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment