mash: ash::TabletPowerButtonController needs to observe stylus eject events |
||||||
Issue descriptionash::TabletPowerButtonController currently implements ui::InputDeviceObserver and registers with ui::InputDeviceManager to hear about stylus devices being ejected. ui::InputDeviceManager isn't initialized in mash, so this code has been disabled ( issue 682403 ). mash should provide an alternate way for these events to be observed.
,
Oct 20 2017
I think kylechar@ created a instance of ui::InputDeviceManager in mash that bridges to the UI service over mojo. I'll take a look.
,
Oct 23 2017
Yep, there should be an InputDeviceClient instance that implements InputDeviceManager in mash. https://cs.chromium.org/chromium/src/services/ui/public/cpp/input_devices/input_device_client.h I think ash should have an instance, but maybe I'm thinking of mushrome?
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f336c50912b9f4e2e3e8ed401e87461715ab872 commit 6f336c50912b9f4e2e3e8ed401e87461715ab872 Author: James Cook <jamescook@chromium.org> Date: Wed Oct 25 15:08:19 2017 cros: Fix ui::InputDeviceManager usage for mash The ash process now has an InputDeviceManager, so we don't need to check for null or skip tests that use it. Convert PaletteTrayTests to avoid usage of DeviceDataManagerTestAPI, since DeviceDataManager doesn't exist on mash. Bug: 682460 , 734812 Test: ash_unittests Change-Id: If0d75de124af664f530f6cce5af6f95588c8265c Reviewed-on: https://chromium-review.googlesource.com/735130 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#511462} [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_test_api.h [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_unittest.cc [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/power/power_button_display_controller.cc [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mus.filter
,
Oct 25 2017
,
Jan 22 2018
,
Jan 23 2018
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 19 2017