binutils: can not emerge binutils-9999 |
|||||||
Issue description
Working on fixing a ebuild issue in binutles with EAPI-6, I realized emerging binutils-9999 does not work anymore.
cros_workon start --host sys-devel/binutils
sudo emerge sys-devel/binutils
fatal: Not a git repository: '/mnt/host/source/src/third_party/platform/aosp/toolchain/binutils/.git'
emerge log enclosed,
emerge -pvq:
[ebuild fU ] sys-devel/binutils-9999 [2.25.51-r63] USE="cros_host hardened nls -mounted_binutils -multislot -multitarget -next_binutils -prev_binutils -profiling {-test} -vanilla"
emerge info enclosed
The problem is in cl/318484:
We are recalculating S on the fly to get the right version from AOSP, but that does not work with 9999 ebuild:
+ local subdir="${PN}-$(get_version_component_range 1-2)"
+ if [[ -d "${S}/${subdir}" ]] ; then
+ S="${S}/${subdir}"
+ fi
fi
,
Jan 18 2017
,
Feb 15 2017
rahulchaudhry@, any progress on this?
,
Feb 16 2017
What would you like the -9999 ebuild to build? Note that we fetch binutils sources from https://android.googlesource.com/toolchain/binutils. The other ebuild (binutils-2.25.51-r63) already builds from the tip of the aosp repository. Do you simply want -9999 ebuild to use the same sources, or something else?
,
Feb 16 2017
+vapier@ Should we delete the binutils-9999 ebuild? What is this useful for in chromiumos-overlay? It's been broken for more than a year, and no-one complained (until this issue). Even this issue seems to be more about it not failing, rather than about doing anything different from binutils-2.25.51-r63.
,
Feb 16 2017
it's a cros-workon package, so you can't really delete the 9999 ebuild it can be used via standard cros-workon flows by local devs too it would be more useful if the ebuilds weren't marked as blacklist and were allowed to uprev like normal ... when people push commits to the aosp binutils branch, we'd automatically roll it in.
,
Feb 28 2017
In progress: https://chromium-review.googlesource.com/#/c/444168/
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/601835d2965b607b067829abb95a04ccfa724db6 commit 601835d2965b607b067829abb95a04ccfa724db6 Author: Daniel Wang <wonderfly@google.com> Date: Fri Mar 17 03:30:46 2017 sys-devel/binutils: Fix 9999 ebuild BUG= chromium:682455 CQ-DEPEND=CL:444067 TEST=cros_workon start --host sys-devel/binutils && sudo emerge sys-devel/binutils TEST=All tests in CL:318484 also pass Change-Id: Icbf9f3dc1929d8f9600f64822a575021f570f51a Reviewed-on: https://chromium-review.googlesource.com/444168 Commit-Ready: Daniel Wang <wonderfly@google.com> Tested-by: Daniel Wang <wonderfly@google.com> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/601835d2965b607b067829abb95a04ccfa724db6/sys-devel/binutils/binutils-2.25.51-r64.ebuild [modify] https://crrev.com/601835d2965b607b067829abb95a04ccfa724db6/sys-devel/binutils/binutils-9999.ebuild
,
Mar 17 2017
Thanks for the fix wonderfly@
,
May 30 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by gwendal@chromium.org
, Jan 18 20172.9 KB
2.9 KB View Download