New issue
Advanced search Search tips

Issue 682437 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jan 2017
Cc:
rbyers@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

image_data->GetCanvas() may fail

Reported by leanderz...@gmail.com, Jan 18 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce the problem:
1. This is a bug identified by static analysis
2. 
3. 

What is the expected behavior?

What went wrong?
In the function "PepperPluginInstanceImpl::CreateImage" and line: SKCanvas* canvas = image_data->GetCanvas(). GetCanvas() can fail because GetCanvas calls CreatePlatfromCanvas(), which may fail due to out-of-memory or something more opaque, like GDI or cairo reported a failure. Can you can a branch to handle this case? Thanks.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 55.0.2883.95  Channel: stable
OS Version: OS X 10.12.2
Flash Version: Shockwave Flash 24.0 r0

Comment 1 by rbyers@chromium.org, Jan 19 2017

Cc: rbyers@chromium.org
Components: Internals>Plugins>Pepper
Status: WontFix (was: Unconfirmed)
That code only affects plugins, which at this point probably isn't used by much (if anything).  I've searched our crash database and there isn't a single report of a crash inside PepperPluginInstanceImpl::CreateImage ever.  So this is unlikely to matter to us in practice (in contrast to the thousands of crashes we know are occurring).  In general we expect out-of-memory to trigger a renderer crash, so we're not concerned with writing custom error handling code for OOM.
►

Sign in to add a comment