New issue
Advanced search Search tips

Issue 682429 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 682427



Sign in to add a comment

Change WebStateDelegate::OnAuthRequired to have same signature as NetworkDelegate::OnAuthRequired

Project Member Reported by eugene...@chromium.org, Jan 18 2017

Issue description

Expected signature:

virtual AuthRequiredResponse OnAuthRequired(
      URLRequest* request,
      const AuthChallengeInfo& auth_info,
      const AuthCallback& callback,
      AuthCredentials* credentials) = 0;

Actual signature:

virtual void OnAuthRequired(WebState* source,
                            NSURLProtectionSpace* protection_space,
                            NSURLCredential* proposed_credential,
                            const AuthCallback& callback) = 0;
 
Labels: -Type-Feature Type-Task
Status: WontFix (was: Available)
It was agreed that ios/web does not have to fully match content.

Sign in to add a comment