Change WebStateDelegate::OnAuthRequired to have same signature as NetworkDelegate::OnAuthRequired |
||
Issue description
Expected signature:
virtual AuthRequiredResponse OnAuthRequired(
URLRequest* request,
const AuthChallengeInfo& auth_info,
const AuthCallback& callback,
AuthCredentials* credentials) = 0;
Actual signature:
virtual void OnAuthRequired(WebState* source,
NSURLProtectionSpace* protection_space,
NSURLCredential* proposed_credential,
const AuthCallback& callback) = 0;
,
May 10 2017
It was agreed that ios/web does not have to fully match content. |
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, Apr 13 2017