Add UI, interaction tests for new flows added for Chromad
AD join, AD sign in, AD password change
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dfec867c5ee0e640d48b099ef28776659fb54ea commit 6dfec867c5ee0e640d48b099ef28776659fb54ea Author: rsorokin <rsorokin@chromium.org> Date: Mon Feb 27 17:58:36 2017 Add Active Directory enterprise enrollment/domain join tests BUG= 682421 TEST=EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment* Review-Url: https://codereview.chromium.org/2716383002 Cr-Commit-Position: refs/heads/master@{#453253} [modify] https://crrev.com/6dfec867c5ee0e640d48b099ef28776659fb54ea/chrome/browser/chromeos/login/enrollment/enrollment_screen.h [modify] https://crrev.com/6dfec867c5ee0e640d48b099ef28776659fb54ea/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8de9932fb6a6364f688b9966f08609d30d124cdf commit 8de9932fb6a6364f688b9966f08609d30d124cdf Author: rsorokin <rsorokin@chromium.org> Date: Wed Mar 22 17:11:27 2017 Add Active Directory login UI tests BUG= 682421 , 698731 TEST=ActiveDirectoryLoginTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=pbond@chromium.org,emaxx@chromium.org,bartfab@chromium.org,courage@chromium.org,juliatuttle@chromium.org,stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2737733003 Cr-Commit-Position: refs/heads/master@{#458786} [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/extensions/info_private_apitest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/settings/stub_install_attributes.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/settings/stub_install_attributes.h [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/chromeos/system/device_disabling_manager_unittest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/net/errorpage_browsertest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/resources/chromeos/login/screen_gaia_signin.js [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chrome/browser/ui/webui/options/preferences_browsertest.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chromeos/dbus/fake_auth_policy_client.cc [modify] https://crrev.com/8de9932fb6a6364f688b9966f08609d30d124cdf/chromeos/dbus/fake_auth_policy_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/037de995fa87710f53f675dc382bdc35e578e28d commit 037de995fa87710f53f675dc382bdc35e578e28d Author: Roman Sorokin <rsorokin@chromium.org> Date: Mon Oct 02 11:06:51 2017 Move login tests for Active Directory to a separate file. Bug: 682421 Change-Id: I20be3a94693913b93475aec73756d8f6522c4859 Reviewed-on: https://chromium-review.googlesource.com/683338 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505573} [add] https://crrev.com/037de995fa87710f53f675dc382bdc35e578e28d/chrome/browser/chromeos/login/active_directory_login_browsertest.cc [modify] https://crrev.com/037de995fa87710f53f675dc382bdc35e578e28d/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/037de995fa87710f53f675dc382bdc35e578e28d/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc [modify] https://crrev.com/037de995fa87710f53f675dc382bdc35e578e28d/chrome/test/BUILD.gn [modify] https://crrev.com/037de995fa87710f53f675dc382bdc35e578e28d/chromeos/dbus/fake_auth_policy_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d458386126178c04b1aedecf986b632aebc289ae commit d458386126178c04b1aedecf986b632aebc289ae Author: Roman Sorokin <rsorokin@chromium.org> Date: Mon Oct 02 12:12:44 2017 Add UI tests for Active Directory password change screen. Bug: 682421 Change-Id: I9e056c5194f64093b48d9a1cf9cfd8736c7bce4d Reviewed-on: https://chromium-review.googlesource.com/670732 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#505586} [modify] https://crrev.com/d458386126178c04b1aedecf986b632aebc289ae/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17f42401f379007196cfb16bbc4beb3c11c69e7c commit 17f42401f379007196cfb16bbc4beb3c11c69e7c Author: Devlin <rdevlin.cronin@chromium.org> Date: Mon Oct 02 16:13:40 2017 Revert "Add UI tests for Active Directory password change screen." This reverts commit d458386126178c04b1aedecf986b632aebc289ae. Reason for revert: New test is failing on Linux ASAN https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23948 Original change's description: > Add UI tests for Active Directory password change screen. > > Bug: 682421 > Change-Id: I9e056c5194f64093b48d9a1cf9cfd8736c7bce4d > Reviewed-on: https://chromium-review.googlesource.com/670732 > Commit-Queue: Roman Sorokin <rsorokin@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505586} TBR=achuith@chromium.org,rsorokin@chromium.org Change-Id: Ibcddeea4e4c6a8e7a4bfba49fbaaaffd6086cb92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 682421 Reviewed-on: https://chromium-review.googlesource.com/694967 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505634} [modify] https://crrev.com/17f42401f379007196cfb16bbc4beb3c11c69e7c/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a43619de3ef342363b9fecfb1dbf817b905856f commit 3a43619de3ef342363b9fecfb1dbf817b905856f Author: Roman Sorokin <rsorokin@chromium.org> Date: Mon Oct 09 15:52:31 2017 Restore and fix tests on ASAN_LSAN Removed check for the loading screen: Too flaky. Could not find why it does not work on LSAN. TBR=achuith@chromium.org Revert "Revert "Add UI tests for Active Directory password change screen."" This reverts commit 17f42401f379007196cfb16bbc4beb3c11c69e7c. Bug: 682421 Change-Id: Ied8bc35d0f33f372ad19b6a91cffa1e66bcaa046 Reviewed-on: https://chromium-review.googlesource.com/704583 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#507383} [modify] https://crrev.com/3a43619de3ef342363b9fecfb1dbf817b905856f/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
Comment 1 by achuith@chromium.org
, Jan 18 2017