Feature description: Support linear fp16 scRGB output for chrome video, in particular for HDR videos. This is currently mostly for Windows, but may be relevant on other platforms in the future.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71cc0f83777bfa22f2286efd81b297680bfee4bd commit 71cc0f83777bfa22f2286efd81b297680bfee4bd Author: hubbe <hubbe@chromium.org> Date: Thu Jan 19 23:09:10 2017 HDR preparations 1. Make HDR transfer functions return values greater than 1.0 2. Add IsHDR() to gfx::ColorSpace 3. Add CreateSCRGB() to gfx::ColorSpace BUG= 682416 Review-Url: https://codereview.chromium.org/2640393002 Cr-Commit-Position: refs/heads/master@{#444878} [modify] https://crrev.com/71cc0f83777bfa22f2286efd81b297680bfee4bd/ui/gfx/color_space.cc [modify] https://crrev.com/71cc0f83777bfa22f2286efd81b297680bfee4bd/ui/gfx/color_space.h [modify] https://crrev.com/71cc0f83777bfa22f2286efd81b297680bfee4bd/ui/gfx/color_transform.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e0635ee33f5876d1735a5a49ff88fba5366e245 commit 6e0635ee33f5876d1735a5a49ff88fba5366e245 Author: hubbe <hubbe@chromium.org> Date: Fri Jan 20 22:38:17 2017 Don't try to map HDR to SDR if the output is HDR BUG= 682416 Review-Url: https://codereview.chromium.org/2650483002 Cr-Commit-Position: refs/heads/master@{#445189} [modify] https://crrev.com/6e0635ee33f5876d1735a5a49ff88fba5366e245/ui/gfx/color_transform.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b97f42dae25f0481f687e442b79cb3c774391b5d commit b97f42dae25f0481f687e442b79cb3c774391b5d Author: hubbe <hubbe@chromium.org> Date: Fri Jan 27 21:04:09 2017 Create FP16 LUTs when needed When maping HDR data to scRGB, the output can be outside of 0-1. Using half-floats neatly solves this problem. Also, we need the LUTs to be a bit larger in this case. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2648043002 Cr-Commit-Position: refs/heads/master@{#446766} [modify] https://crrev.com/b97f42dae25f0481f687e442b79cb3c774391b5d/cc/output/color_lut_cache.cc [modify] https://crrev.com/b97f42dae25f0481f687e442b79cb3c774391b5d/cc/output/color_lut_cache.h [modify] https://crrev.com/b97f42dae25f0481f687e442b79cb3c774391b5d/cc/output/gl_renderer.cc [modify] https://crrev.com/b97f42dae25f0481f687e442b79cb3c774391b5d/ui/gfx/BUILD.gn [add] https://crrev.com/b97f42dae25f0481f687e442b79cb3c774391b5d/ui/gfx/half_float.cc [add] https://crrev.com/b97f42dae25f0481f687e442b79cb3c774391b5d/ui/gfx/half_float.h [add] https://crrev.com/b97f42dae25f0481f687e442b79cb3c774391b5d/ui/gfx/half_float_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc96e9c35a0807bb6b55d416b53b10f2dc2cc3a2 commit bc96e9c35a0807bb6b55d416b53b10f2dc2cc3a2 Author: hubbe <hubbe@chromium.org> Date: Fri Jan 27 23:49:13 2017 Add LINEAR_HDR so that the linear scRGB colorspace will be HDR BUG= 682416 Review-Url: https://codereview.chromium.org/2641143004 Cr-Commit-Position: refs/heads/master@{#446837} [modify] https://crrev.com/bc96e9c35a0807bb6b55d416b53b10f2dc2cc3a2/ui/gfx/color_space.cc [modify] https://crrev.com/bc96e9c35a0807bb6b55d416b53b10f2dc2cc3a2/ui/gfx/color_space.h [modify] https://crrev.com/bc96e9c35a0807bb6b55d416b53b10f2dc2cc3a2/ui/gfx/color_space_win.cc [modify] https://crrev.com/bc96e9c35a0807bb6b55d416b53b10f2dc2cc3a2/ui/gfx/color_transform.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51 commit c65bdaaa36e9237c9ef1f11ea58b89b828fcea51 Author: ccameron <ccameron@chromium.org> Date: Fri Feb 03 12:02:59 2017 cc: Separate YUV from LUT color conversion Merge all of resource_multiplier, resource_offset, yuv_matrix, and yuv_adj into a single variable, yuv_and_resource_matrix. Use this regardless of using a LUT for color conversion. Move LUT based color conversion out of YUV to RGB code. In this instance, use yuv_and_resource_matrix only for resource scaling and offset. Don't actually delete the old YUV code yet (that's coming next). BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2674763003 Cr-Commit-Position: refs/heads/master@{#447975} [modify] https://crrev.com/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51/cc/output/gl_renderer.cc [modify] https://crrev.com/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51/cc/output/gl_renderer_unittest.cc [modify] https://crrev.com/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51/cc/output/program_binding.h [modify] https://crrev.com/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51/cc/output/shader.cc [modify] https://crrev.com/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51/cc/output/shader.h [modify] https://crrev.com/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48 commit e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48 Author: hubbe <hubbe@chromium.org> Date: Fri Feb 17 02:35:33 2017 Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696963002 Cr-Commit-Position: refs/heads/master@{#451192} [modify] https://crrev.com/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48/media/gpu/dxva_video_decode_accelerator_win.h [modify] https://crrev.com/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48/ui/gfx/color_space_win.cc [modify] https://crrev.com/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48/ui/gfx/color_space_win.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a1e5ced806c4452252e6531e50b3549b31f5f96 commit 4a1e5ced806c4452252e6531e50b3549b31f5f96 Author: jbauman <jbauman@chromium.org> Date: Fri Feb 17 22:08:08 2017 Revert of Replace IMFTransform with ID3D11VideoProcessor (patchset #5 id:80001 of https://codereview.chromium.org/2696963002/ ) Reason for revert: Crashes on Intel GPU drivers. e.g. https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28Intel%20HD%20530%29/builds/246 BUG= 693708 TBR=hubbe@chromium.org Original issue's description: > Replace IMFTransform with ID3D11VideoProcessor > > As far as I can tell, ID3D11VideoProcessor is the only one that understands > how to convert HDR10 content into scRGB textures. A future change will enable > use of this in order to properly decode HDR content. > > BUG= 682416 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2696963002 > Cr-Commit-Position: refs/heads/master@{#451192} > Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48 TBR=ccameron@chromium.org,hubbe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 682416 Review-Url: https://codereview.chromium.org/2701933002 Cr-Commit-Position: refs/heads/master@{#451385} [modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/media/gpu/dxva_video_decode_accelerator_win.h [modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/ui/gfx/color_space_win.cc [modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/ui/gfx/color_space_win.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7aa56504f87294f9b5b047401eb6fe4b59768c9d commit 7aa56504f87294f9b5b047401eb6fe4b59768c9d Author: hubbe <hubbe@chromium.org> Date: Wed Feb 22 06:26:14 2017 Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696963002 Cr-Original-Commit-Position: refs/heads/master@{#451192} Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48 Review-Url: https://codereview.chromium.org/2696963002 Cr-Commit-Position: refs/heads/master@{#451898} [modify] https://crrev.com/7aa56504f87294f9b5b047401eb6fe4b59768c9d/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/7aa56504f87294f9b5b047401eb6fe4b59768c9d/media/gpu/dxva_video_decode_accelerator_win.h [modify] https://crrev.com/7aa56504f87294f9b5b047401eb6fe4b59768c9d/ui/gfx/color_space_win.cc [modify] https://crrev.com/7aa56504f87294f9b5b047401eb6fe4b59768c9d/ui/gfx/color_space_win.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35 commit ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35 Author: hubbe <hubbe@chromium.org> Date: Thu Feb 23 00:13:54 2017 Propagate color space from the container to the codec. This lets the codec tag and convert frames better. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2708353004 Cr-Commit-Position: refs/heads/master@{#452295} [modify] https://crrev.com/ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35/media/filters/gpu_video_decoder.cc [modify] https://crrev.com/ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35/media/filters/h264_parser.cc [modify] https://crrev.com/ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35/media/gpu/ipc/common/media_param_traits_macros.h [modify] https://crrev.com/ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35/media/video/video_decode_accelerator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27aabb44f4320bcd7e6b01d33cc1649e2f955194 commit 27aabb44f4320bcd7e6b01d33cc1649e2f955194 Author: hubbe <hubbe@chromium.org> Date: Thu Feb 23 20:50:03 2017 Use video profile to decide if we should produce fp16 textures. For video profiles with more than 8 bits, use fp16 textures if supported so that we don't loose accuracy. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2709153004 Cr-Commit-Position: refs/heads/master@{#452618} [modify] https://crrev.com/27aabb44f4320bcd7e6b01d33cc1649e2f955194/media/gpu/dxva_picture_buffer_win.cc [modify] https://crrev.com/27aabb44f4320bcd7e6b01d33cc1649e2f955194/media/gpu/dxva_picture_buffer_win.h [modify] https://crrev.com/27aabb44f4320bcd7e6b01d33cc1649e2f955194/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/27aabb44f4320bcd7e6b01d33cc1649e2f955194/media/gpu/dxva_video_decode_accelerator_win.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94faa14d4e4793066fc49f41bb298b2fa9d8ba8e commit 94faa14d4e4793066fc49f41bb298b2fa9d8ba8e Author: hubbe <hubbe@chromium.org> Date: Fri Feb 24 01:34:14 2017 Make sure that we update the color space when re-creating the video processor. BUG= 682416 Review-Url: https://codereview.chromium.org/2712683004 Cr-Commit-Position: refs/heads/master@{#452709} [modify] https://crrev.com/94faa14d4e4793066fc49f41bb298b2fa9d8ba8e/media/gpu/dxva_video_decode_accelerator_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3944b9334aa1e6bd10f2627294f82d3e6b92c549 commit 3944b9334aa1e6bd10f2627294f82d3e6b92c549 Author: hubbe <hubbe@chromium.org> Date: Wed Mar 01 22:06:04 2017 enable fp16 when --enable-hdr-output is on Unfortunately the VP9 profile is currently set to VP9PROFILE_PROFILE0 even when the videos are profile 2 in most cases, until we get that fixed we'll enable fp16 mode whenever HDR mode is on. Also, when fp16 and HDR is on, return scRGB linear textures. BUG= 682416 Review-Url: https://codereview.chromium.org/2721893003 Cr-Commit-Position: refs/heads/master@{#454057} [modify] https://crrev.com/3944b9334aa1e6bd10f2627294f82d3e6b92c549/media/gpu/BUILD.gn [modify] https://crrev.com/3944b9334aa1e6bd10f2627294f82d3e6b92c549/media/gpu/DEPS [modify] https://crrev.com/3944b9334aa1e6bd10f2627294f82d3e6b92c549/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/3944b9334aa1e6bd10f2627294f82d3e6b92c549/media/gpu/dxva_video_decode_accelerator_win.h
hubbe@, This should be related: https://github.com/KhronosGroup/WebGL/issues/2274. "GL_RGB10_A2 format missing in texImageSource variants of tex(Sub)Image2D".
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d232d0c861bf43ce092894e33ba277906fa513b8 commit d232d0c861bf43ce092894e33ba277906fa513b8 Author: hubbe <hubbe@chromium.org> Date: Wed Mar 15 21:51:06 2017 Fix HDR LUTs The switch to gamma 2.2 compositing broke an assumption in the LUT generation. This CL replaces the assumption with a more robust one. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2747083006 Cr-Commit-Position: refs/heads/master@{#457221} [modify] https://crrev.com/d232d0c861bf43ce092894e33ba277906fa513b8/cc/output/color_lut_cache.cc [modify] https://crrev.com/d232d0c861bf43ce092894e33ba277906fa513b8/ui/gfx/color_space.cc [modify] https://crrev.com/d232d0c861bf43ce092894e33ba277906fa513b8/ui/gfx/color_space.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ae00738df4fa4087cb6ec8c8ae1d3796483e066 commit 4ae00738df4fa4087cb6ec8c8ae1d3796483e066 Author: hubbe <hubbe@chromium.org> Date: Wed Mar 22 18:56:21 2017 Suport for hybrid-log-gamma in DXVA This hack could also be extended to support more transfer functions. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2768643002 Cr-Commit-Position: refs/heads/master@{#458822} [modify] https://crrev.com/4ae00738df4fa4087cb6ec8c8ae1d3796483e066/media/gpu/dxva_video_decode_accelerator_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1b0096d4e30422d3084c0e238684e45ff61083c commit b1b0096d4e30422d3084c0e238684e45ff61083c Author: hubbe <hubbe@chromium.org> Date: Mon Mar 27 23:17:41 2017 make --enable-hdr imply --enable-features=video-color-management EOM BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2773043004 Cr-Commit-Position: refs/heads/master@{#459929} [modify] https://crrev.com/b1b0096d4e30422d3084c0e238684e45ff61083c/cc/output/gl_renderer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75705ebbf91265a8db5218d1acff3f1026777e9e commit 75705ebbf91265a8db5218d1acff3f1026777e9e Author: hubbe <hubbe@chromium.org> Date: Tue Apr 04 03:47:09 2017 FP16 mode gamma fix Works around a bug in nvidia drivers which doesn't do gamma conversions even when we asked for it. The workaround is to keep the intermediate texture in gamma 2.2 and let the compositor figure out how to draw it correctly. Also fix an minor unrelated issue in color_space_win.cc Really we shouldn't be using fp16 at all in this mode, but I haven't figured out a reliable signal for the bit depth yet. BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2791023002 Cr-Commit-Position: refs/heads/master@{#461623} [modify] https://crrev.com/75705ebbf91265a8db5218d1acff3f1026777e9e/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/75705ebbf91265a8db5218d1acff3f1026777e9e/ui/gfx/color_space_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e749951e2d9689e61ba9b72ada59ab04166e4927 commit e749951e2d9689e61ba9b72ada59ab04166e4927 Author: hubbe <hubbe@chromium.org> Date: Wed Apr 05 22:35:04 2017 Add --enable-hdr to about:flags EOM BUG= 682416 Review-Url: https://codereview.chromium.org/2785433003 Cr-Commit-Position: refs/heads/master@{#462249} [modify] https://crrev.com/e749951e2d9689e61ba9b72ada59ab04166e4927/chrome/browser/about_flags.cc [modify] https://crrev.com/e749951e2d9689e61ba9b72ada59ab04166e4927/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/e749951e2d9689e61ba9b72ada59ab04166e4927/chrome/browser/flag_descriptions.h [modify] https://crrev.com/e749951e2d9689e61ba9b72ada59ab04166e4927/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/0209d792775b1efa537a6c30cfeee699a33a82da commit 0209d792775b1efa537a6c30cfeee699a33a82da Author: Bruce Dawson <brucedawson@chromium.org> Date: Wed May 31 23:38:01 2017 Fix toolchain packaging script for latest SDKs On recent SDKs the size of the toolchain package grew. This change filters out some unneeded directories in order to minimize this growth. This change also fixes the bin paths for the 10.0.15063.0 SDK. Starting with this SDK version the SDK version is part of the path. The script does *not* handle packaging older SDKs anymore - older versions of the script can be used for that purpose. The 10.0.15063.0 SDK will be needed eventually in order to support Windows 10 Creators Update. Test builds are running on crrev.com/2913873003 (VS 2017) and crrev.com/2914643003 (VS 2015). Bug: 683729 , 682416 Change-Id: Ia89e3253869a45dd10c923a2edee53aaf086e12c Reviewed-on: https://chromium-review.googlesource.com/519982 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> [modify] https://crrev.com/0209d792775b1efa537a6c30cfeee699a33a82da/win_toolchain/package_from_installed.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6460371218a734a724df68694975882f22c52d31 commit 6460371218a734a724df68694975882f22c52d31 Author: brucedawson <brucedawson@chromium.org> Date: Thu Jun 15 00:31:12 2017 VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script was updated in https://chromium-review.googlesource.com/c/534353/ to support this version and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG= 682416 , 727970 , 683729 Review-Url: https://codereview.chromium.org/2938453003 Cr-Commit-Position: refs/heads/master@{#479555} [modify] https://crrev.com/6460371218a734a724df68694975882f22c52d31/build/vs_toolchain.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/407583a866bb1839b09289b5f2e856b15700ea51 commit 407583a866bb1839b09289b5f2e856b15700ea51 Author: brucedawson <brucedawson@chromium.org> Date: Fri Jun 16 01:50:24 2017 VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. This is necessary for crrev.com/2938543002. As a side-effect of the repackaging it also upgrades the compiler from 19.00.24213.1 to 19.00.24215.1. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG= 682416 Review-Url: https://codereview.chromium.org/2914643003 Cr-Commit-Position: refs/heads/master@{#479900} [modify] https://crrev.com/407583a866bb1839b09289b5f2e856b15700ea51/build/vs_toolchain.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9ab2095d1f334506aa74681fa758adf03ab4a13 commit b9ab2095d1f334506aa74681fa758adf03ab4a13 Author: hubbe <hubbe@chromium.org> Date: Tue Jun 27 00:09:12 2017 Detect HDR capability This calls the windows API for detecting if the output display can do HDR output or not. Note that this API depends on a recent version of the WinSDK, but has been guarded by ifdefs to make sure that it compiles even without the new SDK. (But without HDR detection.) BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2938543002 Cr-Commit-Position: refs/heads/master@{#482479} [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/config/gpu_info.cc [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/config/gpu_info.h [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/config/gpu_info_collector.cc [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/ipc/common/gpu_info.mojom [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/ipc/common/gpu_info_struct_traits.cc [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/ipc/common/gpu_info_struct_traits.h [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/ipc/common/gpu_param_traits_macros.h [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/ipc/service/direct_composition_surface_win.cc [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/ipc/service/direct_composition_surface_win.h [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/gpu/ipc/service/gpu_init.cc [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/tools/metrics/histograms/enums.xml [modify] https://crrev.com/b9ab2095d1f334506aa74681fa758adf03ab4a13/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f11afb3cbcf7b674f9ae6c130a2ec01b515066a2 commit f11afb3cbcf7b674f9ae6c130a2ec01b515066a2 Author: hubbe <hubbe@chromium.org> Date: Tue Jun 27 23:18:25 2017 Fix some bugs in the HDR detection code Fixes: HDR detection defaults to true Should compile without warnings on old SDK BUG= 682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2958143002 Cr-Commit-Position: refs/heads/master@{#482784} [modify] https://crrev.com/f11afb3cbcf7b674f9ae6c130a2ec01b515066a2/gpu/ipc/service/direct_composition_surface_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/853276ff285e4e76711476144d387048c37e7e77 commit 853276ff285e4e76711476144d387048c37e7e77 Author: hubbe <hubbe@chromium.org> Date: Sun Jul 02 06:44:59 2017 propagate display color space changes Without this change, RenderWidgetHostViewAura doesn't get notified when the color space changes. BUG= 682416 Review-Url: https://codereview.chromium.org/2963223002 Cr-Commit-Position: refs/heads/master@{#483919} [modify] https://crrev.com/853276ff285e4e76711476144d387048c37e7e77/ui/display/display_change_notifier.cc [modify] https://crrev.com/853276ff285e4e76711476144d387048c37e7e77/ui/display/display_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52209cb5ae750acd66a8eb515667a68be4e737aa commit 52209cb5ae750acd66a8eb515667a68be4e737aa Author: Christopher Cameron <ccameron@chromium.org> Date: Sat Jul 29 07:24:58 2017 hdr: Change HDR from flag to base::Feature In some instances, rather than update the logic to use the base::Feature instead of the command line switch, simply delete the old logic (especially logic that checks for color correct rendering being enabled). R=holte,hubbe,jbauman TBR=avi (content/ stamp) Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7dbc0c6151e353e94600ff83d975909b96af9fb4 Reviewed-on: https://chromium-review.googlesource.com/589348 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: John Bauman <jbauman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490643} [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/chrome/browser/about_flags.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/content/browser/web_contents/web_contents_view_aura_unittest.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/gpu/ipc/service/direct_composition_child_surface_win.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/gpu/ipc/service/direct_composition_child_surface_win.h [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/gpu/ipc/service/direct_composition_surface_win.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/gpu/ipc/service/direct_composition_surface_win.h [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/media/base/decode_capabilities.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/tools/metrics/histograms/enums.xml [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/ui/compositor/compositor.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/ui/compositor/compositor_util.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/ui/display/display.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/ui/display/display.h [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/ui/display/display_switches.cc [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/ui/display/display_switches.h [modify] https://crrev.com/52209cb5ae750acd66a8eb515667a68be4e737aa/ui/display/display_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75 commit a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75 Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Aug 02 01:59:09 2017 hdr: Move more logic into gfx::ColorSpace Add helper in gfx::ColorSpace to, given an output color space, compute - the space in which rasterization should be performed - the space in which blending should be performed. Remove a place in the ui::Compositor where we check the kHighDyanmicRange feature, and use the above helper functions instead. Add logic in display::Display to automatically update the bit depth for media queries based on whether or not the output color space is HDR. Allow forcing an scrgb-linear profile using the --force-color-profile argument. Add logic in display::ScreenWin to enable HDR mode. This currently queries the HDR feature, but will pull the logic out of the GPU process in the next patch. R=hubbe TBR=avi (for content/) Bug: 682416 Change-Id: Ieffca5a3e0fa01a98aea5558db251712989519e7 Reviewed-on: https://chromium-review.googlesource.com/596776 Reviewed-by: ccameron chromium <ccameron@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#491211} [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/content/renderer/render_widget.cc [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/compositor/compositor.cc [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/display/display.cc [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/display/display.h [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/display/display_unittest.cc [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/display/win/screen_win.cc [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/display/win/screen_win.h [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/gfx/color_space.cc [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/gfx/color_space.h [modify] https://crrev.com/a1ea2b7987ba6d8f9cb481c13cbe85b82e32df75/ui/gfx/color_space_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f7e4ff153d7e74a88f69a24693202b819d2bc58 commit 2f7e4ff153d7e74a88f69a24693202b819d2bc58 Author: Fredrik Hubinette <hubbe@google.com> Date: Fri Aug 11 00:34:49 2017 Plumb output color space to video decoder This lets the video decoder handle HDR. Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8b398c258ca9cafa2b425422d57152b673ff563d Reviewed-on: https://chromium-review.googlesource.com/601057 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#493616} [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/chromecast/media/service/cast_mojo_media_client.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/content/renderer/media/android/media_player_renderer_client_factory.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/content/renderer/media/android/media_player_renderer_client_factory.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/base/renderer_factory.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/base/renderer_factory_selector_unittest.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/filters/gpu_video_decoder.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/filters/gpu_video_decoder.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/gpu/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/gpu/ipc/common/media_param_traits_macros.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/mojo/clients/mojo_renderer_factory.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/mojo/clients/mojo_renderer_factory.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/mojo/services/interface_factory_impl.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/remoting/courier_renderer_factory.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/remoting/courier_renderer_factory.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/renderers/default_renderer_factory.cc [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/renderers/default_renderer_factory.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/media/video/video_decode_accelerator.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/third_party/WebKit/Source/core/html/HTMLMediaElement.h [modify] https://crrev.com/2f7e4ff153d7e74a88f69a24693202b819d2bc58/third_party/WebKit/public/platform/WebMediaPlayerClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/391f8b5bcb825cc82f188e317afb99a705fa8910 commit 391f8b5bcb825cc82f188e317afb99a705fa8910 Author: Fredrik Hubinette <hubbe@google.com> Date: Mon Aug 28 23:44:07 2017 hdr layout tests Adds a small set of layout tests that will be forced to run in HDR mode by using PhysicalTestSuite. Bug: 682416 Change-Id: I21ba80dcd77e2fcf3b52493e90897bb7069c053a Reviewed-on: https://chromium-review.googlesource.com/630916 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#497940} [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/OWNERS [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/README.md [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/color-jpeg-with-color-profile-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/color-jpeg-with-color-profile-expected.txt [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/color-jpeg-with-color-profile.html [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/color-profile-video-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/color-profile-video-expected.txt [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/color-profile-video.html [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/video-canvas-alpha-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/video-canvas-alpha-expected.txt [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/hdr/video-canvas-alpha.html [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/platform/linux/hdr/color-jpeg-with-color-profile-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/platform/linux/hdr/color-profile-video-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/platform/linux/hdr/video-canvas-alpha-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/platform/mac/hdr/color-jpeg-with-color-profile-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/platform/mac/hdr/color-profile-video-expected.png [add] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/LayoutTests/platform/mac/hdr/video-canvas-alpha-expected.png [modify] https://crrev.com/391f8b5bcb825cc82f188e317afb99a705fa8910/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f21e201655b13db8d51873070f24c3c65bd378f2 commit f21e201655b13db8d51873070f24c3c65bd378f2 Author: Christopher Cameron <ccameron@chromium.org> Date: Thu Oct 12 20:08:49 2017 hdr: Don't use angle D3D11Device to query HDR The HDR state is snapshotted at the time that the D3D11Device is created. This needs to return the most up to date value every time that it is called. Also remove the ENABLE_HDR_DETECTION guard since it's no longer needed. Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8b6b05f077309dbf58fcc189e2fb36b3a8d3c2c3 Reviewed-on: https://chromium-review.googlesource.com/714495 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#508423} [modify] https://crrev.com/f21e201655b13db8d51873070f24c3c65bd378f2/gpu/ipc/service/BUILD.gn [modify] https://crrev.com/f21e201655b13db8d51873070f24c3c65bd378f2/gpu/ipc/service/direct_composition_surface_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/690c132bc1c2e23c0948e3bd7d7600c8bbda4a2f commit 690c132bc1c2e23c0948e3bd7d7600c8bbda4a2f Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Oct 13 02:23:29 2017 Revert "hdr: Don't use angle D3D11Device to query HDR" This reverts commit f21e201655b13db8d51873070f24c3c65bd378f2. Reason for revert: Broke layout tests on Win7. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56507 Original change's description: > hdr: Don't use angle D3D11Device to query HDR > > The HDR state is snapshotted at the time that the D3D11Device is > created. This needs to return the most up to date value every time that > it is called. > > Also remove the ENABLE_HDR_DETECTION guard since it's no longer needed. > > Bug: 682416 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I8b6b05f077309dbf58fcc189e2fb36b3a8d3c2c3 > Reviewed-on: https://chromium-review.googlesource.com/714495 > Commit-Queue: ccameron chromium <ccameron@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508423} TBR=ccameron@chromium.org,zmo@chromium.org,geofflang@chromium.org Change-Id: I811f2ee5fd08a109a530049bd734746a9187c905 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/716937 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#508580} [modify] https://crrev.com/690c132bc1c2e23c0948e3bd7d7600c8bbda4a2f/gpu/ipc/service/BUILD.gn [modify] https://crrev.com/690c132bc1c2e23c0948e3bd7d7600c8bbda4a2f/gpu/ipc/service/direct_composition_surface_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf commit 51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf Author: Christopher Cameron <ccameron@chromium.org> Date: Sat Oct 14 00:01:45 2017 hdr: Add auto-detection of HDR setting Add an IPC function to be called whenever the display settings are changed, to check if HDR settings have changed. Remove hdr from GPUInfo. Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib63a37cdad44fb0f5cae6e31948e9322f7298802 Reviewed-on: https://chromium-review.googlesource.com/708136 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#508882} [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/components/viz/service/gl/gpu_service_impl.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/components/viz/service/gl/gpu_service_impl.h [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/content/browser/browser_main_loop.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/content/browser/gpu/gpu_process_host.h [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/gpu/config/gpu_info.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/gpu/config/gpu_info.h [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/gpu/config/gpu_info_collector.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/gpu/ipc/common/gpu_info.mojom [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/gpu/ipc/common/gpu_info_struct_traits.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/gpu/ipc/common/gpu_info_struct_traits.h [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/gpu/ipc/service/gpu_init.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/services/viz/privileged/interfaces/gl/gpu_service.mojom [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/ui/display/win/screen_win.cc [modify] https://crrev.com/51e1d9e7d6b6ce580fcdc5cb862038aba02e1bbf/ui/display/win/screen_win.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad7e1638273e5b6929880062e550ca9d0baec47d commit ad7e1638273e5b6929880062e550ca9d0baec47d Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Oct 16 09:06:35 2017 hdr: Don't use angle D3D11Device to query HDR The HDR state is snapshotted at the time that the D3D11Device is created. This needs to return the most up to date value every time that it is called. Also remove the ENABLE_HDR_DETECTION guard since it's no longer needed. The previous landing of this patch crashed because it used a cast from IDXGIOutput to IDXGIOutput6 rather than using QueryInterface. Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icb7e0c7c4bd810da0c4433ada6ff76750aafd545 Reviewed-on: https://chromium-review.googlesource.com/719956 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#509000} [modify] https://crrev.com/ad7e1638273e5b6929880062e550ca9d0baec47d/gpu/ipc/service/BUILD.gn [modify] https://crrev.com/ad7e1638273e5b6929880062e550ca9d0baec47d/gpu/ipc/service/direct_composition_surface_win.cc
Comment 1 by bugdroid1@chromium.org
, Jan 19 2017