mash: ash crashes on startup with --enable-touchview |
|||||||||
Issue descriptionToT at r444462 * Run chrome --mash --enable-touchview * Ash crashes on startup This is probably due to initializing ash::Shell in mash. Unfortunately it prevents ash from starting on convertible/yoga devices, which pass this flag by default. [14089:14089:0118/134724.310510:1229247151505:FATAL:input_device_manager.cc(13)] Check failed: instance_. #0 0x7f165ee2458e base::debug::StackTrace::StackTrace() #1 0x7f165ee4623a logging::LogMessage::~LogMessage() #2 0x7f1658a3e7e5 ui::InputDeviceManager::GetInstance() #3 0x7f1658d691cb ash::TabletPowerButtonController::TabletPowerButtonController() #4 0x7f1658d7a5c8 ash::PowerButtonController::PowerButtonController() #5 0x7f1658d62b89 ash::Shell::Init() #6 0x7f1658d62096 ash::Shell::CreateInstance() #7 0x7f1660336cd8 ash::mus::WindowManager::CreateShell() #8 0x7f1660336da7 ash::mus::WindowManager::CreateRootWindowController() #9 0x7f1660337367 ash::mus::WindowManager::OnWmNewDisplay() #10 0x7f165977d706 aura::WindowTreeClient::WmNewDisplayAddedImpl() #11 0x7f1659782024 aura::WindowTreeClient::WmNewDisplayAdded() #12 0x7f1659797b89 ui::mojom::WindowManagerStubDispatch::Accept() #13 0x7f165f38908d mojo::InterfaceEndpointClient::HandleValidatedMessage() #14 0x7f165f388916 mojo::FilterChain::Accept() #15 0x7f165f389feb mojo::InterfaceEndpointClient::HandleIncomingMessage() #16 0x7f165f390989 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #17 0x7f165f39037d mojo::internal::MultiplexRouter::Accept() #18 0x7f165f388916 mojo::FilterChain::Accept() #19 0x7f165f38485e mojo::Connector::ReadSingleMessage() #20 0x7f165f384dd1 mojo::Connector::OnHandleReadyInternal() #21 0x7f165f36a304 mojo::Watcher::OnHandleReady() #22 0x7f165f36a401 _ZN4base8internal13FunctorTraitsIMN4mojo7WatcherEFvjEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKjEEEvS5_OT_DpOT0_ #23 0x7f165ee2513e base::debug::TaskAnnotator::RunTask() #24 0x7f165ee5328d base::MessageLoop::RunTask() #25 0x7f165ee53ba5 base::MessageLoop::DoWork() #26 0x7f165ee56189 base::MessagePumpLibevent::Run() #27 0x7f165ee53007 base::MessageLoop::RunHandler() #28 0x7f165ee8575f base::RunLoop::Run() #29 0x7f165fa396ed MashRunner::StartChildApp() #30 0x7f165fa3af6c _ZN4base8internal7InvokerINS0_9BindStateIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvS9_EE3RunEPNS0_13BindStateBaseEOS9_ #31 0x7f1660354840 service_manager::RunStandaloneService() #32 0x7f165fa38ad7 MashRunner::RunChild() #33 0x7f165fa397cd MashMain() #34 0x7f165fa36e70 ChromeMain #35 0x7f165588ff45 __libc_start_main #36 0x7f165fa36ced <unknown>
,
Jan 18 2017
,
Jan 18 2017
We can probably just check for null for now, although we'll need some way to detect when the stylus is ejected within mash in order to get this working correctly.
,
Jan 18 2017
I've filed issue 682460 to track re-enabling this code.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7493b52a7df965340262a60de51780cbf978dbff commit 7493b52a7df965340262a60de51780cbf978dbff Author: derat <derat@chromium.org> Date: Thu Jan 19 00:45:37 2017 mash: Fix TabletPowerButtonController segfault. Make TabletPowerButtonController check that ui::InputDeviceManager exists before trying to register itself with it. BUG= 682403 , 682460 Review-Url: https://codereview.chromium.org/2645523004 Cr-Commit-Position: refs/heads/master@{#444571} [modify] https://crrev.com/7493b52a7df965340262a60de51780cbf978dbff/ash/system/chromeos/power/tablet_power_button_controller.cc
,
Jan 19 2017
This fixes the segfault for me when running on kevin.
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Feb 26 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jamescook@chromium.org
, Jan 18 2017