New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682400 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

All builders that don't use VMTests should run on GCE.

Project Member Reported by dgarr...@chromium.org, Jan 18 2017

Issue description

All ChromeOS build configs define which buildslave_type to use, though some waterfalls ignore those values.

We should use GCE_BEEFY_BUILD_SLAVE_TYPE by default, and only use a different type of the build config explicitly calls out something different (like WIMPY).

The exception to this is builders which run VMTests, which must be assigned to BAREMETAL_BUILD_SLAVE_TYPE.
 
Cc: d...@chromium.org nxia@chromium.org akes...@chromium.org
We just received the quota increase, and most of the assorted CLs have been sent out, except for adding the following new beefy instances to the matching waterfalls.

  # 283 to 342: master.chromeos_release
  # 343 to 422: master.chromeos

Is the process for doing #1 documented somewhere?
Earlier, I missed that the chromiumos waterfall needs 6 new GCE build machines. I'll update the CLs for that shortly.
In the end, the buildbot waterfall configuration controls this.

Some waterfalls (chromeos, chromeos_release, and I THINK chromiumos) pay attention to the "buildslave_type" value defined in chromeos_config configs.

Or do you mean how to change the default value for a build config entry? All ChromeOS build config entries (and their defaults) are define in config_lib.py.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/65e5878b266f1854f0e65d04025120a75b488328

commit 65e5878b266f1854f0e65d04025120a75b488328
Author: Don Garrett <dgarrett@google.com>
Date: Thu Jan 19 19:18:26 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b287904db494d19375972df8e7927267918cb296

commit b287904db494d19375972df8e7927267918cb296
Author: Don Garrett <dgarrett@google.com>
Date: Wed Jan 18 23:01:20 2017

chromeos_config: Use GCE_BEEFY builders by default.

Use GCE_BEEFY instead of BAREMETAL by default, but ensure that all
builders requiring VMTESTS are on BAREMETAL.

This is ignored by some waterfalls, and gives incorrect information
for the trybot waterfall (since trybots use vm_tests_override instead
of vmtests).

Also, move the CQ_MASTER to a GCE_WIMPY.

BUG= chromium:682400 
TEST=run_tests

Change-Id: I57d0601a72c83e8f3b6679847096a24eddcf6bfa
Reviewed-on: https://chromium-review.googlesource.com/430193
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/b287904db494d19375972df8e7927267918cb296/cbuildbot/config_dump.json
[modify] https://crrev.com/b287904db494d19375972df8e7927267918cb296/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/b287904db494d19375972df8e7927267918cb296/lib/config_lib.py
[modify] https://crrev.com/b287904db494d19375972df8e7927267918cb296/cbuildbot/chromeos_config.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/42c1b6ffa0b998699c73e7cc2bf7d355a909afe6

commit 42c1b6ffa0b998699c73e7cc2bf7d355a909afe6
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jan 20 01:18:06 2017

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/c00281a221ae5bab67aa38dc7b66e5449e8fab10

commit c00281a221ae5bab67aa38dc7b66e5449e8fab10
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Jan 20 01:55:48 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/9e52c1ce22487933d51a601f43c48de69284c024

commit 9e52c1ce22487933d51a601f43c48de69284c024
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Jan 20 02:03:29 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/0fee4f8ad88d1fbe18f698d35a388842e9318771

commit 0fee4f8ad88d1fbe18f698d35a388842e9318771
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jan 20 01:25:49 2017

chromiumos: Add new GCE builders.

Add new GCE builders to help move as many ChromeOS builds as possible
to GCE.

Update ChromeOS Chromite pins.
  - [master]
    1282a5ef7fae91127f56cecc0b06d952faffa954 =>
      b287904db494d19375972df8e7927267918cb296

BUG= chromium:682400 

Change-Id: Iad1d1dbcc5ca37baa8fe972bfbcc3cfd0093d82a
Reviewed-on: https://chromium-review.googlesource.com/430322
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/0fee4f8ad88d1fbe18f698d35a388842e9318771/masters/master.chromiumos/slave_pool.json
[modify] https://crrev.com/0fee4f8ad88d1fbe18f698d35a388842e9318771/masters/master.chromiumos/slaves.cfg
[modify] https://crrev.com/0fee4f8ad88d1fbe18f698d35a388842e9318771/scripts/common/cros_chromite_pins.json

This should now be fixed for the chromeos and chromiumos waterfalls. Logic is in place to fix this on the chromeos_release waterfall as new branches are created.

No effort has been made to address this on the chromeos.branch or chromeos.chrome waterfalls. It has been partially addressed on the trybot waterfall for a while now.
Status: Fixed (was: Started)

Comment 14 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 15 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 17 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment