New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682390 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Error page is not shown in LSO in case GAIA server returns error.

Project Member Reported by khmel@chromium.org, Jan 18 2017

Issue description

Inner bug: b/34108212

As in title

CL: http://crrev.com/2618603003
 

Comment 1 by khmel@chromium.org, Jan 18 2017

Labels: Merge-Request-56

Comment 2 by khmel@chromium.org, Jan 18 2017

Cc: bhthompson@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 18 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-56 Merge-Approved-56
ARC++ specific code changes only.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b04a3d75750e868b4854416fd0cd6f6771b87adc

commit b04a3d75750e868b4854416fd0cd6f6771b87adc
Author: khmel <khmel@chromium.org>
Date: Thu Jan 19 21:17:58 2017

[Merge M56] arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/34111604
BUG=b/34108212
BUG= 682389 
BUG= 682390 
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=xiyuan@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2618603003
Cr-Commit-Position: refs/heads/master@{#441792}
(cherry picked from commit dc76842c78febcda874276d1d06971c7dbb99e9b)

Review-Url: https://codereview.chromium.org/2642763008
Cr-Commit-Position: refs/branch-heads/2924@{#804}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_auth_service.h
[modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_support_host.h
[modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/resources/chromeos/arc_support/background.js

Comment 6 by khmel@chromium.org, Jan 19 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment