arc: UMA statistics is missing for failures in LSO page |
|||||||
Issue descriptionInner bug: b/34111604 This prevents from analyzing ARC work. For example here: https://uma.googleplex.com/variations?sid=c94b19f659dfa9459c12111e3af9f93f this distorts finch experiment results. CL: http://crrev.com/2618603003
,
Jan 18 2017
,
Jan 18 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
ARC++ specific code changes only.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b04a3d75750e868b4854416fd0cd6f6771b87adc commit b04a3d75750e868b4854416fd0cd6f6771b87adc Author: khmel <khmel@chromium.org> Date: Thu Jan 19 21:17:58 2017 [Merge M56] arc: Restore UMA statistics for failures in LSO flow. This restores UMA reporting for failures in preparing HTTP contexts and also adds UMA reporting for auth failures in LSO to keep balanced with silent auth flow. Also fixes error when error page is not shown in case of GAIA server returns error. BUG=b/34111604 BUG=b/34108212 BUG= 682389 BUG= 682390 TEST=Manually on device. Simulated error case. Made sure that UMA is reported and expected error page is shown CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2618603003 Cr-Commit-Position: refs/heads/master@{#441792} (cherry picked from commit dc76842c78febcda874276d1d06971c7dbb99e9b) Review-Url: https://codereview.chromium.org/2642763008 Cr-Commit-Position: refs/branch-heads/2924@{#804} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_auth_service.cc [modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_auth_service.h [modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_support_host.cc [modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/chromeos/arc/arc_support_host.h [modify] https://crrev.com/b04a3d75750e868b4854416fd0cd6f6771b87adc/chrome/browser/resources/chromeos/arc_support/background.js
,
Jan 19 2017
,
Mar 30 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by khmel@chromium.org
, Jan 18 2017