New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682386 link

Starred by 2 users
Status: Verified
Owner:
khmel@chromium.org
Closed: Jan 2017
Cc:
█ mitsuji@chromium.org
elijahtaylor@chromium.org
█ bhthompson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: ARC cannot be safely disabled

Project Member Reported by khmel@chromium.org, Jan 18 2017 
Inner bug: b/34090891

Start ARC and go to LSO page. Now disable ARC from settings.

Following is expected: UI is closed and that is all.

However depending on race 2 scenarios may happen, both incorrect:
1. UI is closed. However when you try to reenable ARC again (multiple times), nothing happens, no UI, no ARC start.
2. UI is closed however it pops up in second with “Unknown error”. This is unexpected. Moreover if you press “Try Again”, ARC continues loading even if it is disabled. This brings to situation when ARC  may be running in disabled state.

Comment 1 by khmel@chromium.org, Jan 18 2017

Labels: Merge-Request-56
CL: https://codereview.chromium.org/2615793002/

Comment 2 by khmel@chromium.org, Jan 18 2017

Cc: bhthompson@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 18 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by bhthompson@google.com, Jan 18 2017

Labels: -Hotlist-Merge-Review -Merge-Review-56 Merge-Approved-56
ARC++ specific code changes only.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/169c384e8fd6eb6f1041e2f77f01fe342e176e18

commit 169c384e8fd6eb6f1041e2f77f01fe342e176e18
Author: khmel <khmel@chromium.org>
Date: Thu Jan 19 20:46:25 2017

[Merge M56] arc: Fix situation when ARC cannot be disabled safely.

This add filtering error in case of ARC is disabled and try
to re-open UI app when request to show follows soon after
request to close.

BUG=b/34090891
BUG= 682386 
TEST=Manually on device, cases described in bug no longer appear.
TBR=hidehiko@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2615793002
Cr-Commit-Position: refs/heads/master@{#442485}
(cherry picked from commit a2407051a9a2c6e03125c8d959e1ef7d4e441e95)

Review-Url: https://codereview.chromium.org/2646853002
Cr-Commit-Position: refs/branch-heads/2924@{#803}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/169c384e8fd6eb6f1041e2f77f01fe342e176e18/chrome/browser/chromeos/arc/arc_auth_service.cc

Comment 6 by khmel@chromium.org, Jan 19 2017

Status: Fixed (was: Started)

Comment 7 by rookrishna@chromium.org, Feb 28 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment