Some v8 trybots failing to apply patch with "file does not exist in index" |
|||||||
Issue descriptionThe patchset isn't correctly applied when running the CQ. See -- https://codereview.chromium.org/2644723002/ Some platforms work fine but others fail with this error - Failed to apply patch for src/runtime/runtime-object.cc: While running git apply --index -3 -p1 --verbose; Checking patch src/runtime/runtime-object.cc... error: src/runtime/runtime-object.cc: does not exist in index See -- https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/15429/steps/bot_update/logs/patch%20error On a clean build of V8, I'm able to run `git cl patch https://codereview.chromium.org/2644723002/` and the patch applies fine.
,
Jan 18 2017
,
Jan 18 2017
Updating metadata for faster triage
,
Jan 18 2017
,
Jan 18 2017
Strange that CL seems to have passed v8_linux64_avx2_rel_ng since this was filed. Did you resync your checkout and retry CQ?
,
Jan 18 2017
I did not resync and retry.
,
Jan 18 2017
Looks like there's a b0rked checkout on some of those machines. """ Applying the patch from https://codereview.chromium.org/2644723002/#ps1 Found extra files: ['src/runtime/runtime-object.cc'] """ IIUC git is confused by the presence of an *untracked* copy of src/runtime/runtime-object.cc that's somehow already on the slave before bot_update runs. This is not a recently added or removed file (based on git history of it). I'll try clobbering the checkout dir on one of the failing slaves.
,
Jan 18 2017
ran this on slave1204-c4 slave586-c4 and slave871-c4:
chrome-bot@slave871-c4:(Linux 14.04):/b/build/slave/linux_nodcheck/build/v8$ git status
HEAD detached at origin/master
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)
modified: src/compiler/ia32/code-generator-ia32.cc
modified: test/cctest/wasm/test-run-wasm-64.cc
new file: test/mjsunit/regress/wasm/regression-5800.js
Unmerged paths:
(use "git reset HEAD <file>..." to unstage)
(use "git rm <file>..." to mark resolution)
both deleted: src/runtime/runtime-object.cc
chrome-bot@slave871-c4:(Linux 14.04):/b/build/slave/linux_nodcheck/build/v8$ git reset HEAD src/runtime/runtime-object.cc
chrome-bot@slave871-c4:(Linux 14.04):/b/build/slave/linux_nodcheck/build/v8$ git status
HEAD detached at origin/master
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)
modified: src/compiler/ia32/code-generator-ia32.cc
modified: test/cctest/wasm/test-run-wasm-64.cc
new file: test/mjsunit/regress/wasm/regression-5800.js
,
Jan 19 2017
And slave407-c4 just now too.
,
Jan 19 2017
I think the patch step is succeeding now. Reopen if you see this again.
,
Jan 19 2017
Awesome, thanks!
,
Jan 19 2017
It's still happening. I patched https://codereview.chromium.org/2644723002/ into a new CL https://codereview.chromium.org/2639333004 and see the same errors. This is what I did -- https://paste.googleplex.com/6145129031139328
,
Jan 19 2017
vm880-m4 vm204-m4 vm205-m4 slave589-c4 slave411-c4 slave1207-c4 slave415-c4 are doing this now too. WTF is up with these checkouts?
,
Jan 19 2017
I'm not sure what's happening, maybe you can try using git new-branch instead? Though https://www.chromium.org/developers/how-tos/get-the-code/working-with-branches claim they are equivalent, I think there might be a subtle difference?
,
Jan 19 2017
I just tried the same now with new branch, but my toy CL fails too: https://codereview.chromium.org/2641953003/
,
Jan 19 2017
Note this doesn't repro locally. Calling apply_issue -i 2644723002 Everything applies just fine...
,
Jan 19 2017
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639333004/1 just passed a CQ dry run.
,
Jan 19 2017
Is this still preventing you from getting this CL through CQ?
,
Jan 19 2017
Haven't tried updating the CL with review changes yet. Will update this bug once I have an updated patchset and run the trybots
,
Jan 23 2017
I was able to land the CL without any problems. Closing. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by gsat...@chromium.org
, Jan 18 2017