New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682367 link

Starred by 2 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Feb 2017
Cc:
yosin@chromium.org
█ wkorman@chromium.org
editing-dev@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 680384
issue 457415
issue 682364



Sign in to add a comment

Synchronized caret paint invalidation may access dirty layout

Project Member Reported by wangxianzhu@chromium.org, Jan 18 2017 
This is discovered by DCHECK(!needsLayout()) in mapToVisualRectInAncestorSpace():

[ RUN      ] All/WebViewTest.TouchDoesntSelectEmptyTextarea/0
[13092:13092:0118/052946.495175:10627008939:FATAL:LayoutBox.cpp(2332)] Check failed: !needsLayout(). 
#0 0x000001e565be base::debug::StackTrace::StackTrace()
#1 0x000001e6340b logging::LogMessage::~LogMessage()
#2 0x0000032101e0 blink::LayoutBox::mapToVisualRectInAncestorSpace()
#3 0x00000328b9a1 blink::LayoutObject::mapToVisualRectInAncestorSpace()
#4 0x000003467280 blink::PaintLayer::mapRectToPaintInvalidationBacking()
#5 0x000003458b51 blink::ObjectPaintInvalidator::invalidatePaintRectangle()
#6 0x00000328ac6d blink::LayoutObject::invalidatePaintRectangle()
#7 0x000002dc8992 blink::CaretBase::invalidateLocalCaretRect()
#8 0x000002db074a blink::FrameCaret::dataWillChange()
#9 0x000002c3002d blink::CharacterData::setDataAndUpdate()
#10 0x000002c2ffc4 blink::CharacterData::setData()
#11 0x000002e57aea blink::replaceChildrenWithText()
#12 0x00000302c8b7 blink::TextControlElement::setInnerEditorValue()
#13 0x00000300e305 blink::HTMLTextAreaElement::setValueCommon()
#14 0x00000300cd2b blink::HTMLTextAreaElement::setValue()

We should not synchronously invalidate caret.

Comment 1 by wangxianzhu@chromium.org, Jan 18 2017 

Many layout tests crash with the DCHECK because of this bug, e.g.

fast/events/keyboardevent-code.html
fast/forms/focus-change-on-keypress.html
fast/forms/number/number-stepup-stepdown-from-renderer.html
fast/forms/textarea/textarea-value-last-eol.html
fast/forms/validationMessage.html
fast/frames/iframe-window-focus.html
fullscreen/full-screen-contentEditable-crash.html
inspector/console/console-edit-property-value.html
inspector/elements/edit/edit-dom-actions-3.html
inspector/elements/edit/edit-dom-actions-shadow-2.html
inspector/elements/styles-1/add-new-rule-with-style-after-body.html
inspector/elements/styles-1/edit-name-with-trimmed-value.html
inspector/elements/styles-1/edit-value-url-with-color.html
inspector/elements/styles-2/paste-property.html
inspector/elements/styles-3/styles-add-blank-property.html
inspector/elements/styles-3/styles-add-new-rule-colon.html
inspector/elements/styles-3/styles-add-new-rule-tab.html
inspector/elements/styles-3/styles-add-new-rule.html
inspector/elements/styles-3/styles-cancel-editing.html
inspector/elements/styles-3/styles-commit-editing.html
inspector/elements/styles/cancel-upon-invalid-property.html
inspector/elements/styles/undo-after-cancelled-editing.html
inspector/jump-to-previous-editing-location.html
inspector/sass/test-ssp-breaking-edits.html
inspector/sass/test-ssp-editing.html
inspector/sass/test-ssp-incremental-edit-invalid-value.html

Comment 2 by wangxianzhu@chromium.org, Jan 29 2017

Cc: yosin@chromium.org wkorman@chromium.org

Comment 3 by yosin@chromium.org, Jan 30 2017

Blocking: 457415
Note: FrameCaret::nodeWillBeRemoved() also does same thing.

Can we use last |CaretDisplayItemClient::m_visualRect| computed at paint invalidation phase for sync paint invalidation?

If so, we could write:

FrameCaret::dataWillChange(const CharacterData& data) {
  if (m_previousNode != data)
    return;
  invalidate m_visualRect
  m_previousNode = nullptr;
  Reset m_visualRect to empty
  ... reset other state ...
}

Ideal solution is painting caret on layer upon underlying Node. But, I'm not sure how to do that.

Comment 4 by yosin@chromium.org, Jan 30 2017

Components: Blink>Editing>Selection

Comment 5 by yosin@chromium.org, Jan 30 2017

Blocking: 680384

Comment 6 by wangxianzhu@chromium.org, Jan 30 2017 

I'm moving caret paint invalidation into paint invalidation stage, just like paint invalidation of other layout objects. Will upload a patch soon.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94d07a45f859a3430ea9de1ff8c2a95708cb23b1

commit 94d07a45f859a3430ea9de1ff8c2a95708cb23b1
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Feb 07 23:51:23 2017

Invalidate caret during paint invalidation

Previously we invalidated caret when it changed which caused several
issues such as accessing dirty layout, etc., which were also the same
issues when we had encountered before we had "repaint-after-layout".

This CL moves caret paint invalidation into paint invalidation stage
to avoid the issues.

It basically uses the same method as layout object paint invalidation:
save the previous visual rects of carets; when a caret changes,
invalidate both the old and the new visual rects.

BUG= 682367 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2665823002
Cr-Commit-Position: refs/heads/master@{#448799}

[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/paint/invalidation/caret-color-inline-expected.html
[add] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/paint/invalidation/caret-color-inline.html
[add] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update-expected.png
[add] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update.html
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/paint/invalidation/paint-caret-in-div-with-negative-indent-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/4776765-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-contenteditable-content-after-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-outside-block-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-with-transformation-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/delete-into-nested-block-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/inline-outline-repaint-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection-after-delete-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-subpixel-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/dom/CharacterData.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/DragCaret.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/DragCaret.h
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/FrameCaret.h
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/paint/BlockPaintInvalidator.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/paint/BlockPaintInvalidator.h
[add] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/paint/BlockPaintInvalidatorTest.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/paint/BlockPainter.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.cpp
[modify] https://crrev.com/94d07a45f859a3430ea9de1ff8c2a95708cb23b1/third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.h
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c565dd78281dd61ef82e6637ce0dd28c58b18a89

commit c565dd78281dd61ef82e6637ce0dd28c58b18a89
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Feb 08 02:34:31 2017

Auto-rebaseline for r448799

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/598387

https://chromium.googlesource.com/chromium/src/+/94d07a45f859a

BUG= 682367 
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2687613002 .
Cr-Commit-Position: refs/heads/master@{#448867}

[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/4776765-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/caret-outside-block-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/caret-with-composited-scroll-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/caret-with-transformation-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/delete-into-nested-block-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/inline-outline-repaint-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection-after-delete-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/textarea-caret-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/4776765-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-contenteditable-content-after-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-outside-block-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-subpixel-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-with-transformation-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/delete-into-nested-block-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-outline-repaint-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-caret-before-text-node-update-expected.png
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-caret-before-text-node-update-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection-after-delete-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/textarea-caret-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/4776765-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/caret-outside-block-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/caret-subpixel-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/caret-with-composited-scroll-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/caret-with-transformation-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/delete-into-nested-block-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-outline-repaint-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-before-text-node-update-expected.png
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-before-text-node-update-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection-after-delete-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/4776765-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-contenteditable-content-after-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-outside-block-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-with-transformation-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/delete-into-nested-block-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/inline-outline-repaint-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection-after-delete-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/4776765-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/caret-outside-block-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/caret-with-composited-scroll-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/caret-with-transformation-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/delete-into-nested-block-expected.txt
[modify] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/inline-outline-repaint-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[add] https://crrev.com/c565dd78281dd61ef82e6637ce0dd28c58b18a89/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection-after-delete-expected.txt

Comment 9 by wangxianzhu@chromium.org, Feb 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment