New issue
Advanced search Search tips

Issue 682354 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task


Previous locations:
gerrit:5288


Sign in to add a comment

Trigger CQ through the plugin and not through a label

Project Member Reported by dsinclair@chromium.org, Jan 18 2017

Issue description

For CLs where we've uploaded and run the try jobs and then uploaded a Rebase w/ no changes the page is smart enough to pull the results forward as there are no code changes that will effect the results.

The index page does not correctly show a green check mark for those instances where the results have been pulled forward.

i.e. https://pdfium-review.googlesource.com/c/2215/ has results pulled forward over ps#3. Looking at my index page there is currently no CQ check even though it is showing full try run results.
 
Summary: Trigger CQ through the plugin and not through a label (was: Gerrit index does not show correct CQ status for CLs where results pulled forward)
This is a fundamental issue with using labels to trigger tryjobs and is working as intended. We bring the results of tryjobs forward so that you can see what the last success was. The desired behavior would be to implement triggering CQ via a plugin where you don't need to set a label in order to kick off a tryjob.
Project: chromium
Moved issue gerrit:5288 to now be issue chromium:682354.
Cc: aga...@chromium.org tandrii@chromium.org
Components: Infra>CQ Infra>Codereview>Gerrit
Labels: Milestone-Afterglow Proj-Gerrit-Migration
Status: Available (was: New)
btw, there is also CQ verified label that CQ can set upon completion of its right: see option `cq_verified_label` in [1]. You'd need to configure this label in your Gerrit project first and make sure it's set as sticky except for rework kind of patches. I think, but not 100% sure, that this way you'd achieve what you want short-term.

[1] https://chrome-internal.googlesource.com/infra/infra_internal/+/master/commit_queue/cq_client/cq.proto#92
Labels: Pri-2
Components: -Infra>CQ Infra>Platform>CQdaemon

Comment 7 by efoo@chromium.org, Aug 31 2017

Components: Infra>Platform>CQ

Comment 8 by efoo@chromium.org, Aug 31 2017

Components: -Infra>Platform>CQdaemon
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Labels: -Proj-Gerrit-Migration Type-Task
Setting Type-Task as this is work that we'd really like to do, but is basically a whole project with work on both the Gerrit and CQ sides, not just a bugfix. This work is a 2018 OKR but hasn't been assigned a quarter.
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -aga...@chromium.org qyears...@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Will be revisited in Q1'2019.

Sign in to add a comment