New issue
Advanced search Search tips

Issue 682340 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jan 2017
Cc:
jeffcarp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[W3C import] Add NOEXPORT to commit message when manually importing.

Project Member Reported by qyears...@chromium.org, Jan 18 2017 
Currently NOEXPORT=true is added to commit messages when auto-importing, but people may also manually import using the import script (e.g. when importing a new directory) and then change the CL title, in which case the CL may be mis-identified as an exportable commit.

It may be helpful to add NOEXPORT=true to the commit message when manually importing so that by default it's added when people upload a CL after doing a manual import.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ea227fdc0908323f9c1b43918368fe04cdc1bf3

commit 7ea227fdc0908323f9c1b43918368fe04cdc1bf3
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Jan 19 19:11:16 2017

Refactoring: Split up "commit_changes_if_needed" method.

Purpose: The purpose of this change is to improve readability
and also make it easier to test the commit message, which I
think we want to change for  bug 682340 .

BUG= 682340 

Review-Url: https://codereview.chromium.org/2639213003
Cr-Commit-Position: refs/heads/master@{#444810}

[modify] https://crrev.com/7ea227fdc0908323f9c1b43918368fe04cdc1bf3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/7ea227fdc0908323f9c1b43918368fe04cdc1bf3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Comment 2 by qyears...@chromium.org, Jan 20 2017

Components: Blink>Infra>Predictability
Status: Started (was: Assigned)
https://codereview.chromium.org/2639283005

Comment 4 by qyears...@chromium.org, Jan 24 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1df863548d7fa885094f570e201a032c36a01c7

commit c1df863548d7fa885094f570e201a032c36a01c7
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jan 25 02:08:29 2017

Remove extra newlines added to auto-importer CL descriptions.

This is a little follow-up to http://crrev.com/2639283005, meant to
prevent the importer from adding lots of newlines in the CL description
(e.g. http://crrev.com/2649323004).

BUG= 682340 

Review-Url: https://codereview.chromium.org/2655783005
Cr-Commit-Position: refs/heads/master@{#445911}

[modify] https://crrev.com/c1df863548d7fa885094f570e201a032c36a01c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/c1df863548d7fa885094f570e201a032c36a01c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Comment 6 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 7 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment