RenderWidgetHostViewChildFrame should use CompositorFrameSinkSupport |
||||||
Issue descriptionCurrently RenderWidgetHostViewChildFrame holds on to a SurfaceFactory directly. Ultimately, we need to pull out the CompositorFrameSink bits out of it as they will live in the Gpu process. For now I think RenderWidgetHostViewChildFrame should hold a CompositorFrameSinkSupport and use that instead of using SurfaceFactory directly as a first step. The second step is probably that OOPIFs and WebView should request CompositorFrameSinks and should submit CompositorFrames to CompositorFrameSinks directly, possibly bypassing REnderWidgetHostViewChildFrame entirely. Instead, RenderWidgetHostViewChildFrame observes submitted frames (possibly via SurfaceObserver for now) and forwards the new surface ID up to the parent.
,
Jan 26 2017
,
Feb 6 2017
+sadrul@ for reference: <webview> and other guestviews are used throughout Chrome UI including login, cast, and PDF Viewer, and so this might end up being a 30 minute browser blocker. I can be convinced we don't need to worry about cast or PDF, but I believe we still need to worry about OOBE/Login <webviews>? If that is the case then I believe this is P2. Saman is currently working on this. This is blocked on mojoification of copy requests which is being actively worked on.
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd3c6dd2947f52dab4b3a7c3a8448231c5a60b97 commit bd3c6dd2947f52dab4b3a7c3a8448231c5a60b97 Author: samans <samans@chromium.org> Date: Wed Mar 01 02:54:03 2017 RenderWidgetHostViewChildFrame should use CompositorFrameSinkSupport This CL replaces SurfaceFactory with CompositorFrameSinkSupport, which takes us one step closer to enabling SurfaceReferences in Chrome and moving the DisplayCompositor out of the browser process. BUG= 682336 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2688613002 Cr-Commit-Position: refs/heads/master@{#453801} [modify] https://crrev.com/bd3c6dd2947f52dab4b3a7c3a8448231c5a60b97/content/browser/frame_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/bd3c6dd2947f52dab4b3a7c3a8448231c5a60b97/content/browser/frame_host/render_widget_host_view_child_frame.h
,
Mar 2 2017
,
Jun 13 2017
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fsam...@chromium.org
, Jan 22 2017