New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682334 link

Starred by 1 user
Status: Fixed
Owner:
█ yzshen@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
█ roc...@chromium.org
█ yzshen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo C+ bindings: Simplify associated interface API

Project Member Reported by yzshen@chromium.org, Jan 18 2017 
There is no need to create a pair of AssociatedInterfacePtrInfo/Request from an AssociatedGroup. We can create a "pending" pair that hold reference to each other. As soon as one of them is serialized and passed to a message pipe endpoint, we update the other with necessary information (interface ID, associated group controller).

AssociatedInterfacePtr/Binding will need to handle binding to a pending AssociatedInterfacePtrInfo/Request properly.

With this change we can remove AssociatedGroup entirely, and also control message EndpointClosedBeforeSent.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6

commit 8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6
Author: yzshen <yzshen@chromium.org>
Date: Mon Jan 23 20:40:37 2017

Mojo bindings: merge the control messages of sending disconnect reason and notifying endpoint closed.

This is part of the work to remove AssociatedGroup and simplify the associated interface API.

BUG= 682334 

Review-Url: https://codereview.chromium.org/2649573004
Cr-Commit-Position: refs/heads/master@{#445473}

[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/ipc/ipc_mojo_bootstrap.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/BUILD.gn
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/associated_binding.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/associated_group_controller.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/associated_interface_ptr.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/associated_interface_request.h
[add] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/disconnect_reason.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/interface_endpoint_client.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/interface_ptr.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/interface_request.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/binding_state.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/control_message_handler.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/control_message_handler.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/control_message_proxy.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/control_message_proxy.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/interface_ptr_state.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/multiplex_router.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/multiplex_router.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/pipe_control_message_handler.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/pipe_control_message_handler_delegate.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/pipe_control_message_proxy.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/interfaces/bindings/interface_control_messages.mojom
[modify] https://crrev.com/8be41d3abfb2a8f5d7b58b3e70ebbc86fc7aa5d6/mojo/public/interfaces/bindings/pipe_control_messages.mojom

Comment 2 by yzshen@chromium.org, Feb 2 2017 

Mojo C++ bindings: introduce an optional array to store transferred interface IDs in messages.

This is part of the work to simplify the associated interface API.

BUG= 682334 
TBR=rockot@chromium.org
(Ken has LGed, but maybe this could bypass the PRESUBMIT bug?)

Review-Url: https://codereview.chromium.org/2660733002
Cr-Commit-Position: refs/heads/master@{#447331}
Committed: https://chromium.googlesource.com/chromium/src/+/ea784ea651063e3add479242fc5c43c4bef2fe4b

Comment 3 by yzshen@chromium.org, Feb 2 2017

Cc: roc...@chromium.org yzshen@chromium.org
 Issue 681071  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a597131aec73063576b26e6caabde99b09ec890

commit 0a597131aec73063576b26e6caabde99b09ec890
Author: yzshen <yzshen@chromium.org>
Date: Thu Feb 02 05:13:47 2017

Mojo C++ bindings: fix MultiplexRouter and ChannelAssociatedGroupController.

- There were a few places where a local ScopedInterfaceEndpointHandle was
  created for an endpoint but the handle_created field wasn't updated.

- Previously there was a race: when processing a message, the router's lock was
  released to create local ScopedInterfaceEndpointHandles for the transferred
  interface IDs. (Let's say it was going to register endpoint x.) At the same
  time, another thread could acquire the lock to process subsequent messages. It
  might find that a message targeted endpoint x but x was not registered. The
  previous code inserted endpoint x in this case. MultiplexRouter also marked
  the newly-inserted endpoint as CLOSED, which avoided blocking processing
  subsequent messages, but was wrong in this case.

  With this CL, endpoints are registered as soon as incoming messages arrives.
  It fixes the race and also simplifies IncomingMessageWrapper.

BUG= 682334 

Review-Url: https://codereview.chromium.org/2674483002
Cr-Commit-Position: refs/heads/master@{#447701}

[modify] https://crrev.com/0a597131aec73063576b26e6caabde99b09ec890/ipc/ipc_mojo_bootstrap.cc
[modify] https://crrev.com/0a597131aec73063576b26e6caabde99b09ec890/mojo/public/cpp/bindings/lib/multiplex_router.cc
[modify] https://crrev.com/0a597131aec73063576b26e6caabde99b09ec890/mojo/public/cpp/bindings/lib/multiplex_router.h
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a628d0b45d5ce49a035020d8d67e9cc9a562ecac

commit a628d0b45d5ce49a035020d8d67e9cc9a562ecac
Author: rockot <rockot@chromium.org>
Date: Thu Feb 09 08:40:15 2017

Mojo C++ Bindings: Eliminiate unbound ThreadSafeInterfacePtr

Changes ThreadSafeInterfacePtr such that it is no longer possible
to create one which is unbound. Instead, it is now possible to
create one which will imminently be bound on a specific TaskRunner
but which is usable immediately.

Also introduces ThreadSafeForwarder as a reduced encapsulation of
thread-safe serialization and forwarding logic. This is used
to implement ThreadSafeInterfacePtrBase, as well as to support
immediate associated request forwarding on IPC::ChannelProxy in
a thread-safe manner, where the underlying AssociatedInterfacePtr
must remain owned by the channel's IPC::MessagePipeReader.

Finally, in order to facilitate IPC::Channel exposing ipc.mojom
types through its public interface, the //ipc:mojom target has
been folded into //ipc's component exports. Any prior dependents
on //ipc:mojom have been updated accordingly.

BUG= 682334 
R=yzshen@chromium.org
TEST=ipc_tests, mojo_public_bindings_unittests

Review-Url: https://codereview.chromium.org/2668153003
Cr-Commit-Position: refs/heads/master@{#449239}

[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/chrome/browser/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/chrome/test/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/chrome/utility/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/chromecast/app/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/components/nacl/common/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/app/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/browser/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/child/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/common/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/renderer/BUILD.gn
[delete] https://crrev.com/b68fa9e4f675ec4f158c40297a5638bbb7089f29/content/renderer/mojo/thread_safe_associated_interface_ptr_provider.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/renderer/render_thread_impl.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/content/test/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_channel.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_channel_mojo.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_channel_proxy.cc
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_channel_proxy.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_message_pipe_reader.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_mojo_bootstrap.cc
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_mojo_bootstrap.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/ipc/ipc_mojo_bootstrap_unittest.cc
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/mojo/public/cpp/bindings/associated_interface_ptr.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/mojo/public/cpp/bindings/interface_ptr.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/mojo/public/cpp/bindings/thread_safe_interface_ptr.h
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/remoting/host/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/remoting/host/security_key/BUILD.gn
[modify] https://crrev.com/a628d0b45d5ce49a035020d8d67e9cc9a562ecac/remoting/host/win/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2859a2ac06ab5d9df6706cc45525dc4a2085051c

commit 2859a2ac06ab5d9df6706cc45525dc4a2085051c
Author: yzshen <yzshen@chromium.org>
Date: Tue Feb 14 22:24:25 2017

Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and attach to a message pipe later.

AssociatedGroup will become a class used by the binding internal code. Users will no longer need to pass an AssociatedGroup argument when creating associated interfaces.

BUG= 682334 

Review-Url: https://codereview.chromium.org/2646853003
Cr-Commit-Position: refs/heads/master@{#450494}

[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/ipc/ipc_mojo_bootstrap.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/associated_binding.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/associated_group.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/associated_group_controller.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/associated_interface_ptr.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/associated_interface_request.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/interface_endpoint_client.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/interface_request.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/associated_binding.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/associated_group.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/associated_group_controller.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/binding_state.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/handle_interface_serialization.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/interface_ptr_state.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/may_auto_lock.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/message.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/multiplex_router.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/multiplex_router.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/pipe_control_message_handler_delegate.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/pipe_control_message_proxy.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/cpp/bindings/thread_safe_interface_ptr.h
[modify] https://crrev.com/2859a2ac06ab5d9df6706cc45525dc4a2085051c/mojo/public/interfaces/bindings/pipe_control_messages.mojom
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac

commit f3e75ecdc65ff5ee192fba45952848e5b3b6ddac
Author: yzshen <yzshen@chromium.org>
Date: Wed Feb 15 23:22:41 2017

Mojo C++ bindings: remove some usage of AssociatedGroup from user code.

This class is now supposed to be used in bindings-internal code. Users don't
have to know about it.

This CL changes mojo/, services/ and ui/ folders. Changes to other folders will be in follow-up CLs.

BUG= 682334 

Review-Url: https://codereview.chromium.org/2696233002
Cr-Commit-Position: refs/heads/master@{#450832}

[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/chrome/browser/ui/ash/chrome_new_window_client.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/chrome/browser/ui/ash/media_client.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/mojo/public/cpp/bindings/associated_binding.h
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/mojo/public/cpp/bindings/associated_interface_ptr.h
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/mojo/public/cpp/bindings/lib/multiplex_router.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/mojo/public/cpp/bindings/tests/binding_set_unittest.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/mojo/public/cpp/bindings/tests/sync_method_unittest.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/service_manager/public/cpp/lib/service_context.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/server_window_delegate.h
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/test_server_window_delegate.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/test_server_window_delegate.h
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/window_server.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/window_server.h
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/window_tree_binding.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac/ui/aura/mus/window_tree_client.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1b846f0ba70c7a0b84bd381caec44ed4ddcf88

commit 6c1b846f0ba70c7a0b84bd381caec44ed4ddcf88
Author: yzshen <yzshen@chromium.org>
Date: Thu Feb 16 00:54:47 2017

Mojo C++ bindings: remove some usage of AssociatedGroup from user code.

This class is now supposed to be used in bindings-internal code. Users don't
have to know about it.

This CL changes components/leveldb/. Changes to other folders will be in follow-up CLs.

BUG= 682334 

Review-Url: https://codereview.chromium.org/2692353003
Cr-Commit-Position: refs/heads/master@{#450849}

[modify] https://crrev.com/6c1b846f0ba70c7a0b84bd381caec44ed4ddcf88/components/leveldb/leveldb_service_unittest.cc
[modify] https://crrev.com/6c1b846f0ba70c7a0b84bd381caec44ed4ddcf88/components/leveldb/remote_iterator_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61f516e73a93be7af99a1176e07a04d00646dfe5

commit 61f516e73a93be7af99a1176e07a04d00646dfe5
Author: yzshen <yzshen@chromium.org>
Date: Thu Feb 16 17:21:09 2017

Mojo C++ bindings: remove usage of AssociatedGroup from blink.

This class is now supposed to be used in mojo-bindings-internal code. Users don't have to know about it.

BUG= 682334 

Review-Url: https://codereview.chromium.org/2691363005
Cr-Commit-Position: refs/heads/master@{#451001}

[modify] https://crrev.com/61f516e73a93be7af99a1176e07a04d00646dfe5/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/61f516e73a93be7af99a1176e07a04d00646dfe5/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20d07510536b4baf185e7e9ccfac66fe5dae9415

commit 20d07510536b4baf185e7e9ccfac66fe5dae9415
Author: yzshen <yzshen@chromium.org>
Date: Thu Feb 16 21:36:44 2017

Mojo C++ bindings: remove usage of AssociatedGroup from content/

This class is now supposed to be used in bindings-internal code. Users don't have to know about it.

BUG= 682334 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2695333002
Cr-Commit-Position: refs/heads/master@{#451104}

[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/leveldb_wrapper_impl_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/loader/downloaded_temp_file_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/loader/downloaded_temp_file_impl.h
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/loader/test_url_loader_client.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/loader/test_url_loader_client.h
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/indexed_db/webidbcursor_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/indexed_db/webidbfactory_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/resource_dispatcher.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/resource_dispatcher.h
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/resource_dispatcher_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/url_loader_client_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/url_loader_client_impl.h
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/url_loader_client_impl_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/web_url_loader_impl.h
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/child/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/common/associated_interface_provider_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/common/associated_interface_provider_impl.h
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/public/common/associated_interface_provider.h
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/20d07510536b4baf185e7e9ccfac66fe5dae9415/content/test/test_blink_web_unit_test_support.cc

Comment 14 by yzshen@chromium.org, Feb 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment