GN Check docs don't mention // nogncheck |
|||
Issue descriptionI recently had to add a // nogncheck but it took me a while to figure this out because there's no mention of it here: https://chromium.googlesource.com/chromium/src/tools/gn/+/HEAD/docs/check.md footnote: The reason I needed it is because android doesn't (and shouldn't) depend on a certain target, but gn check still complains about: #if !defined(OS_ANDROID) #include "desktop_only_include_path.h" #endif
,
Jan 18 2017
,
Jan 18 2017
That markdown doc is obsolete. This is covered by "gn help check" and "gn help nogncheck". I'll delete check.md and fix references to it.
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c0a0762e46562f77c65b65a4dca2c6c296ba4d8 commit 6c0a0762e46562f77c65b65a4dca2c6c296ba4d8 Author: brettw <brettw@chromium.org> Date: Wed Jan 18 21:39:24 2017 Remove obsolete GN check.md documentation. This information is covered in the built-in help under "gn help check" and "gn help nogncheck". R=estade@chromium.org BUG= 682331 Review-Url: https://codereview.chromium.org/2647443003 Cr-Commit-Position: refs/heads/master@{#444492} [modify] https://crrev.com/6c0a0762e46562f77c65b65a4dca2c6c296ba4d8/tools/gn/README.md [delete] https://crrev.com/04142ad87c05fdebba5b231f274e8aaec9abdf91/tools/gn/docs/check.md
,
Jan 18 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpranke@chromium.org
, Jan 18 2017Components: Build
Labels: OS-All
Status: Available (was: Untriaged)