Metrics is dropping lots of logs due to event limit |
||
Issue descriptionWe have an eventlimit of 2400: https://codesearch.chromium.org/chromium/src/components/metrics/metrics_service.cc?q=2400+metrics&sq=package:chromium&l=206 This captures user action events and omnibox events. We then fully drop a record if it exceeds the limit: https://codesearch.chromium.org/chromium/src/components/metrics/metrics_service.cc?q=2400+metrics&sq=package:chromium&l=808 This means we're probably dropping tons of useful records. We should investigate raising the limit.
,
Jan 18 2017
By the way, I don't think this discarding explains the Android user action / histogram discrepancy discussed on bug 659336.
,
Jan 18 2017
What's the motivation for the limit in the first place? I thought it was to limit the upload size. If so, are we sure that it's fine to bump the threshold significantly? Can we figure out why ChromeOS is so action-heavy, and see if there's some abuse of the actions mechanism that we can identify and fix?
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb1aaf95ea8fd6a5815d512a690ac8587ded2e7d commit bb1aaf95ea8fd6a5815d512a690ac8587ded2e7d Author: jwd <jwd@chromium.org> Date: Thu Jan 19 22:22:16 2017 Removing *Scroll user actions because they are extremely spammy. Specifically TouchscreenScroll and TrackpadScroll BUG= 682329 Review-Url: https://codereview.chromium.org/2642903002 Cr-Commit-Position: refs/heads/master@{#444862} [modify] https://crrev.com/bb1aaf95ea8fd6a5815d512a690ac8587ded2e7d/content/browser/renderer_host/render_widget_host_view_event_handler.cc [modify] https://crrev.com/bb1aaf95ea8fd6a5815d512a690ac8587ded2e7d/tools/metrics/actions/actions.xml
,
Jan 20 2017
There's a little bit more discussion from the (older) internal bug: b/34200439 We know chromeOS is spammy because of trackpad (jesse submitted a fix to clean it up a bit). We think the original motivation was bandwidth but I'm not convinced it's the right model for solving that issue. There's logic to capture how much bandwitdh UMA is using (on cellular) and limiting it - so we should reuse that logic instead. For now I want to experiment to see what happens if we remove the limit, see if we get users sending huge records (or not).
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02e248436f3736e6b85ab4c47452ce13611cdd11 commit 02e248436f3736e6b85ab4c47452ce13611cdd11 Author: rkaplow <rkaplow@chromium.org> Date: Fri Jan 20 23:39:41 2017 Add a feature to control if we drop UMA records due to excess events. Enabled by default as this is current behavior. BUG= 682329 Review-Url: https://codereview.chromium.org/2646163004 Cr-Commit-Position: refs/heads/master@{#445210} [modify] https://crrev.com/02e248436f3736e6b85ab4c47452ce13611cdd11/components/metrics/metrics_service.cc [modify] https://crrev.com/02e248436f3736e6b85ab4c47452ce13611cdd11/tools/metrics/histograms/histograms.xml
,
May 22 2018
We changed how the limit works (and the amount of data). See https://bugs.chromium.org/p/chromium/issues/detail?id=683934#c21 for more details |
||
►
Sign in to add a comment |
||
Comment 1 by mpear...@chromium.org
, Jan 18 2017