New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682327 link

Starred by 1 user
Status: Fixed
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Feature



Sign in to add a comment

DevTools: CLI helper to run workflow commands anywhere in chromium repo

Project Member Reported by chenwilliam@chromium.org, Jan 18 2017 
DevTools has a set of workflow commands as defined in Source/devtools/package.json. These can be called by npm (or yarn) anywhere within the devtools subtree. One shortfall is that it can't be used in chromium/src which makes it a nuisance to use the npm commands sometimes. Another shortfall is that users need to pass in "--" as a flags delimiter so npm understands which flags are for itself vs. for the script being invoked (e.g. disambiguate whether --help is for npm or the test command).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67d828ef9b351a52fde60df3bf0cc1326bf2fd69

commit 67d828ef9b351a52fde60df3bf0cc1326bf2fd69
Author: chenwilliam <chenwilliam@chromium.org>
Date: Thu Jan 19 00:48:23 2017

DevTools: dtrun CLI helper

This introduces a small CLI wrapper (dtrun) around devtools npm commands.
For example, doing "dtrun lint" forwards the command to
"npm run lint" as defined in Source/devtools/package.json

One-time setup:
npm run setup-dtrun

Benefits:
1) Can run npm commands anywhere in the chromium repo (not just in devtools subtree)
2) No longer need to pass in the delimiter "--" before the flags

Note: Works on Linux and Mac, but no on Windows

BUG= 682327 

Review-Url: https://codereview.chromium.org/2637113003
Cr-Commit-Position: refs/heads/master@{#444573}

[modify] https://crrev.com/67d828ef9b351a52fde60df3bf0cc1326bf2fd69/third_party/WebKit/Source/devtools/package.json
[modify] https://crrev.com/67d828ef9b351a52fde60df3bf0cc1326bf2fd69/third_party/WebKit/Source/devtools/readme.md
[add] https://crrev.com/67d828ef9b351a52fde60df3bf0cc1326bf2fd69/third_party/WebKit/Source/devtools/scripts/devtools_run/devtools_run_cli
[add] https://crrev.com/67d828ef9b351a52fde60df3bf0cc1326bf2fd69/third_party/WebKit/Source/devtools/scripts/devtools_run/package.json

Comment 2 by chenwilliam@chromium.org, Jan 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment