New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682314 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 666132
issue 708322



Sign in to add a comment

[Findit] Show more information on SOM

Project Member Reported by chanli@chromium.org, Jan 18 2017

Issue description

1. If there is no result from Findit, show 'No Result from Findit'
2. If Findit is still running, show 'Findit is still running'
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/04d89f67eb7211397c2d3005c9079f80c3330f8a

commit 04d89f67eb7211397c2d3005c9079f80c3330f8a
Author: Chan <chanli@chromium.org>
Date: Mon Feb 13 23:17:15 2017

[Findit] Return findit analysis result even analysis is still running or it doesn't have findings.

BUG= 682314 

Change-Id: I4e889f77903df51e7a0cdf62ee84f1c64d22d8be
Reviewed-on: https://chromium-review.googlesource.com/438668
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/04d89f67eb7211397c2d3005c9079f80c3330f8a/appengine/findit/test/findit_api_test.py
[modify] https://crrev.com/04d89f67eb7211397c2d3005c9079f80c3330f8a/appengine/findit/findit_api.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 13 2017

Comment 3 by chanli@chromium.org, Feb 23 2017

Cc: chanli@chromium.org
 Issue 665890  has been merged into this issue.

Comment 4 by chanli@chromium.org, Feb 24 2017

For those not supported by Findit, we might show "Not supported by Findit".

Comment 5 by st...@chromium.org, Mar 29 2017

Blocking: 666132
I don't know it's good for information density to show this message. Won't it appear on every alert for some trees, creating lots of visual noise?

Comment 7 by st...@chromium.org, Apr 3 2017

(sorry for the confusion.)

For the "Not supported by Findit", we meant to show it only on chromium tree for unsupported steps like webkit_tests etc. They will be supported later once they run on Swarming.
Based on feedback from some sheriffs, this is to prevent unnecessary manual work by Sheriffs to type the url, trigger the analysis, but get no finding by Findit.

For other trees like Android/ChromeOS/Perf, we don't want to show any message because they are not supported.
So I misunderstood earlier...

So to double check, you mean we should show this kind of messages to failures where master is supported but not the step, right?
re #8: That makes sense to me.
My thought was:
1. Only show Findit message for alerts on Chromium tree.
2. Show "Not supported by Findit" for non-supported builder/step in Chromium tree to void the overhead of manual actions as explained above.
Blocking: 708322
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cff01431ad16e97f71c78b000053ca7d17346f11

commit cff01431ad16e97f71c78b000053ca7d17346f11
Author: Chan <chanli@chromium.org>
Date: Wed Apr 05 00:50:46 2017

[Findit] Return Findit result for unsupported failures.

Will only return such results for unsupported failures on chromium tree. There will be no results at all for other trees.

Bug:682314

Change-Id: I11f8c0a0fe7d9f4428e01d22427b5c57799f617f
Reviewed-on: https://chromium-review.googlesource.com/466330
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/cff01431ad16e97f71c78b000053ca7d17346f11/appengine/findit/test/findit_api_test.py
[modify] https://crrev.com/cff01431ad16e97f71c78b000053ca7d17346f11/appengine/findit/findit_api.py

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640

commit 7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640
Author: Chan <chanli@chromium.org>
Date: Wed Apr 05 16:46:51 2017

[SoM-Findit] Only send request to Findit for failures on chromium tree.

Bug:  682314 
Change-Id: I0de5a386d9d48a74d89629c01f66ea658756a493
Reviewed-on: https://chromium-review.googlesource.com/468446
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640/go/src/infra/monitoring/analyzer/analyzer_test.go
[modify] https://crrev.com/7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640/go/src/infra/monitoring/analyzer/analyzer.go

Status: Fixed (was: Assigned)

Sign in to add a comment