[Findit] Show more information on SOM |
||||
Issue description1. If there is no result from Findit, show 'No Result from Findit' 2. If Findit is still running, show 'Findit is still running'
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/301eb8d94e9cefb52956d4d0b5f59f70f8c271d1 commit 301eb8d94e9cefb52956d4d0b5f59f70f8c271d1 Author: Chan <chanli@chromium.org> Date: Mon Feb 13 23:18:12 2017 [SoM-Findit] Add Findit info on SoM page. 1. if Findit is still running (heuristic or try job), shows "Findit is Analyzing..." 2. if Findit doesn't find anything, shows "Findit found no culprit." BUG= 682314 Change-Id: I25dde336cc4292f0a375635229511acb1e4a9a0b Reviewed-on: https://chromium-review.googlesource.com/442065 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/301eb8d94e9cefb52956d4d0b5f59f70f8c271d1/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.js [modify] https://crrev.com/301eb8d94e9cefb52956d4d0b5f59f70f8c271d1/go/src/infra/monitoring/analyzer/analyzer_test.go [modify] https://crrev.com/301eb8d94e9cefb52956d4d0b5f59f70f8c271d1/go/src/infra/monitoring/messages/alerts.go [modify] https://crrev.com/301eb8d94e9cefb52956d4d0b5f59f70f8c271d1/go/src/infra/monitoring/messages/findit.go [modify] https://crrev.com/301eb8d94e9cefb52956d4d0b5f59f70f8c271d1/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html [modify] https://crrev.com/301eb8d94e9cefb52956d4d0b5f59f70f8c271d1/go/src/infra/monitoring/analyzer/analyzer.go
,
Feb 23 2017
,
Feb 24 2017
For those not supported by Findit, we might show "Not supported by Findit".
,
Mar 29 2017
,
Apr 3 2017
I don't know it's good for information density to show this message. Won't it appear on every alert for some trees, creating lots of visual noise?
,
Apr 3 2017
(sorry for the confusion.) For the "Not supported by Findit", we meant to show it only on chromium tree for unsupported steps like webkit_tests etc. They will be supported later once they run on Swarming. Based on feedback from some sheriffs, this is to prevent unnecessary manual work by Sheriffs to type the url, trigger the analysis, but get no finding by Findit. For other trees like Android/ChromeOS/Perf, we don't want to show any message because they are not supported.
,
Apr 3 2017
So I misunderstood earlier... So to double check, you mean we should show this kind of messages to failures where master is supported but not the step, right?
,
Apr 3 2017
re #8: That makes sense to me.
,
Apr 4 2017
My thought was: 1. Only show Findit message for alerts on Chromium tree. 2. Show "Not supported by Findit" for non-supported builder/step in Chromium tree to void the overhead of manual actions as explained above.
,
Apr 4 2017
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/cff01431ad16e97f71c78b000053ca7d17346f11 commit cff01431ad16e97f71c78b000053ca7d17346f11 Author: Chan <chanli@chromium.org> Date: Wed Apr 05 00:50:46 2017 [Findit] Return Findit result for unsupported failures. Will only return such results for unsupported failures on chromium tree. There will be no results at all for other trees. Bug:682314 Change-Id: I11f8c0a0fe7d9f4428e01d22427b5c57799f617f Reviewed-on: https://chromium-review.googlesource.com/466330 Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/cff01431ad16e97f71c78b000053ca7d17346f11/appengine/findit/test/findit_api_test.py [modify] https://crrev.com/cff01431ad16e97f71c78b000053ca7d17346f11/appengine/findit/findit_api.py
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640 commit 7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640 Author: Chan <chanli@chromium.org> Date: Wed Apr 05 16:46:51 2017 [SoM-Findit] Only send request to Findit for failures on chromium tree. Bug: 682314 Change-Id: I0de5a386d9d48a74d89629c01f66ea658756a493 Reviewed-on: https://chromium-review.googlesource.com/468446 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640/go/src/infra/monitoring/analyzer/analyzer_test.go [modify] https://crrev.com/7a9b8c96d9998ceb7d8a5aaf26b0ad09ef706640/go/src/infra/monitoring/analyzer/analyzer.go
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/221dba29def50601dfe20dc90dceeed9b7a76412 commit 221dba29def50601dfe20dc90dceeed9b7a76412 Author: Chan <chanli@chromium.org> Date: Wed Apr 05 17:46:11 2017 [SoM-Findit] Explicitely show 'Not supported by Findit' for not supported failures. Bug:682314 Change-Id: I1971c7aecd2013bad553c0304826f0e3b576c1d6 Reviewed-on: https://chromium-review.googlesource.com/466547 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> [modify] https://crrev.com/221dba29def50601dfe20dc90dceeed9b7a76412/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.js [modify] https://crrev.com/221dba29def50601dfe20dc90dceeed9b7a76412/go/src/infra/monitoring/analyzer/analyzer_test.go [modify] https://crrev.com/221dba29def50601dfe20dc90dceeed9b7a76412/go/src/infra/monitoring/messages/alerts.go [modify] https://crrev.com/221dba29def50601dfe20dc90dceeed9b7a76412/go/src/infra/monitoring/messages/findit.go [modify] https://crrev.com/221dba29def50601dfe20dc90dceeed9b7a76412/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html [modify] https://crrev.com/221dba29def50601dfe20dc90dceeed9b7a76412/go/src/infra/monitoring/analyzer/analyzer.go
,
Apr 11 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Feb 13 2017