mini_installer does not work with spaces in ex name |
||
Issue descriptionChrome Version: m57 OS: Windows What steps will reproduce the problem? 1/ Rename mini_installer so that the file name has a space in it, such as "mini_installer (1).exe" 2/ Run mini installer: "mini_installer (1).exe" --system-level --verbose-logging What is the expected result? Get a system level install of chrome with a logging file in %TEMP% with details of install. What happens instead? Get a user level install of chrome with an empty logging file in %TEMP%.
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdf8ed5452e3b44255bed8f6fe609204b5b5ddf9 commit bdf8ed5452e3b44255bed8f6fe609204b5b5ddf9 Author: grt <grt@chromium.org> Date: Fri Jan 27 17:04:05 2017 Handle spaces in the name of the mini_installer. BUG= 682277 R=bcwhite@chromium.org Review-Url: https://codereview.chromium.org/2655473002 Cr-Commit-Position: refs/heads/master@{#446694} [modify] https://crrev.com/bdf8ed5452e3b44255bed8f6fe609204b5b5ddf9/chrome/installer/mini_installer/BUILD.gn [modify] https://crrev.com/bdf8ed5452e3b44255bed8f6fe609204b5b5ddf9/chrome/installer/mini_installer/mini_installer.cc [modify] https://crrev.com/bdf8ed5452e3b44255bed8f6fe609204b5b5ddf9/chrome/installer/mini_installer/mini_installer.h [add] https://crrev.com/bdf8ed5452e3b44255bed8f6fe609204b5b5ddf9/chrome/installer/mini_installer/mini_installer_unittest.cc
,
Feb 2 2017
Should be fixed in 58.0.2995.0. |
||
►
Sign in to add a comment |
||
Comment 1 by grt@chromium.org
, Jan 23 2017