[Missing Tests]: [Mac] Omnibox text and icon spacing |
|||||||||
Issue descriptionspqchan@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions. Commit: https://codereview.chromium.org/2520003007 Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=666977 Thanks,
,
Jan 25 2017
@sdy, since you said you're taking some UI bugs, can you work on this? Feel free to reassign to me if you don't want to. Thanks!
,
Feb 23 2017
It's not feasible to test this automatically.
,
Feb 23 2017
,
Feb 23 2017
[repoening for the moment, so that it doesn't get lost] What are you referring to, exactly? The alignment of the text? That seems like something that could be tested?
,
Feb 27 2017
Sorry — I closed this as part of a bug sweep with ellyjones@ because it looked difficult to test usefully. I'll take another look.
,
Mar 4 2017
,
Mar 15 2017
This should be feasible to test? You should be able to compute the x-origins of the image and text in the omnibox and their counterparts in the omnibox dropdown, and compare them by converting them to screen coordinates? I would like this test to get added in this milestone.
,
Mar 15 2017
,
Jun 23 2017
Clearly not P-1 given the lack of action.
,
Mar 19 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by shrike@chromium.org
, Jan 25 2017