Issue 682256 link

Starred by 4 users

Issue metadata

Status:	Fixed
Owner:	loonyb...@chromium.org
Closed:	May 2017
Components:	Blink>FeaturePolicy
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac
Pri:	2
Type:	Bug

Blocked on:
issue 682258
issue 704904

Support iframe "allow" attribute to control Feature Policy

Project Member Reported by iclell...@chromium.org, Jan 18 2017

Issue description

From the latest rounds of spec discussion, and to match the explainer doc, Feature Policy should support an "allow='list of features'" attribute on iframes.

Practically, a list of features should translate into a set of declared whitelists, which should replace the declared whitelists in the parent document, for the named features, for the purpose of calculating the inherited policy for the nested frame.

Comment 1 by iclell...@chromium.org, Jan 18 2017

Blockedon: 682258

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37f156fe308e0f249d087f48b046a93938be0cd9

commit 37f156fe308e0f249d087f48b046a93938be0cd9
Author: lunalu <lunalu@chromium.org>
Date: Sat Feb 11 07:19:11 2017

Initial Implementation of Iframe Attribute for Feature Policy (Part 1)

Enable iframe feature policy by attributes:
    allow="feature1 feature2", allowfullscreen, and allowpaymentrequest.

See design doc: https://docs.google.com/a/google.com/document/d/1ZTuCRKNnWKQUn8gzufuRsCnjVXtPYxK30wWLaZ7Jslk/edit?usp=sharing

Part 1: Introduce iframe allowAttr in HTMLIFrameElement::parseAttribute
and store featureNames in HTMLIFrameElement

Part 2: Pass featureNames from HTMLIFrameElement to frame owner and
remote frame owner.

Part 3: Set iframe feature policy in FrameLoader::didBeginDocument

Part 4.a: Replace implementation of allowpaymentrequest by feature policy

Part 4.b: Replace implementation of allowfullscreen by feature policy

Part 5: WebVR

BUG= 682256 

Review-Url: https://codereview.chromium.org/2680083002
Cr-Commit-Position: refs/heads/master@{#449847}

[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/dom/SandboxFlags.cpp
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElement.h
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElement.idl
[add] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.cpp
[add] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.h
[add] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.cpp
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/core/html/HTMLIFrameElementTest.cpp
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/37f156fe308e0f249d087f48b046a93938be0cd9/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h

Comment 3 by lunalu@chromium.org, Feb 14 2017

Design doc
https://docs.google.com/a/chromium.org/document/d/1sskoBi7Ba7hLuuiJQ6VMQ1KYIGBP8Lr87hLbkF76c2I/edit?usp=sharing

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fec23406245485fa37f09c3611d014b22cdd234c

commit fec23406245485fa37f09c3611d014b22cdd234c
Author: lunalu <lunalu@chromium.org>
Date: Wed Feb 22 16:49:34 2017

Initial Implementation of Iframe Attribute for Feature Policy (Part 2)

Enable iframe feature policy by attributes:
  allow="feature1 feature2", allowfullscreen, and allowpaymentrequest.

See design doc: https://docs.google.com/a/chromium.org/document/d/1sskoBi7Ba7hLuuiJQ6VMQ1KYIGBP8Lr87hLbkF76c2I/edit?usp=sharing

Part 1: Introduce iframe allowAttr in HTMLIFrameElement::parseAttribute
and store featureNames in HTMLIFrameElement
(CL: https://codereview.chromium.org/2680083002/)

Part 2: Propagate featureNames from HTMLIFrameElement to frame owner and
remote frame owner.

Part 3: Set iframe feature policy in FrameLoader::didBeginDocument

Part 4.a: Replace implementation of allowpaymentrequest by feature policy

Part 4.b: Replace implementation of allowfullscreen by feature policy

Part 5: WebVR

BUG= 682256 

Review-Url: https://codereview.chromium.org/2697713003
Cr-Commit-Position: refs/heads/master@{#452087}

[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/content/browser/DEPS
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/content/common/frame_messages.h
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/content/common/frame_owner_properties.cc
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/content/common/frame_owner_properties.h
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/content/renderer/frame_owner_properties.cc
[add] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/content/test/data/allowed_frames.html
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/core/frame/FrameOwner.h
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/core/html/HTMLIFrameElement.h
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/web/RemoteFrameOwner.h
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/web/WebFrame.cpp
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/fec23406245485fa37f09c3611d014b22cdd234c/third_party/WebKit/public/web/WebFrameOwnerProperties.h

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0baeb8b4f2a11f29104b2c989a584242acd139f3

commit 0baeb8b4f2a11f29104b2c989a584242acd139f3
Author: lunalu <lunalu@chromium.org>
Date: Mon Mar 13 21:24:31 2017

Initial Implementation of Iframe Attribute for Feature Policy
(Part 3.b)

WebParsedFeaturePolicyHeader is renamed because this DS will
be shared between both header policy and container policy
and in the future meta tag policy and container header policy.

BUG= 682256 

Review-Url: https://codereview.chromium.org/2738953002
Cr-Commit-Position: refs/heads/master@{#456489}

[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/content/child/blink_platform_impl.cc
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/content/child/blink_platform_impl.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/content/child/feature_policy/feature_policy_platform.cc
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/content/child/feature_policy/feature_policy_platform.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/content/renderer/render_frame_impl.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/core/dom/SecurityContext.cpp
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/core/dom/SecurityContext.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/web/LocalFrameClientImpl.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/public/platform/WebFeaturePolicy.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/0baeb8b4f2a11f29104b2c989a584242acd139f3/third_party/WebKit/public/web/WebRemoteFrame.h

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb4be2269ba2a16ebec49edf4f2817517f63ad5

commit 5fb4be2269ba2a16ebec49edf4f2817517f63ad5
Author: lunalu <lunalu@chromium.org>
Date: Fri Mar 17 20:57:17 2017

Initial Implementation of Iframe Attribute for Feature Policy (Part 3.a)

Replace string by enum in WebParsedFeaturePolicyDeclaration#feature

Use enum in WebParsedFeaturePolicyDeclaration for 2 reasons:
1. Memory efficient
2. Make code shareable for header policy and container policy

Removed FeaturePolicy::Feature as we no longer need to store feature
name (string) once the policy is parsed. Updated FeatureList (now a
a mapping between feature to default policy) and tests as a result.
Only downside is we no longer have explicit definition of each feature
(e.g. kDocumentCookie{"cookie", EnableForAll}), we define the default
policy directly in DefaultFeatureList

feature is converted from string in parseFeaturePolicy now so we can
drop the unrecognized features earlier instead of doing it in
setHeaderPolicy

BUG= 682256 

Review-Url: https://codereview.chromium.org/2727803004
Cr-Commit-Position: refs/heads/master@{#457884}

[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/content/child/feature_policy/feature_policy_platform.cc
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/content/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/content/common/feature_policy/feature_policy.h
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/content/common/feature_policy/feature_policy_unittest.cc
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/content/common/frame_messages.h
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp
[modify] https://crrev.com/5fb4be2269ba2a16ebec49edf4f2817517f63ad5/third_party/WebKit/public/platform/WebFeaturePolicy.h

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a466f064ef609c227ef1fa840ec812591af053b

commit 1a466f064ef609c227ef1fa840ec812591af053b
Author: lunalu <lunalu@chromium.org>
Date: Tue Mar 21 15:49:15 2017

Initial Implementation of Iframe Attribute for Feature Policy (Part 3)

Enable iframe feature policy by attributes:
  allow="feature1 feature2", allowfullscreen, and allowpaymentrequest.

See design doc: https://docs.google.com/a/chromium.org/document/d/1sskoBi7Ba7hLuuiJQ6VMQ1KYIGBP8Lr87hLbkF76c2I/edit?usp=sharing

Part 1: Introduce iframe allowAttr in HTMLIFrameElement::parseAttribute
and store featureNames in HTMLIFrameElement
(CL: https://codereview.chromium.org/2680083002/)

Part 2: Propagate featureNames from HTMLIFrameElement to frame owner and
remote frame owner.
(CL: https://codereview.chromium.org/2697713003)

Part 3: Set iframe feature policy in FrameLoader::didBeginDocument
3.a Replace string by enum in WebParsedFeaturePolicyDeclaration#feature
(CL: https://codereview.chromium.org/2727803004/)
3.b Rename WebParsedFeaturePolicyHeader to WebParsedFeaturePolicy
(CL: https://codereview.chromium.org/2738953002/)

Part 4.a: Replace implementation of allowpaymentrequest by feature policy

Part 4.b: Replace implementation of allowfullscreen by feature policy

Part 5: WebVR

WebParsedFeaturePolicyHeader is renamed because this DS will
be shared between both header policy and container policy
and in the future meta tag policy and container header policy.

BUG= 682256 

Review-Url: https://codereview.chromium.org/2739203002
Cr-Commit-Position: refs/heads/master@{#458425}

[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/core/dom/SecurityContext.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/core/dom/SecurityContext.h
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a466f064ef609c227ef1fa840ec812591af053b

commit 1a466f064ef609c227ef1fa840ec812591af053b
Author: lunalu <lunalu@chromium.org>
Date: Tue Mar 21 15:49:15 2017

Initial Implementation of Iframe Attribute for Feature Policy (Part 3)

Enable iframe feature policy by attributes:
  allow="feature1 feature2", allowfullscreen, and allowpaymentrequest.

See design doc: https://docs.google.com/a/chromium.org/document/d/1sskoBi7Ba7hLuuiJQ6VMQ1KYIGBP8Lr87hLbkF76c2I/edit?usp=sharing

Part 1: Introduce iframe allowAttr in HTMLIFrameElement::parseAttribute
and store featureNames in HTMLIFrameElement
(CL: https://codereview.chromium.org/2680083002/)

Part 2: Propagate featureNames from HTMLIFrameElement to frame owner and
remote frame owner.
(CL: https://codereview.chromium.org/2697713003)

Part 3: Set iframe feature policy in FrameLoader::didBeginDocument
3.a Replace string by enum in WebParsedFeaturePolicyDeclaration#feature
(CL: https://codereview.chromium.org/2727803004/)
3.b Rename WebParsedFeaturePolicyHeader to WebParsedFeaturePolicy
(CL: https://codereview.chromium.org/2738953002/)

Part 4.a: Replace implementation of allowpaymentrequest by feature policy

Part 4.b: Replace implementation of allowfullscreen by feature policy

Part 5: WebVR

WebParsedFeaturePolicyHeader is renamed because this DS will
be shared between both header policy and container policy
and in the future meta tag policy and container header policy.

BUG= 682256 

Review-Url: https://codereview.chromium.org/2739203002
Cr-Commit-Position: refs/heads/master@{#458425}

[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/core/dom/SecurityContext.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/core/dom/SecurityContext.h
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp
[modify] https://crrev.com/1a466f064ef609c227ef1fa840ec812591af053b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Comment 9 by lunalu@chromium.org, Mar 24 2017

Blockedon: 704904

Comment 10 by lunalu@chromium.org, Apr 19 2017

Status: Started (was: Assigned)

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44b442a4f245e3fbfa17478bf0807cc139ab39ef

commit 44b442a4f245e3fbfa17478bf0807cc139ab39ef
Author: lunalu <lunalu@chromium.org>
Date: Thu Apr 27 16:09:40 2017

Initial Implementation of Iframe Attribute for Feature Policy (Part 4)

Replace implementation of allowpaymentrequest and allowfullscreen by feature policy.

Enable iframe feature policy by attributes:
  allow="feature1 feature2", allowfullscreen, and allowpaymentrequest.

See design doc: https://docs.google.com/a/chromium.org/document/d/1sskoBi7Ba7hLuuiJQ6VMQ1KYIGBP8Lr87hLbkF76c2I/edit?usp=sharing

Part 1: Introduce iframe allowAttr in HTMLIFrameElement::parseAttribute
and store featureNames in HTMLIFrameElement
(CL: https://codereview.chromium.org/2680083002/)

Part 2: Propagate featureNames from HTMLIFrameElement to frame owner and
remote frame owner.
(CL: https://codereview.chromium.org/2697713003)

Part 3: Set iframe feature policy in FrameLoader::didBeginDocument
3.a Replace string by enum in WebParsedFeaturePolicyDeclaration#feature
(CL: https://codereview.chromium.org/2727803004/)
3.b Rename WebParsedFeaturePolicyHeader to WebParsedFeaturePolicy
(CL: https://codereview.chromium.org/2738953002/)

Part 4: Replace implementation of allowpaymentrequest and allowfullscreen by feature policy.

BUG= 682256 

Review-Url: https://codereview.chromium.org/2767983003
Cr-Commit-Position: refs/heads/master@{#467699}

[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/resources/feature-policy-vibrate-relocate.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-allowed-by-container-policy-relocate.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-allowed-by-container-policy.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy-expected.txt
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate-expected.txt
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-allowed-by-container-policy-expected.txt
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-allowed-by-container-policy-relocate-expected.txt
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-allowed-by-container-policy-relocate.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-allowed-by-container-policy.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-fullscreen-relocate.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-payment-relocate-disabled.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-payment-relocate-enabled.html
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/fullscreen-allowed-by-container-policy-expected.txt
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate-expected.txt
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/payment-allowed-by-container-policy-expected.txt
[add] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/payment-allowed-by-container-policy-relocate-expected.txt
[modify] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp
[modify] https://crrev.com/44b442a4f245e3fbfa17478bf0807cc139ab39ef/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Comment 12 by lunalu@chromium.org, May 26 2017

Status: Fixed (was: Started)

Comment 13 by rbyers@chromium.org, Jul 18 2017

Owner: loonyb...@chromium.org

►

Issue 682256 link

Issue metadata

Support iframe "allow" attribute to control Feature Policy

Issue description

Comment 1 by iclell...@chromium.org, Jan 18 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Feb 11 2017

Comment 2 Deleted

Comment 3 by lunalu@chromium.org, Feb 14 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Feb 22 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Mar 13 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Mar 17 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Mar 21 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Mar 21 2017

Comment 8 Deleted

Comment 9 by lunalu@chromium.org, Mar 24 2017

Comment 9 Deleted

Comment 10 by lunalu@chromium.org, Apr 19 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Apr 27 2017

Comment 11 Deleted

Comment 12 by lunalu@chromium.org, May 26 2017

Comment 12 Deleted

Comment 13 by rbyers@chromium.org, Jul 18 2017

Comment 13 Deleted

Sign in to add a comment