Reorganize media-devices utility functions in chrome/browser/ui |
||||
Issue descriptionCurrently there are a few utility functions related to media devices in chrome::Browser. In order to simplify chrome::Browser, it would be desirable to move this functions out to its own delegate, which Browser can know about or inherit from, or which can be accessed directly from content.
,
Jan 18 2017
,
Jan 18 2017
,
Jan 18 2017
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aace7622d23d02b6865b30a7b4a8e83d488a0d6 commit 6aace7622d23d02b6865b30a7b4a8e83d488a0d6 Author: guidou <guidou@chromium.org> Date: Tue Jan 24 11:56:04 2017 Remove chrome/browser/ui/media_utils.{cc|h} This file contains a couple of global functions that can be inlined in chrome::Browser. This is the first step towards a better organization of the media-devices code in chrome/browser/ui. BUG=682255 Review-Url: https://codereview.chromium.org/2642763003 Cr-Commit-Position: refs/heads/master@{#445704} [modify] https://crrev.com/6aace7622d23d02b6865b30a7b4a8e83d488a0d6/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/6aace7622d23d02b6865b30a7b4a8e83d488a0d6/chrome/browser/ui/browser.cc [delete] https://crrev.com/24cb6f65cb5715558f4f33ab2076e59326b661d7/chrome/browser/ui/media_utils.cc [delete] https://crrev.com/24cb6f65cb5715558f4f33ab2076e59326b661d7/chrome/browser/ui/media_utils.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by guidou@chromium.org
, Jan 18 2017A first step in the reorganization is to remove media_utils.{cc|h} files, which just introduce global functions that are called directly from chrome::Browser.