LayoutBoxModelObject::backgroundPaintLocation() needs special behavior for the LayoutView. |
||
Issue descriptionWith root layer scrolling we need to fix the behavior of backgroundPaintLocation to have the correct semantics on the root layer. On the root layer, fixed attachment should paint into the GraphicsLayer (so that it doesn't move with scroll) but scroll and local attachment should paint into the ScrollingContentsLayer (so that they do).
,
Feb 10 2017
CL that should fix the bug: https://codereview.chromium.org/2688973002
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97f1bc8106b41307d0b02eae771daa5ef266ef4f commit 97f1bc8106b41307d0b02eae771daa5ef266ef4f Author: yigu <yigu@chromium.org> Date: Wed Feb 15 19:20:59 2017 With root layer scrolling we should paint fixed background attachment into GraphicsLayer and local/scroll attachment into ScrollingContentslayer. BUG= 682246 TEST=All/BoxPaintInvalidatorTest.CompositedLayoutViewResize/1; All/BoxPaintInvalidatorTest.CompositedLayoutViewGradientResize/1 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2655023003 Cr-Commit-Position: refs/heads/master@{#450764} [modify] https://crrev.com/97f1bc8106b41307d0b02eae771daa5ef266ef4f/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp [modify] https://crrev.com/97f1bc8106b41307d0b02eae771daa5ef266ef4f/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/97f1bc8106b41307d0b02eae771daa5ef266ef4f/third_party/WebKit/Source/core/paint/ViewPainter.cpp
,
Feb 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by flackr@chromium.org
, Jan 24 2017