chrome://physical-web WebUI page not showing favicons well |
||||||||
Issue descriptionMany favicons (but not all) show with a broken image (as if the image failed to download).
,
Feb 6 2017
Issue 688371 has been merged into this issue.
,
Feb 14 2017
,
Feb 14 2017
,
Feb 15 2017
,
Feb 22 2017
There are two cases that shows the broken favicon, one is having the stale img url, another is loading a page that does not have an icon. We should also handle the second cases.
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9202c88ac94265dc91315fe2f3b8c1341e9b1e35 commit 9202c88ac94265dc91315fe2f3b8c1341e9b1e35 Author: ranj <ranj@chromium.org> Date: Wed Mar 01 18:40:16 2017 Change scantimestamp to firstseentimestamp. Garbage collector uses this field to check for expiration, before we name it scantimestamp and keep updating it, so the record may never be expired. BUG= 682244 Review-Url: https://codereview.chromium.org/2711683003 Cr-Commit-Position: refs/heads/master@{#453979} [modify] https://crrev.com/9202c88ac94265dc91315fe2f3b8c1341e9b1e35/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java [modify] https://crrev.com/9202c88ac94265dc91315fe2f3b8c1341e9b1e35/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/9202c88ac94265dc91315fe2f3b8c1341e9b1e35/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java [modify] https://crrev.com/9202c88ac94265dc91315fe2f3b8c1341e9b1e35/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java
,
Mar 2 2017
,
Mar 2 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 7 2017
Merge rejected - we are too close to our stable release to take Pri-2 fixes, and after checking with cco3@ this is not critical.
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060 commit 23c9664fcc2ffd6bdcffbca5355ba4cd083f7060 Author: ranj <ranj@chromium.org> Date: Thu Mar 30 03:45:22 2017 Show a default URL icon instead of a broken image for urls with no icon. BUG= 682244 Review-Url: https://codereview.chromium.org/2717363003 Cr-Commit-Position: refs/heads/master@{#460648} [modify] https://crrev.com/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060/chrome/browser/ui/webui/physical_web/physical_web_ui.cc [add] https://crrev.com/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060/components/physical_web/resources/ic_link_grey600_36dp.png [modify] https://crrev.com/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060/components/physical_web/webui/physical_web_ui_constants.cc [modify] https://crrev.com/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060/components/physical_web/webui/physical_web_ui_constants.h [modify] https://crrev.com/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060/components/physical_web/webui/resources/physical_web.js [modify] https://crrev.com/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060/components/resources/physical_web_ui_resources.grdp [modify] https://crrev.com/23c9664fcc2ffd6bdcffbca5355ba4cd083f7060/ios/chrome/browser/ui/webui/physical_web_ui.cc
,
Jun 7 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mmo...@chromium.org
, Jan 18 2017Components: Internals>PhysicalWeb