New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682236 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Delete "Google Profile photo" choice from image choice screen

Project Member Reported by rsorokin@chromium.org, Jan 18 2017

Issue description

On the first authentication a user could choose an image for user profile. One of the choices is downloaded profile image. Which does not exist for Active Directory users. So we want to remove that choice which is just empty now.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978

commit 33f901b2ff76e1d08d80e3ba5d1d079178cb4978
Author: rsorokin <rsorokin@chromium.org>
Date: Wed Feb 01 15:12:42 2017

Delete "Google Profile photo" for the Active Directory

Delete "Google Profile photo" choice from the image choice screen for
the Active Directory users.

BUG= 682236 
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2666893002
Cr-Commit-Position: refs/heads/master@{#447513}

[modify] https://crrev.com/33f901b2ff76e1d08d80e3ba5d1d079178cb4978/chrome/browser/chromeos/login/screens/user_image_model.cc
[modify] https://crrev.com/33f901b2ff76e1d08d80e3ba5d1d079178cb4978/chrome/browser/chromeos/login/screens/user_image_model.h
[modify] https://crrev.com/33f901b2ff76e1d08d80e3ba5d1d079178cb4978/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/33f901b2ff76e1d08d80e3ba5d1d079178cb4978/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed71ca7437db67890fdc2848ff4edea9aa2b0cca

commit ed71ca7437db67890fdc2848ff4edea9aa2b0cca
Author: alemate <alemate@chromium.org>
Date: Fri Mar 03 06:04:16 2017

Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ )

Reason for revert:
First, this has a race: CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception:

login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined
    at HTMLUnknownElement.updateItem (login.js:1208)
    at Array.<anonymous> (login.js:9504)
    at ScreenContext.applyChanges (login.js:538)
    at HTMLDivElement.contextChanged_ (login.js:329)
    at Object.api.contextChanged (login.js:424)
    at <anonymous>:1:23

Second, it breaks supervised user creation screen (and probably other screens that share user-image-grid object).

BUG= 697842 , 682236 

Original issue's description:
> Delete "Google Profile photo" for the Active Directory
>
> Delete "Google Profile photo" choice from the image choice screen for
> the Active Directory users.
>
> BUG= 682236 
> TEST=manual
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2666893002
> Cr-Commit-Position: refs/heads/master@{#447513}
> Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978

TBR=achuith@chromium.org,rsorokin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 682236 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727953004
Cr-Commit-Position: refs/heads/master@{#454525}

[modify] https://crrev.com/ed71ca7437db67890fdc2848ff4edea9aa2b0cca/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/ed71ca7437db67890fdc2848ff4edea9aa2b0cca/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Status: Started (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716621dd4c92357b9b93ae44603fbe53204e5bfd

commit 716621dd4c92357b9b93ae44603fbe53204e5bfd
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Mar 29 01:03:10 2017

Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ )

Reason for revert:
First, this has a race: CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception:

login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined
    at HTMLUnknownElement.updateItem (login.js:1208)
    at Array.<anonymous> (login.js:9504)
    at ScreenContext.applyChanges (login.js:538)
    at HTMLDivElement.contextChanged_ (login.js:329)
    at Object.api.contextChanged (login.js:424)
    at <anonymous>:1:23

Second, it breaks supervised user creation screen (and probably other screens that share user-image-grid object).

BUG= 697842 , 682236 

Original issue's description:
> Delete "Google Profile photo" for the Active Directory
>
> Delete "Google Profile photo" choice from the image choice screen for
> the Active Directory users.
>
> BUG= 682236 
> TEST=manual
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2666893002
> Cr-Commit-Position: refs/heads/master@{#447513}
> Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978

TBR=achuith@chromium.org,rsorokin@chromium.org
BUG= 682236 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727953004
Cr-Commit-Position: refs/heads/master@{#454525}
(cherry picked from commit ed71ca7437db67890fdc2848ff4edea9aa2b0cca)

Review-Url: https://codereview.chromium.org/2785593002 .
Cr-Commit-Position: refs/branch-heads/3029@{#466}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/716621dd4c92357b9b93ae44603fbe53204e5bfd/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/716621dd4c92357b9b93ae44603fbe53204e5bfd/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Labels: -M-58 M-63
The original issue description seems to have gotten lost, and without context it's unclear what this is for.

Description: Show this description
Hey Steven, sorry for that. I added the description. Could you please take a look?
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e9edc2c3105f141a70206e6ac1ec42fc99ee1e1

commit 8e9edc2c3105f141a70206e6ac1ec42fc99ee1e1
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Thu Sep 28 02:32:53 2017

Chromad: Delete "Google Profile photo" choice from the user image screen

Bug:  682236 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2614bf5a86df25a3b9c08fb5fc69c7afdd0ff5b2
Reviewed-on: https://chromium-review.googlesource.com/675368
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504874}
[modify] https://crrev.com/8e9edc2c3105f141a70206e6ac1ec42fc99ee1e1/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/8e9edc2c3105f141a70206e6ac1ec42fc99ee1e1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Status: Fixed (was: Started)
Cc: jingwee@chromium.org
Status: Verified (was: Fixed)
As verified in M63.0.3239.85 10032.68.0 beta kip and M64.0.3282.22 10176.11.0 dev lulu, the "Google Profile photo" choice is no longer seen during first sign-in for Active Directory users.

Sign in to add a comment