Need metric to identify cases where doc.write blocking would have triggered |
||
Issue descriptionWhen doing logs analysis for doc.write blocking, it's desirable to analyze only cases where doc.write blocking could have triggered, to minimize noise from samples where the feature couldn't have triggered. This is especially important given that the blocking only triggers on ~7% of page loads when on 2G. We have a metric to identify cases where we reach FCP after encountering blocking, however this is not sufficient for purposes of comparing stats between control and experiment population. We should add a simple counter that gets recorded as soon as we learn we encountered a doc.write block scenario, in order to identify these cases in a way that's comparable between control and experiment.
,
Jan 18 2017
I see, FCP isn't sufficient because you want to know about pages that could have blocked but don't reach FCP. Is that right?
,
Jan 18 2017
You responded before my response sent. Strange, it used to warn you about that. Ignore comment #2.
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cc8974e18028a1e18779c36318acfe5c069ec2c commit 6cc8974e18028a1e18779c36318acfe5c069ec2c Author: bmcquade <bmcquade@chromium.org> Date: Wed Jan 18 22:39:14 2017 Add counter for number of page loads where doc.write blocking triggers. When doing logs analysis for doc.write blocking, it's desirable to analyze only cases where doc.write blocking could have triggered, to minimize noise from samples where the feature couldn't have triggered. This is especially important given that the blocking only triggers on ~7% of page loads when on 2G. This change adds a counter that allows us to keep track of cases where the feature could have triggered, in a way that's comparable across control and experiment populations. BUG= 682220 Review-Url: https://codereview.chromium.org/2644543002 Cr-Commit-Position: refs/heads/master@{#444519} [modify] https://crrev.com/6cc8974e18028a1e18779c36318acfe5c069ec2c/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc [modify] https://crrev.com/6cc8974e18028a1e18779c36318acfe5c069ec2c/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h [modify] https://crrev.com/6cc8974e18028a1e18779c36318acfe5c069ec2c/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6cc8974e18028a1e18779c36318acfe5c069ec2c/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc [modify] https://crrev.com/6cc8974e18028a1e18779c36318acfe5c069ec2c/tools/metrics/histograms/histograms.xml
,
Jan 27 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bmcquade@chromium.org
, Jan 18 2017