Issue metadata
Sign in to add a comment
|
Regression : ‘Zoom’ bubble does not vanish even when the zoom level is set to default.
Reported by
yfulgaon...@etouch.net,
Jan 18 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 57.0.2985.0 (Official Build) 8c8ff90c8edc7244e4e6d7feda073c76e6949b8e-refs/heads/master@{#444244} 64 bit OS : Mac(10.12.1, 10.11.6, 10.12) What steps will reproduce the problem? 1. Launch chrome, open NTP and hit ‘Cmd +’ (zoom bubble appears in omnibox). 2. Click on ‘zoom’ icon in omnibox and click ‘Reset’. 3. Move mouse pointer anywhere else and observe the ‘zoom’ bubble. Actual : ‘Zoom’ bubble does not vanish even when the zoom level is set to default. Expected : ‘Zoom’ bubble should vanish when zoom level is set to default i.e 100%. This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info. Good build : 57.0.2980.0 Bad build : 57.0.2981.0 Note : This is Mac specific issue and the same is not reproducible on Windows & Linux OS.
,
Jan 18 2017
Adding release block label, please undo if not the case.
,
Jan 20 2017
,
Jan 23 2017
,
Jan 25 2017
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce00d1fcc3a2779d4db9771ca35513a416de9f9d commit ce00d1fcc3a2779d4db9771ca35513a416de9f9d Author: spqchan <spqchan@chromium.org> Date: Thu Jan 26 18:21:16 2017 [Mac] Zoom Bubble Autoclosing Fix With the new MD style the zoom bubble should autoclose, even if the zoom decoration is pressed. Since the bubble isn't actually pointing to the decoration, it should not stay opened, even when the the decoration is pressed. BUG= 682168 Review-Url: https://codereview.chromium.org/2652893007 Cr-Commit-Position: refs/heads/master@{#446378} [modify] https://crrev.com/ce00d1fcc3a2779d4db9771ca35513a416de9f9d/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
,
Jan 31 2017
,
Jan 31 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 31 2017
,
Jan 31 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 1 2017
CL is merged: https://codereview.chromium.org/2674433002/ It's on the branch, but for something it's not showing up here?
,
Feb 2 2017
Rechecked the issue on chrome version 57.0.2987.21 on MAC 10.12.2. Fix or merge is working as intended. ‘Zoom’ bubble vanishes when zoom level is set to default from omnibox. Adding TE-Verified label. Thanks.!
,
Feb 2 2017
,
Mar 4 2017
,
Mar 15 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Jan 18 2017Labels: hasbisect-per-revision
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)