New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682168 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : ‘Zoom’ bubble does not vanish even when the zoom level is set to default.

Reported by yfulgaon...@etouch.net, Jan 18 2017

Issue description

Chrome Version : 57.0.2985.0 (Official Build) 8c8ff90c8edc7244e4e6d7feda073c76e6949b8e-refs/heads/master@{#444244} 64 bit
OS : Mac(10.12.1, 10.11.6, 10.12)

What steps will reproduce the problem?
1. Launch chrome, open NTP and hit ‘Cmd +’ (zoom bubble appears in omnibox).
2. Click on ‘zoom’ icon in omnibox and click ‘Reset’.
3. Move mouse pointer anywhere else and observe the ‘zoom’ bubble.

Actual : ‘Zoom’ bubble does not vanish even when the zoom level is set to default.
Expected : ‘Zoom’ bubble should vanish when zoom level is set to default i.e 100%.

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2980.0
Bad build : 57.0.2981.0

Note : This is Mac specific issue and the same is not reproducible on Windows & Linux OS.
 
Actual_zoom_bubble.mov
4.0 MB Download
Expected_zoom_bubble.mov
3.4 MB Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2980.0 (Revision: 443474).
Bad build: 57.0.2981.0 (Revision: 443771).

You are probably looking for a change made after 443693 (known good), but no later than 443694 (first known bad).

CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/5489020f1edea26f4256621b874afebf7425fdf0..d5a7a73975d123369dab9784b2897467a31b0ab8


From the CL above, assigning the issue to the concern owner

@spqchan: 
------------------
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2628703002

Note : Mac Specific issue.
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Labels: Needs-triage-Mobile
Labels: -Needs-triage-Mobile

Comment 5 by shrike@chromium.org, Jan 25 2017

Labels: Hotlist-PlatformExcellence-2017-Q1
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce00d1fcc3a2779d4db9771ca35513a416de9f9d

commit ce00d1fcc3a2779d4db9771ca35513a416de9f9d
Author: spqchan <spqchan@chromium.org>
Date: Thu Jan 26 18:21:16 2017

[Mac] Zoom Bubble Autoclosing Fix

With the new MD style the zoom bubble should autoclose, even if the
zoom decoration is pressed. Since the bubble isn't actually pointing
to the decoration, it should not stay opened, even when the the
decoration is pressed.

BUG= 682168 

Review-Url: https://codereview.chromium.org/2652893007
Cr-Commit-Position: refs/heads/master@{#446378}

[modify] https://crrev.com/ce00d1fcc3a2779d4db9771ca35513a416de9f9d/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-57
Status: Started (was: Fixed)
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 31 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-57 merge-merged-2987
CL is merged: https://codereview.chromium.org/2674433002/

It's on the branch, but for something it's not showing up here?
Labels: TE-Verified-M57 TE-Verified-57.0.2987.21
Rechecked the issue on chrome version 57.0.2987.21 on MAC 10.12.2. Fix or merge is working as intended. ‘Zoom’ bubble vanishes when zoom level is set to default from omnibox.

Adding TE-Verified label.

Thanks.!
Status: Fixed (was: Started)

Comment 14 by sdy@chromium.org, Mar 4 2017

Labels: Hotlist-PlatformExcellence
Labels: -Hotlist-PlatformExcellence -Hotlist-PlatformExcellence-2017-Q1

Sign in to add a comment