RuntimeStatsMetric on android. |
|||||||
Issue description
Chrome Version: 57.0.2979.0 (Developer Build).
Revision: refs/heads/master@{#442833}
OS:Android 5.1.1; Nexus 5 Build/LMY49S
What steps will reproduce the problem?
(1) Add a new benchmark for mobile infinte scroll page set. So, add the following lines to the file tools/perf/benchmarks/v8.py
@benchmark.Enabled('android')
class V8MobileInfiniteScrollRuntimeStats(_Top25RuntimeStats):
"""Measures Runtime stat metrics while scrolling the top mobile
web pages.
http://www.chromium.org/developers/design-documents/rendering-
benchmarks"""
page_set = page_sets.MobileInfiniteScrollPageSet
@classmethod
def Name(cls):
return 'v8.runtime_stats.mobile_infinite_scroll'
(2) Run the benchmark on Nexus 5 using the following command:
./tools/perf/run_benchmark run v8.runtime_stats.mobile_infinite_scroll --browser=android-chromium --pageset-repeat=1
What is the expected result?
The generated results.html file should contain the runtime statistics measured by v8.
What happens instead?
The collected statistics is 0 for all metrics.
,
Jan 18 2017
,
Jan 18 2017
,
Jan 18 2017
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48e4c328641ba109f490a7375418b5998c4955fb commit 48e4c328641ba109f490a7375418b5998c4955fb Author: lpy <lpy@chromium.org> Date: Fri Jan 27 18:22:34 2017 [gin] Fire observer after added when recording is in progress. When run benchmarks on Android, we don't get runtime statistics result because we register an observer to trigger a flag to enable it, however, tracing is started before observers are added to observer list in this case, thus we force to fire observer when we register an observer through platform API when recording is in progress. BUG= 682167 Review-Url: https://codereview.chromium.org/2650943008 Cr-Commit-Position: refs/heads/master@{#446713} [modify] https://crrev.com/48e4c328641ba109f490a7375418b5998c4955fb/gin/BUILD.gn [modify] https://crrev.com/48e4c328641ba109f490a7375418b5998c4955fb/gin/v8_platform.cc [add] https://crrev.com/48e4c328641ba109f490a7375418b5998c4955fb/gin/v8_platform_unittest.cc
,
Jan 27 2017
,
Jan 27 2017
Hmhh, shouldn't you enable the test on Android before making this as fixed? https://cs.chromium.org/chromium/src/tools/perf/benchmarks/v8.py?rcl=0&l=326
,
Jan 27 2017
That is tracked in a separate bug http://crbug.com/664318 more concerned with the page set not being android friendly.
,
Jan 27 2017
Any ETA on when there will be a more Android friendly page-set? Could we just use Top10Mobile (or is this page-set too old to be useful?).
,
Jan 27 2017
To #9: if you just want a simple page-set on mobile, use system_health's mobile loading page set. If you want complex stories (including multiple navs, scrolling,...), use the system_health's mobile browsing page set. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mythria@chromium.org
, Jan 18 2017