CRAS: associate volume curve with node instead of mixer control |
|||||
Issue descriptionCurrently if sound card doesn't have mixer control for 'Speaker', CRAS won't associate the volume curve specified by [Speaker] label in card config. The proposed fix is to move cras_volume_curve which currently under cras_alsa_mixer/mixer_control to alsa_io/alsa_output_node. This also reduced code complexity that we no longer keep jack_curve for those headphone nodes without mixer control. There will be only one volume_curve pointer of a node that can associate to mixer control or jack name.
,
Jan 24 2017
Should be fixed since 9212.0.0
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/5321f04a3713b423313a20c15a100b7772a3cef0 commit 5321f04a3713b423313a20c15a100b7772a3cef0 Author: Hsin-Yu Chao <hychao@chromium.org> Date: Fri Feb 24 18:55:11 2017 CRAS: alsa_io - Move volume curve to alsa output node Currently if sound card doesn't have mixer control for 'Speaker', CRAS won't associate the volume curve specified by [Speaker] label in card config. Fix this issue by moving volume curve from mixer control to alsa output node. BUG= chromium:682164 , chrome-os-partner:61360 TEST=unittest. On platform without 'Speaker' control, verify volume curve for speaker can be loaded. Change-Id: I75411bf238f25f69ec383877df7278c7b7ff2949 Reviewed-on: https://chromium-review.googlesource.com/429813 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> (cherry picked from commit 428b555480c23b3f24ca1f64896506d357056bb7) Reviewed-on: https://chromium-review.googlesource.com/446732 Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/server/cras_alsa_io.c [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/server/cras_alsa_mixer.c [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/tests/alsa_mixer_unittest.cc [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/server/cras_alsa_mixer.h [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/tests/alsa_card_unittest.cc [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/server/cras_alsa_io.h [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/tests/alsa_io_unittest.cc [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/server/cras_alsa_card.c [modify] https://crrev.com/5321f04a3713b423313a20c15a100b7772a3cef0/cras/src/Makefile.am
,
Apr 17 2017
,
May 17 2017
Hi Hsin-yu, can you please instruct how to verify the fix. Thanks a lot!
,
May 17 2017
helenzhang@ I think regression check should be enough.
,
May 22 2017
Verified in Chrome OS 60.0.3105.0, 9574.0.0. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 23 2017