Untriaged it so that it gets addressed.

Note: Above issue is seen on latest beta build 56.0.2924.67 as well.

Many (or all?) internal chrome:// pages can not be opened in Incognito. You can try that by manually navigating to chrome://suggestion in an Incognito window.

I guess we could try to communicate that by removing the "Open in incognito" menu item from the context menu.

+maxwalker@ can you please help with routing this?

In my view disabling the open-in-incognito context menu item would be preferable over removing it. It equally communicates that the action is not available and consistent placement generally makes it easier to internalize actions. This is similar to how we disable the back/forward context menu actions when there is nowhere to navigate.

Some internal pages (like chrome://version/ or chrome://inspect/) can be opened in incognito mode. Could we keep the action enabled for these and disable it for the other cases?

+ Edward and Alex who have been thinking about menus a lot

That (#4) sounds right to me. 

+emilyschechter@ since I have a vague memory of talking about incognito weirdness for chrome internal pages.

Max, should we also keep "history" in the incognito wrench menu and disable it? 
I notice that right now we remove it. 

+1 for disabling the menu item versus removal. For reference, currently when browsing in an incognito window, the menu item is disabled.

The list of links that don't work in incognito from chrome://about/:
chrome://bookmarks
chrome://chrome/
chrome://devices/
chrome://extensions/
chrome://help/
chrome://history/
chrome://settings/
chrome://suggestions/
chrome://thumbnails/

Deleted: Screen Shot 2017-01-24 at 12.48.05.png 73.8 KB

	Screen Shot 2017-01-24 at 12.48.05.png 73.8 KB View Download

Disabling "Open in Incognito window" for all chrome:// URIs should be trivial.
Disabling it selectively for specific chrome:// URIs is more complicated and would remain a maintenance burden forever.

This really feels like more of a P3 than a P2?

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -2155,6 +2155,11 @@ bool RenderViewContextMenu::IsOpenLinkOTREnabled() const {
   if (browser_context_->IsOffTheRecord() || !params_.link_url.is_valid())
     return false;

+  // No incognito for chrome:// links.  https://crbug.com/682163 
+  if (params_.link_url.SchemeIs(content::kChromeUIScheme)) {
+    return false;
+  }
+
   IncognitoModePrefs::Availability incognito_avail =
       IncognitoModePrefs::GetAvailability(GetPrefs(browser_context_));
   return incognito_avail != IncognitoModePrefs::DISABLED;

https://codereview.chromium.org/2850153002

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b60fcce6235c4ff9a4a2fbdd18e0d36f29879d4f

commit b60fcce6235c4ff9a4a2fbdd18e0d36f29879d4f
Author: elawrence <elawrence@chromium.org>
Date: Wed May 03 14:02:31 2017

Disable Open in Incognito menu item for urls disallowed in Incognito

Some URLs are not permitted to load in Incognito mode, instead opening back in the regular browser window, making the "Open Link in Incognito Window" context menu link misleading.

To address this, disable the menu command for links that are disallowed in Incognito mode.

BUG= 682163 

Review-Url: https://codereview.chromium.org/2850153002
Cr-Commit-Position: refs/heads/master@{#468958}

[modify] https://crrev.com/b60fcce6235c4ff9a4a2fbdd18e0d36f29879d4f/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/b60fcce6235c4ff9a4a2fbdd18e0d36f29879d4f/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Closing per #10.