Issue metadata
Sign in to add a comment
|
Regression: Default focus is seen on checkbox rather than ok button in install bubble on Linux |
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2985.0 dev OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Freshly install build and launch it , we get install bubble Expected: Default focus should be seen on "Ok" button. Actual: Instead focus is seen on first checkbox. This is a regression issue broken in M57. Manual Bisect Info: =================== Good Build: 57.0.2983.0 dev Bad Build: 57.0.2984.0 dev NOTE: Issue is not applicable to Windows.
,
Jan 18 2017
Unable to provide the hasbisect per revision bisect as scenario cannot be tested on invoked builds. Changelog: ========== https://chromium.googlesource.com/chromium/src/+log/57.0.2983.0..57.0.2984.0?pretty=fuller&n=10000 patricialor@: Could this be related to https://codereview.chromium.org/2604303002 as
,
Feb 10 2017
Yep, that was me. I've got a fix out at https://codereview.chromium.org/2684403002/. Thanks for the report and bisect!
,
Feb 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3033684819d40bb35117382a522ce95c98262de8 commit 3033684819d40bb35117382a522ce95c98262de8 Author: patricialor <patricialor@chromium.org> Date: Mon Feb 20 00:57:56 2017 Views: Don't advance focus in Widgets when the stored focus view is not null. r443827 introduced behavior where if the initially focused View failed to receive focus, the Widget would manually advance focus to the first View in the traversal order. However, this introduced a bug where if there was a stored focus view in the FocusManager, it would advance the focus anyway. Fix this by checking the FocusManager's stored focus view as well. BUG= 682157 Review-Url: https://codereview.chromium.org/2684403002 Cr-Commit-Position: refs/heads/master@{#451536} [modify] https://crrev.com/3033684819d40bb35117382a522ce95c98262de8/ui/views/widget/widget.cc [modify] https://crrev.com/3033684819d40bb35117382a522ce95c98262de8/ui/views/window/dialog_delegate_unittest.cc
,
Feb 20 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Jan 18 2017