New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682153 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Horizontal scroll bar doesn't work in 'Performance' section of devtools.

Reported by mni...@etouch.net, Jan 18 2017

Issue description

Version: 57.0.2985.0 8c8ff90c8edc7244e4e6d7feda073c76e6949b8e-refs/heads/master@{#444244} (64-bit)
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools.
2. Now go to 'Performance' section and drag the devtools window to RHS so that horizontal scroll bar is seen
3. Now try to drag or move the horizontal scroll bar,observe 

Actual: Horizontal scroll bar doesn't work
Expected: Horizontal scroll bar should work

This is regression issue, broken in ‘M 57’ and will soon update other info :
Good build:57.0.2984.0
Bad build: 57.0.2985.0
 
Actual_video.mov
4.6 MB Download
Expected_video.mov
7.4 MB Download

Comment 1 by mni...@etouch.net, Jan 18 2017

Labels: hasbisect
Owner: alph@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect :
https://chromium.googlesource.com/chromium/src/+log/477b394820e9c1308ccde24f69ddf5d0504ee609..8c6639a24a1df1f7e78ab630419e41048778b785?pretty=fuller&n=100

Suspecting: r444175 from Narrow bisect

@alph: Could you please help to reassign if your change is not the cause for this change.
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by alph@chromium.org, Jan 18 2017

Cc: alph@chromium.org
Components: -Platform>DevTools Blink>Layout>Flexbox
Owner: ----
Status: Untriaged (was: Assigned)
The bisect seems to be wrong. added "pointer-event: none" could not affect scrollbar.

Looks like a flex layout bug to me.
Labels: -hasbisect Needs-Bisect

Comment 5 by e...@chromium.org, Jan 18 2017

Owner: cbiesin...@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Needs-Bisect hasbisect-per-revision
Re-executed per-revision bisect and got the same suspect provided in Comment#1.
Providing the suspected commit from per-bisect revision.
https://chromium.googlesource.com/chromium/src/+log/477b394820e9c1308ccde24f69ddf5d0504ee609..1b769b1c19470c4df1b369bd4ebfeb40afc4dc3d

Commit#
https://chromium.googlesource.com/chromium/src/+/1b769b1c19470c4df1b369bd4ebfeb40afc4dc3d

Thank You.

Comment 7 by alph@chromium.org, Jan 19 2017

Thanks for the second bisect.
It just confirms that something is wrong with layout if changing pointer-events property affects it.
Labels: Needs-triage-Mobile
Labels: -Needs-triage-Mobile
cbiesinger@ Since this issue is marked as RB-Stable for M-57, can we get any latest update on this issue?

Thanks!
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue on Mac 10.12.3 with chrome canary #58.0.3011.0, as per steps mentioned in the comment #0

Observed that in step 2, when we drag dev tools window to RHS, no horizontal bar is seen.

mnikam@ could you please confirm this ???

Comment 13 by mni...@etouch.net, Feb 14 2017

Labels: -Needs-Feedback
With response to comment #12 :

Rechecked the above issue on latest canary chrome version : 58.0.3011.1 on Windows and Mac OS and the issue is not reproducible.It looks like scroll bar doesn't appear any more in 'Performance' section of devtools.
Cc: cbiesin...@chromium.org
Components: -Blink>Layout>Flexbox Platform>Apps>DevTools Blink>Input
Labels: Needs-Bisect
Owner: ----
Status: Untriaged (was: Assigned)
I'm confused -- the bug is not that pointer-events affects layout, it is that it affects whether the scrollbar works. That totally seems like something that could be affected by pointer-events. Why was this assigned to layout?

Putting this back in devtools, and Input for the pointer-events thing.

Also per comment 13 this seems to be working now, so adding needs-bisect to see if we can find out what fixed this.

Comment 15 by alph@chromium.org, Feb 15 2017

Components: -Platform>Apps>DevTools Blink>Layout>Scrollbars
It works because we changed layout of the page since then. To reproduce please apply the patch:

====================
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css b/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css
index 96eca8c24852..a9a7bcd7ec64 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css
@@ -658,7 +658,8 @@
 }
 
 .timeline-landing-page > div {
-    max-width: 450px;
+    /* max-width: 450px; */
+    width: 450px;
     margin: 10px;
 }
 
======================

Not sure it's really related to pointer-events. I tried to remove the property, but it didn't help.

Comment 16 by e...@chromium.org, Feb 15 2017

Status: WontFix (was: Untriaged)
Closing as this now works as expected. If there is a specific issue with pointer events  and scrollbars please file a separate issue for that.

Comment 17 by alph@chromium.org, Feb 15 2017

Components: Blink>Layout>Flexbox
Labels: -Needs-Bisect
Status: Untriaged (was: WontFix)
Sorry, I couldn't get why it is WAI?

I see two problems here:
  - the inner div is positioned past the left edge of the flex parent.
  - it's impossible to scroll there

Please see the attached screenshot.
Screenshot from 2017-02-15 11:28:49.png
235 KB View Download
Status: WontFix (was: Untriaged)
That's a different bug from what was originally reported. The reason as shown in your screenshot is that you're using justify-content: center. If you do that, any content that overflows to the left (in a row flexbox) will be outside the element and you can't scroll to that. We do not support scrolling in both directions which is what this would need.

Sign in to add a comment