New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682145 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression : ChromeVox (Spoken Feedback) is not correctly reading Accessibility settings options in OOBE screen.

Project Member Reported by jbanavatu@chromium.org, Jan 18 2017

Issue description

Chrome Version: 57.0.2984.0/9194.0.0 dev channel Daisy,Candy,Peppy
OS: Chrome

What steps will reproduce the problem?
(1)Recover build via USB>>Go to Accessibility settings screen by clicking Accessibility button in welcome screen.
(2)Enable Chrome Vox (Spoken Feedback) option >> Now hit tab to cycle through the Accessibility settings options and observe.

Expected: ChromeVox spoken feedback should output accessibility option name  followed by Button pressed/not pressed depending on the state of the row.
Actual: Instead the spoken feedback for all rows is just Button pressed/not pressed 

This is regression issue as it working fine in 56.0.2924.58/9000.58.0 Beta channel quawks

Attaching screenshots for reference.
 
Actual.jpg
3.3 MB View Download
Expected.jpg
4.1 MB View Download
Cc: lpalmaro@chromium.org dtseng@chromium.org

Comment 2 by dtseng@chromium.org, Jan 19 2017

Confirmed. The labels are not correctly associated with the toggle buttons. The buttons themselves are correctly exposing whether they toggled or not.

Suggestion: add aria-labelledby to each toggle button to associate it with the label.

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/824235e7763820cb2a81c1d09573a0aa335d4ff8

commit 824235e7763820cb2a81c1d09573a0aa335d4ff8
Author: alemate <alemate@chromium.org>
Date: Thu Feb 09 00:43:14 2017

ChromeOS OOBE: Add ARIA-labels for OOBE screens.

BUG= 682145 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2681923005
Cr-Commit-Position: refs/heads/master@{#449162}

[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_a11y_option.js
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_screen_network.js
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
[modify] https://crrev.com/824235e7763820cb2a81c1d09573a0aa335d4ff8/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD -ReleaseBlock-Stable -M-57 M-58
Removing merge requests and targeting against M58 as this has been disabled for M57.
Status: Verified (was: Fixed)

Sign in to add a comment