Move EditCommand::starting/endingSelection to CompositeEditCommand |
||
Issue descriptionstarting and ending selection are defined for all edit commands, but simple edit commands do not need them. We should move them down to CompositeEditCommand to reduce the complexity in the construction of SimpleEditCommand.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2742a8b3bdc414e596a9382a3b6959c0c4e95f93 commit 2742a8b3bdc414e596a9382a3b6959c0c4e95f93 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Jan 19 01:28:05 2017 Move EditCommand::starting/endingSelection() to CompositeEditCommand (2/2) BUG= 682137 Review-Url: https://codereview.chromium.org/2645453002 Cr-Commit-Position: refs/heads/master@{#444587} [modify] https://crrev.com/2742a8b3bdc414e596a9382a3b6959c0c4e95f93/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp [modify] https://crrev.com/2742a8b3bdc414e596a9382a3b6959c0c4e95f93/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
,
Jan 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 18 2017