New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682128 link

Starred by 3 users
Status: Verified
Owner:
amaralp@chromium.org
Closed: Feb 2017
Cc:
█ aelias@chromium.org
yosin@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Text selection handles and selection input bar disappear on selecting all text from a web page

Reported by ahalder@etouch.net, Jan 18 2017 
Application Version: 57.0.2985.0
Android Build Number: 7.1.1/NMF26U
Device: Google Pixel


Steps to reproduce:
1. Launch Chrome > Visit any web page
2. Select a text > Observe the text selection handles and text selection input bar
3. Choose 'Select all' from text selection input bar
4. Observe


Observed behavior:
Text selection handles and selection input bar disappears on selecting all text from a web page

Expected behavior:
Text selection handles and selection input bar should stay when all text is selected from a web page


Frequency: 
<5/5>

Additional comments:
This issue is not present of latest M56-56.0.2924.68

Last Good Build: 57.0.2984.0
First Bad Build: 57.0.2985.0

This issue is seen on Android devices ex. Google Pixel (7.1/NDE63V), Spice Mi-498 (6.0.1/MOB30W), Karbonn Sparkle V (5.1.1/LMY47V), Samsung Galaxy J2 (5.1.1/LMY47X), Samsung Galaxy S3 (4.3/JSS15J), Samsung Galaxy J7 (5.1.1/LMY48B), Samsung Galaxy S4 (5.0.1/LRX22C), Nexus 7 (6.0.1/MOB30X) and Nexus 9 (7.1.1/N4F26M)

Bisect Range: https://chromium.googlesource.com/chromium/src/+log/57.0.2984.0..57.0.2985.0?pretty=fuller&n=10000

Comment 1 by ahalder@etouch.net, Jan 18 2017 

Please find logs and Video @ http://go/chrome-androidlogs1/6/682128

Comment 2 by rbyers@chromium.org, Jan 18 2017

Cc: aelias@chromium.org
Components: UI>Browser>Mobile

Comment 3 by aelias@chromium.org, Jan 18 2017

Labels: -Restrict-View-Google -Pri-3 ReleaseBlock-Stable M-57 Pri-2
Owner: amaralp@chromium.org
Status: Assigned (was: Unconfirmed)
https://codereview.chromium.org/2201853002 "Blink handle selection handle visibility" is in the range.

Tentatively marking releaseblock-stable since it sounds like this would make "Select All" no longer usable outside of textboxes (although I don't have a recent enough version to locally repro yet).

Comment 4 by kgna...@chromium.org, Jan 20 2017

Labels: Type-Bug-Regression

Comment 5 by amaralp@chromium.org, Jan 23 2017 

Issue 683088 has been merged into this issue.

Comment 6 by satyavat...@chromium.org, Jan 26 2017

Labels: -Pri-2 Pri-1

Comment 7 by aelias@chromium.org, Jan 26 2017

Cc: changwan@chromium.org yosin@chromium.org
Labels: Merge-Request-57
Requesting merge of inverse of https://codereview.chromium.org/2201853002 "Blink handle selection handle visibility".  Let's get it off the branch and just keep it moving forward for 58 to avoid needing to cherry-pick all the fixes.
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 31 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a0edccbd81c94be848c35be0c541dda6d015d84

commit 4a0edccbd81c94be848c35be0c541dda6d015d84
Author: Alexandre Elias <aelias@chromium.org>
Date: Tue Jan 31 18:24:34 2017

Revert "Blink handle selection handle visibility"

This reverts commit 1107a295dcee2f4ee3f6c24f836c6adfa7b3830d
directly off M57 branch to address selection regressions
(long-term fix being worked on on trunk).

BUG=686700, 682128 ,633281
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2664253002 .
Cr-Commit-Position: refs/branch-heads/2987@{#226}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/browser/renderer_host/render_widget_host_view_event_handler.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/content/test/data/touch_selection.html
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/core/editing/SelectionController.h
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_basic.html
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_editable_div.html
[add] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_editable_area.html
[add] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_editable_div.html
[add] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_editable_input.html
[add] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_layer.html
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_iframe.html
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_transformed.html
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/ui/touch_selection/selection_event_type.h
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/ui/touch_selection/touch_selection_controller.cc
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/ui/touch_selection/touch_selection_controller.h
[modify] https://crrev.com/4a0edccbd81c94be848c35be0c541dda6d015d84/ui/touch_selection/touch_selection_controller_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a8e4260519fb8e3b0f0acb80751ff89f1fc17f

commit 92a8e4260519fb8e3b0f0acb80751ff89f1fc17f
Author: amaralp <amaralp@chromium.org>
Date: Tue Feb 07 23:29:31 2017

Select All should show handles if they were already present

If the touch handles were present when the select all was executed then the newly selected text should also have touch handles.

BUG= 682128 

Review-Url: https://codereview.chromium.org/2663593002
Cr-Commit-Position: refs/heads/master@{#448785}

[modify] https://crrev.com/92a8e4260519fb8e3b0f0acb80751ff89f1fc17f/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/92a8e4260519fb8e3b0f0acb80751ff89f1fc17f/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Comment 11 by amaralp@chromium.org, Feb 8 2017

Status: Fixed (was: Assigned)

Comment 12 by amaralp@chromium.org, Feb 10 2017 

Issue 688630 has been merged into this issue.

Comment 13 by ahalder@etouch.net, Feb 14 2017 

This issue is fixed on latest M57-57.0.2987.52 and M58-58.0.3012.0 Thanks!

Comment 14 by arunshan@chromium.org, Feb 14 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment