Cast functionality broken when using Wayland on Linux (Black Screen instead of desktop)
Reported by
meatwadd...@gmail.com,
Jan 18 2017
|
|||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: 1. On Fedora 25 (using Wayland) try to cast full desktop 2. The desktop picker shows black screen 3. The TV will show just black screen with cursor moving around. What is the expected behavior? Should be able to see full desktop. What went wrong? Casting desktop works when using xorg, but not with Wayland. Casting a single tab or window also works (though it only shows windows on the same 'virtual desktop' as Chrome. Did this work before? N/A Chrome version: 55.0.2883.87 Channel: stable OS Version: Fedoa 25 Flash Version: Shockwave Flash 24.0 r0 Searching around, I've found that this commonly occurs in other apps that hadn't updated to support Wayland yet, as requesting the desktop with the old hook would just give a black screen. It's possible that the Cast feature just needs to know the correct API? to talk to Wayland.
,
Jan 18 2017
,
Jan 19 2017
,
Jan 19 2017
,
Jan 19 2017
miu@ can you help with triage here?
,
Jan 19 2017
miu@ doesn't own desktop capture. Suggest reassigning to niklase@ or someone from WebRTC who does.
,
Jan 20 2017
Yeah we only have x11 support. Sergey, have you or anyone in your team looked at this?
,
Jan 20 2017
No, we haven't looked at implementing capturer for Wayland.
,
Jan 23 2017
,
Feb 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
Is this still valid/relevant?
,
Mar 23 2018
niklase@, can you re-triage this issue?
,
Mar 23 2018
Keeping this available to track stars to determine need.
,
May 20 2018
Hi, For the record, there is now an API for screen grabbing in freedesktop: https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.ScreenCast.xml It is already implemented in Gnome/mutter under wayland using Pipewire, see https://wiki.gnome.org/Projects/Mutter/RemoteDesktop for details. This would be great if the work on supporting this could start, Wayland is the future of Linux desktop and already used in many mainstream distribution by default.
,
Aug 1
,
Nov 1
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd commit dd20c9c1e3f681f6c33d1879c76f588bd4b095bd Author: Tomas Popela <tomas.popela@gmail.com> Date: Thu Nov 01 08:46:38 2018 Add support for screen sharing with PipeWire on Wayland Currently, when users want to use the screen sharing and are using the Wayland display server (the default on Fedora distribution), then it doesn't work, because the WebRTC only includes the X11 implementation. This change adds the support by using the PipeWire multimedia server. The PipeWire implementation in WebRTC stays in screen-capturer-pipewire.c and is guarded by the rtc_use_pipewire build flag that is automatically enabled on Linux. More information are included in the relevant commit messages. Tested on the current Chromium master and Firefox. The sysroot changes are requested in: https://chromium-review.googlesource.com/c/chromium/src/+/1258174 Co-authored-by: Jan Grulich <grulja@gmail.com> Co-authored-by: Eike Rathke <erathke@redhat.com> Change-Id: I212074a4bc437b99a77bf383266026c5bfae7c4a BUG=chromium:682122 Change-Id: I212074a4bc437b99a77bf383266026c5bfae7c4a Reviewed-on: https://webrtc-review.googlesource.com/c/103504 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25461} [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/AUTHORS [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/desktop_capture_options.h [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/desktop_capturer.cc [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/desktop_capturer.h [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/base_capturer_pipewire.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/base_capturer_pipewire.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/mouse_cursor_monitor_x11.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/mouse_cursor_monitor_x11.h [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/screen_capturer_pipewire.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/screen_capturer_pipewire.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/screen_capturer_x11.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/screen_capturer_x11.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/shared_x_display.cc [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/shared_x_display.h [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_capturer_pipewire.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_capturer_pipewire.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_capturer_x11.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_capturer_x11.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_finder_x11.cc [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_finder_x11.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_list_utils.cc [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/window_list_utils.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/x_atom_cache.cc [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/x_atom_cache.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/x_error_trap.cc [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/x_error_trap.h [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/x_server_pixel_buffer.cc [rename] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/linux/x_server_pixel_buffer.h [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/mouse_cursor_monitor_linux.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/screen_capturer_linux.cc [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/screen_drawer_linux.cc [add] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/window_capturer_linux.cc [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/modules/desktop_capture/window_finder_unittest.cc [modify] https://crrev.com/dd20c9c1e3f681f6c33d1879c76f588bd4b095bd/webrtc.gni
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/338e2095e09bbfa5071553b0b3f836c1f520a7aa commit 338e2095e09bbfa5071553b0b3f836c1f520a7aa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Nov 01 12:27:45 2018 Roll src/third_party/webrtc 7f4dfa4106c9..4e9332983946 (2 commits) https://webrtc.googlesource.com/src.git/+log/7f4dfa4106c9..4e9332983946 git log 7f4dfa4106c9..4e9332983946 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 yvesg@webrtc.org Properly setup MockPeerConnectionObserver in tests (continued). 2018-11-01 tomas.popela@gmail.com Add support for screen sharing with PipeWire on Wayland Created with: gclient setdep -r src/third_party/webrtc@4e9332983946 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief57bdc07575588747837a3474c880e514bd82bf Reviewed-on: https://chromium-review.googlesource.com/c/1312640 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604563} [modify] https://crrev.com/338e2095e09bbfa5071553b0b3f836c1f520a7aa/DEPS
,
Nov 6
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5 commit 3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5 Author: Patrik Höglund <phoglund@webrtc.org> Date: Tue Nov 06 14:17:34 2018 Revert "Add support for screen sharing with PipeWire on Wayland" This reverts commit dd20c9c1e3f681f6c33d1879c76f588bd4b095bd. Reason for revert: Speculative revert; looks like it causes crashes on official builders. See crbug.com/901319 . Original change's description: > Add support for screen sharing with PipeWire on Wayland > > Currently, when users want to use the screen sharing and are using the > Wayland display server (the default on Fedora distribution), then it > doesn't work, because the WebRTC only includes the X11 implementation. > This change adds the support by using the PipeWire multimedia server. > > The PipeWire implementation in WebRTC stays in > screen-capturer-pipewire.c and is guarded by the rtc_use_pipewire build > flag that is automatically enabled on Linux. > > More information are included in the relevant commit messages. > > Tested on the current Chromium master and Firefox. > > The sysroot changes are requested in: > https://chromium-review.googlesource.com/c/chromium/src/+/1258174 > > Co-authored-by: Jan Grulich <grulja@gmail.com> > Co-authored-by: Eike Rathke <erathke@redhat.com> > Change-Id: I212074a4bc437b99a77bf383266026c5bfae7c4a > > BUG=chromium:682122 > > Change-Id: I212074a4bc437b99a77bf383266026c5bfae7c4a > Reviewed-on: https://webrtc-review.googlesource.com/c/103504 > Commit-Queue: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25461} TBR=phoglund@webrtc.org,jamiewalch@chromium.org,niklas.enbom@webrtc.org,braveyao@webrtc.org,tomas.popela@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. NOPRESUBMIT=true Bug: chromium:682122, chromium:901319 Change-Id: I4ca5da77daea73cae1232953a0d633900a85a93d Reviewed-on: https://webrtc-review.googlesource.com/c/109584 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25522} [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/AUTHORS [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/desktop_capture_options.h [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/desktop_capturer.cc [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/desktop_capturer.h [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/base_capturer_pipewire.cc [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/base_capturer_pipewire.h [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/mouse_cursor_monitor_x11.h [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/screen_capturer_pipewire.cc [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/screen_capturer_pipewire.h [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/screen_capturer_x11.h [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/window_capturer_pipewire.cc [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/window_capturer_pipewire.h [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/linux/window_capturer_x11.h [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/mouse_cursor_monitor_linux.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/mouse_cursor_monitor_x11.cc [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/screen_capturer_linux.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/screen_capturer_x11.cc [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/screen_drawer_linux.cc [delete] https://crrev.com/82c07ea1da4ac4a0df469333fe2142da27b6de21/modules/desktop_capture/window_capturer_linux.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/window_capturer_x11.cc [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/window_finder_unittest.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/window_finder_x11.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/window_finder_x11.h [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/shared_x_display.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/shared_x_display.h [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/window_list_utils.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/window_list_utils.h [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/x_atom_cache.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/x_atom_cache.h [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/x_error_trap.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/x_error_trap.h [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/x_server_pixel_buffer.cc [rename] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/modules/desktop_capture/x11/x_server_pixel_buffer.h [modify] https://crrev.com/3ddaf3c40881ad98c480f0df7cfec6d50d4cdca5/webrtc.gni
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9e4ec1adb5906b7186faeec89f4ddf82950ad16 commit a9e4ec1adb5906b7186faeec89f4ddf82950ad16 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Nov 06 18:16:16 2018 Roll src/third_party/webrtc a8f54617c08d..277b6ea8508e (4 commits) https://webrtc.googlesource.com/src.git/+log/a8f54617c08d..277b6ea8508e git log a8f54617c08d..277b6ea8508e --date=short --no-merges --format='%ad %ae %s' 2018-11-06 alessiob@webrtc.org Isolating APM API build target: adding dummy :api target. 2018-11-06 phoglund@webrtc.org Revert "Add support for screen sharing with PipeWire on Wayland" 2018-11-06 ilnik@webrtc.org Tune huge video frames detection threshold for GetStats googHugeFramesSent stat 2018-11-06 sprang@webrtc.org Make VideoSendStreamTest.NoPaddingWhenVideoIsMuted less flaky Created with: gclient setdep -r src/third_party/webrtc@277b6ea8508e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122, chromium:901319 ,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6dadb5c6014d55b6065ea8c415045b3854688c65 Reviewed-on: https://chromium-review.googlesource.com/c/1319810 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605743} [modify] https://crrev.com/a9e4ec1adb5906b7186faeec89f4ddf82950ad16/DEPS
,
Nov 13
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/318da51f99f91e3de1192f29d7f1824958f9f13e commit 318da51f99f91e3de1192f29d7f1824958f9f13e Author: Tomas Popela <tomas.popela@gmail.com> Date: Tue Nov 13 15:05:05 2018 Reland "Add support for screen sharing with PipeWire on Wayland" The content_unittests failure was caused by wrong path in the cfi blacklist (when the files from x11 folder were moved to the linux folder by this change). Bug: chromium:682122 Change-Id: I4f7f6c5a73a981feeac18494749f85935e812981 Reviewed-on: https://webrtc-review.googlesource.com/c/110461 Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25621} [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/AUTHORS [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/desktop_capture_options.h [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/desktop_capturer.cc [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/desktop_capturer.h [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/base_capturer_pipewire.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/base_capturer_pipewire.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/mouse_cursor_monitor_x11.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/mouse_cursor_monitor_x11.h [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/screen_capturer_pipewire.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/screen_capturer_pipewire.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/screen_capturer_x11.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/screen_capturer_x11.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/shared_x_display.cc [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/shared_x_display.h [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_capturer_pipewire.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_capturer_pipewire.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_capturer_x11.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_capturer_x11.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_finder_x11.cc [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_finder_x11.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_list_utils.cc [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/window_list_utils.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/x_atom_cache.cc [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/x_atom_cache.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/x_error_trap.cc [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/x_error_trap.h [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/x_server_pixel_buffer.cc [rename] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/linux/x_server_pixel_buffer.h [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/mouse_cursor_monitor_linux.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/screen_capturer_linux.cc [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/screen_drawer_linux.cc [add] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/window_capturer_linux.cc [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/modules/desktop_capture/window_finder_unittest.cc [modify] https://crrev.com/318da51f99f91e3de1192f29d7f1824958f9f13e/webrtc.gni
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18cb3222f894072512ff5a56aa1ba7b5443a5e0f commit 18cb3222f894072512ff5a56aa1ba7b5443a5e0f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Nov 13 19:50:11 2018 Roll src/third_party/webrtc 44ca9a392ac6..c7e3af1ad928 (4 commits) https://webrtc.googlesource.com/src.git/+log/44ca9a392ac6..c7e3af1ad928 git log 44ca9a392ac6..c7e3af1ad928 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 terelius@webrtc.org Remove rtc_event_log2stats. 2018-11-13 jonasolsson@webrtc.org Introduce DLOG to video and voiceengine. 2018-11-13 tomas.popela@gmail.com Reland "Add support for screen sharing with PipeWire on Wayland" 2018-11-13 alessiob@webrtc.org AGC2: adding level estimation option (RMS or peak-based). Created with: gclient setdep -r src/third_party/webrtc@c7e3af1ad928 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id5a0ea4e3980c70d91601c64b8f68a43b7469927 Reviewed-on: https://chromium-review.googlesource.com/c/1333860 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607710} [modify] https://crrev.com/18cb3222f894072512ff5a56aa1ba7b5443a5e0f/DEPS
,
Nov 21
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/a13be019017449c57f48203d0fb778f34f7553a7 commit a13be019017449c57f48203d0fb778f34f7553a7 Author: Tomas Popela <tomas.popela@gmail.com> Date: Wed Nov 21 08:33:04 2018 Default to dlopening the PipeWire. Reuse the existing infra from Chromium to do that. Additionally the target_gen_dir needs to the added to the include directories, otherwise the Chromium build will fail as it won't find the generated stubs. Also the pw_properties_new() was replaced with pw_properties_new_string() as it doesn't require a variadic parameter because the //tools/generate_stubs/generate_stubs.py doesn't work with them correctly. With all these changes in place the PipeWire support is enabled when compiling on Linux. Bug: chromium:682122 Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d Reviewed-on: https://webrtc-review.googlesource.com/c/111081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#25720} [modify] https://crrev.com/a13be019017449c57f48203d0fb778f34f7553a7/BUILD.gn [modify] https://crrev.com/a13be019017449c57f48203d0fb778f34f7553a7/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/a13be019017449c57f48203d0fb778f34f7553a7/modules/desktop_capture/linux/base_capturer_pipewire.cc [add] https://crrev.com/a13be019017449c57f48203d0fb778f34f7553a7/modules/desktop_capture/linux/pipewire.sigs [add] https://crrev.com/a13be019017449c57f48203d0fb778f34f7553a7/modules/desktop_capture/linux/pipewire_stub_header.fragment [modify] https://crrev.com/a13be019017449c57f48203d0fb778f34f7553a7/webrtc.gni
,
Nov 21
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/c4d5642e136331459db922dbeb68f995d6f2411c commit c4d5642e136331459db922dbeb68f995d6f2411c Author: Oleh Prypin <oprypin@webrtc.org> Date: Wed Nov 21 09:20:41 2018 Revert "Default to dlopening the PipeWire." This reverts commit a13be019017449c57f48203d0fb778f34f7553a7. Reason for revert: The GN definitions cause problems for downstream tooling. They're also generally complicated and reach deep into Chromium's build which is undesirable. Setting `rtc_use_pipewire = true` by default should also be re-evaluated. Original change's description: > Default to dlopening the PipeWire. > > Reuse the existing infra from Chromium to do that. Additionally the > target_gen_dir needs to the added to the include directories, otherwise > the Chromium build will fail as it won't find the generated stubs. Also the > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > doesn't work with them correctly. With all these changes in place the PipeWire > support is enabled when compiling on Linux. > > Bug: chromium:682122 > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > Cr-Commit-Position: refs/heads/master@{#25720} TBR=phoglund@webrtc.org,mbonadei@webrtc.org,braveyao@webrtc.org,tomas.popela@gmail.com Change-Id: Iec20b07cb1cff7d57f8114ac6ec2d0d250e61214 No-Try: true Bug: chromium:682122 Reviewed-on: https://webrtc-review.googlesource.com/c/111584 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25722} [modify] https://crrev.com/c4d5642e136331459db922dbeb68f995d6f2411c/BUILD.gn [modify] https://crrev.com/c4d5642e136331459db922dbeb68f995d6f2411c/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/c4d5642e136331459db922dbeb68f995d6f2411c/modules/desktop_capture/linux/base_capturer_pipewire.cc [delete] https://crrev.com/c69a56ef04c47c21cfd14009ed2465bee528d7de/modules/desktop_capture/linux/pipewire.sigs [delete] https://crrev.com/c69a56ef04c47c21cfd14009ed2465bee528d7de/modules/desktop_capture/linux/pipewire_stub_header.fragment [modify] https://crrev.com/c4d5642e136331459db922dbeb68f995d6f2411c/webrtc.gni
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4432b96a0d309760775232d414ede6013206510 commit a4432b96a0d309760775232d414ede6013206510 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Nov 21 13:39:46 2018 Roll src/third_party/webrtc 66eedce30a82..c4d5642e1363 (5 commits) https://webrtc.googlesource.com/src.git/+log/66eedce30a82..c4d5642e1363 git log 66eedce30a82..c4d5642e1363 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 oprypin@webrtc.org Revert "Default to dlopening the PipeWire." 2018-11-21 solenberg@webrtc.org Remove more unneeded things from ChannelSend 2018-11-21 tomas.popela@gmail.com Default to dlopening the PipeWire. 2018-11-21 nisse@webrtc.org Add test PeerConnectionIntegrationTest.MediaTransportBidirectionalAudio 2018-11-21 srte@webrtc.org Adds target bandwidth to BitrateAllocator. Created with: gclient setdep -r src/third_party/webrtc@c4d5642e1363 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122,chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If0a6cb37ae9d07956800d3590c36ce8b02f5ab86 Reviewed-on: https://chromium-review.googlesource.com/c/1346170 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610034} [modify] https://crrev.com/a4432b96a0d309760775232d414ede6013206510/DEPS
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e14ed8784837da724260359cb4a31b3bf29a7e55 commit e14ed8784837da724260359cb4a31b3bf29a7e55 Author: Oleh Prypin <oprypin@chromium.org> Date: Tue Nov 27 15:43:33 2018 Make a GN template for generate_stubs.py Make it produce a source_set which can be depended on rather than directly including sources into the parent target. Bug: chromium:682122 Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 Reviewed-on: https://chromium-review.googlesource.com/c/1348042 Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611117} [modify] https://crrev.com/e14ed8784837da724260359cb4a31b3bf29a7e55/media/audio/BUILD.gn [modify] https://crrev.com/e14ed8784837da724260359cb4a31b3bf29a7e55/media/gpu/BUILD.gn [modify] https://crrev.com/e14ed8784837da724260359cb4a31b3bf29a7e55/media/gpu/vaapi/BUILD.gn [add] https://crrev.com/e14ed8784837da724260359cb4a31b3bf29a7e55/tools/generate_stubs/rules.gni
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/179ebaeeaa56a0f4c5e2a601ecab1b3e912273f1 commit 179ebaeeaa56a0f4c5e2a601ecab1b3e912273f1 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Nov 28 00:03:17 2018 Revert "Make a GN template for generate_stubs.py" This reverts commit e14ed8784837da724260359cb4a31b3bf29a7e55. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make a GN template for generate_stubs.py > > Make it produce a source_set which can be depended on rather than directly including sources into the parent target. > > Bug: chromium:682122 > Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1348042 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611117} TBR=dpranke@chromium.org,sandersd@chromium.org,mbonadei@chromium.org,oprypin@chromium.org Change-Id: Ic1f0262000fab30b680def6eb95ba0f55b6b9c50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:682122 Reviewed-on: https://chromium-review.googlesource.com/c/1352039 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611435} [modify] https://crrev.com/179ebaeeaa56a0f4c5e2a601ecab1b3e912273f1/media/audio/BUILD.gn [modify] https://crrev.com/179ebaeeaa56a0f4c5e2a601ecab1b3e912273f1/media/gpu/BUILD.gn [modify] https://crrev.com/179ebaeeaa56a0f4c5e2a601ecab1b3e912273f1/media/gpu/vaapi/BUILD.gn [delete] https://crrev.com/ad82b0dd8c62c64c808ff221bbdebf15ecbc4ed3/tools/generate_stubs/rules.gni
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cd5252f772ad51728e3c5f615c4e1263bcf0aee commit 3cd5252f772ad51728e3c5f615c4e1263bcf0aee Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Nov 28 18:25:46 2018 Revert "Make a GN template for generate_stubs.py" This reverts commit e14ed8784837da724260359cb4a31b3bf29a7e55. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make a GN template for generate_stubs.py > > Make it produce a source_set which can be depended on rather than directly including sources into the parent target. > > Bug: chromium:682122 > Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1348042 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611117} TBR=dpranke@chromium.org,sandersd@chromium.org,mbonadei@chromium.org,oprypin@chromium.org Change-Id: Ic1f0262000fab30b680def6eb95ba0f55b6b9c50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:682122 Reviewed-on: https://chromium-review.googlesource.com/c/1352039 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#611435}(cherry picked from commit 179ebaeeaa56a0f4c5e2a601ecab1b3e912273f1) Reviewed-on: https://chromium-review.googlesource.com/c/1351762 Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/branch-heads/3624@{#5} Cr-Branched-From: b54fb9cc3bbc522b006c38f4a3e88cbda2be1c59-refs/heads/master@{#611430} [modify] https://crrev.com/3cd5252f772ad51728e3c5f615c4e1263bcf0aee/media/audio/BUILD.gn [modify] https://crrev.com/3cd5252f772ad51728e3c5f615c4e1263bcf0aee/media/gpu/BUILD.gn [modify] https://crrev.com/3cd5252f772ad51728e3c5f615c4e1263bcf0aee/media/gpu/vaapi/BUILD.gn [delete] https://crrev.com/b5ab04d32855983efc5ec620adf94bf4f5a52863/tools/generate_stubs/rules.gni
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9b35972e43acb7df051bd4ee7c47ed6c9519d16 commit e9b35972e43acb7df051bd4ee7c47ed6c9519d16 Author: Oleh Prypin <oprypin@chromium.org> Date: Mon Dec 03 22:52:58 2018 Reland "Make a GN template for generate_stubs.py" This is a reland of e14ed8784837da724260359cb4a31b3bf29a7e55 With correct output path to v4l2/v4l2_stubs.{h,cc} Original change's description: > Make a GN template for generate_stubs.py > > Make it produce a source_set which can be depended on rather than directly including sources into the parent target. > > Bug: chromium:682122 > Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1348042 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611117} Bug: chromium:682122, chromium:909020 Change-Id: I1d34d5bb0dc9f4f72a444e9463669793c3f5a171 Reviewed-on: https://chromium-review.googlesource.com/c/1356703 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613300} [modify] https://crrev.com/e9b35972e43acb7df051bd4ee7c47ed6c9519d16/media/audio/BUILD.gn [modify] https://crrev.com/e9b35972e43acb7df051bd4ee7c47ed6c9519d16/media/gpu/BUILD.gn [modify] https://crrev.com/e9b35972e43acb7df051bd4ee7c47ed6c9519d16/media/gpu/vaapi/BUILD.gn [add] https://crrev.com/e9b35972e43acb7df051bd4ee7c47ed6c9519d16/tools/generate_stubs/rules.gni
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36323dd74afffbc93b9e5448d024d8390b20be3f commit 36323dd74afffbc93b9e5448d024d8390b20be3f Author: Tomas Popela <tomas.popela@gmail.com> Date: Fri Dec 07 22:56:29 2018 Add a way to set the path_from_source argument to generate_stubs It is needed when the generate_stubs template is used in the WebRTC code. Currently the generated stubs will contain a different namespace when they are compiled in the WebRTC or in the Chromium (the same value as in the WebRTC, but prefixed with the third_party_webrtc). This will cause build failures as the namespaces are used in the code that is using these stubs to access its properties. So add a way to override the path_from_source if needed. Bug: 682122 Change-Id: I636422266d25df2d1158ee152cc5747929b9fd40 Reviewed-on: https://chromium-review.googlesource.com/c/1365231 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#614856} [modify] https://crrev.com/36323dd74afffbc93b9e5448d024d8390b20be3f/tools/generate_stubs/rules.gni
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40a480f77f1c923db782625ebc37f303f1ad259f commit 40a480f77f1c923db782625ebc37f303f1ad259f Author: Tomas Popela <tomas.popela@gmail.com> Date: Fri Dec 07 23:42:37 2018 Add a way to extend the configs for the source_set Currently, only the default_compiler_configs from //build/config/BUILDCONFIG.gn is used as the default configs for the source_set that is part of the generate_stubs template. The problem is that if the logging function and the logging include are overridden for the stubs (in our case to the WebRTC ones) the compilation fails because it can't find the definitions for them. The reason for that is that the implementations in the logging include are behind some common WebRTC defines, but these defines are not currently being specified in the source_set configs. So we have to add a way to extend the configs to let it successfully compile. Bug: 682122 Change-Id: I3d8d33930ff3a9a119b08b0bd4bb17179c148e88 Reviewed-on: https://chromium-review.googlesource.com/c/1365232 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#614867} [modify] https://crrev.com/40a480f77f1c923db782625ebc37f303f1ad259f/tools/generate_stubs/rules.gni
,
Dec 12
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/a099877d8946eb942046ca1295cc142e4fa7ea6f commit a099877d8946eb942046ca1295cc142e4fa7ea6f Author: Tomas Popela <tomas.popela@gmail.com> Date: Wed Dec 12 08:22:57 2018 Reland "Default to dlopening the PipeWire." This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 Original change's description: > Default to dlopening the PipeWire. > > Reuse the existing infra from Chromium to do that. Additionally the > target_gen_dir needs to the added to the include directories, otherwise > the Chromium build will fail as it won't find the generated stubs. Also the > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > doesn't work with them correctly. With all these changes in place the PipeWire > support is enabled when compiling on Linux. > > Bug: chromium:682122 > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > Cr-Commit-Position: refs/heads/master@{#25720} Bug: chromium:682122 Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 Reviewed-on: https://webrtc-review.googlesource.com/c/113040 Reviewed-by: Weiyong Yao <braveyao@chromium.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25981} [modify] https://crrev.com/a099877d8946eb942046ca1295cc142e4fa7ea6f/BUILD.gn [modify] https://crrev.com/a099877d8946eb942046ca1295cc142e4fa7ea6f/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/a099877d8946eb942046ca1295cc142e4fa7ea6f/modules/desktop_capture/linux/base_capturer_pipewire.cc [add] https://crrev.com/a099877d8946eb942046ca1295cc142e4fa7ea6f/modules/desktop_capture/linux/pipewire.sigs [add] https://crrev.com/a099877d8946eb942046ca1295cc142e4fa7ea6f/modules/desktop_capture/linux/pipewire_stub_header.fragment [modify] https://crrev.com/a099877d8946eb942046ca1295cc142e4fa7ea6f/webrtc.gni
,
Dec 12
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/0697ce2a766315ee846173c3ec441d6756baed7d commit 0697ce2a766315ee846173c3ec441d6756baed7d Author: Henrik Grunell <henrikg@webrtc.org> Date: Wed Dec 12 13:05:56 2018 Revert "Reland "Default to dlopening the PipeWire."" This reverts commit a099877d8946eb942046ca1295cc142e4fa7ea6f. Reason for revert: Breaks WebRTC roll into Chromium. See https://chromium-review.googlesource.com/c/chromium/src/+/1373891: In file included from ../../third_party/webrtc/modules/desktop_capture/linux/window_capturer_pipewire.cc:11: In file included from ../../third_party/webrtc/modules/desktop_capture/linux/window_capturer_pipewire.h:16: ../../third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.h:16:10: fatal error: 'pipewire/pipewire.h' file not found #include <pipewire/pipewire.h> ^~~~~~~~~~~~~~~~~~~~~ Original change's description: > Reland "Default to dlopening the PipeWire." > > This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 > > Original change's description: > > Default to dlopening the PipeWire. > > > > Reuse the existing infra from Chromium to do that. Additionally the > > target_gen_dir needs to the added to the include directories, otherwise > > the Chromium build will fail as it won't find the generated stubs. Also the > > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > > doesn't work with them correctly. With all these changes in place the PipeWire > > support is enabled when compiling on Linux. > > > > Bug: chromium:682122 > > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > > Cr-Commit-Position: refs/heads/master@{#25720} > > Bug: chromium:682122 > Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 > Reviewed-on: https://webrtc-review.googlesource.com/c/113040 > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25981} TBR=phoglund@webrtc.org,mbonadei@webrtc.org,oprypin@webrtc.org,braveyao@webrtc.org,braveyao@chromium.org,tomas.popela@gmail.com Change-Id: Icdb6a94c8825f13d75ddc12219e99cee8fef51a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:682122 Reviewed-on: https://webrtc-review.googlesource.com/c/114162 Reviewed-by: Henrik Grunell <henrikg@webrtc.org> Commit-Queue: Henrik Grunell <henrikg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25989} [modify] https://crrev.com/0697ce2a766315ee846173c3ec441d6756baed7d/BUILD.gn [modify] https://crrev.com/0697ce2a766315ee846173c3ec441d6756baed7d/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/0697ce2a766315ee846173c3ec441d6756baed7d/modules/desktop_capture/linux/base_capturer_pipewire.cc [delete] https://crrev.com/1d8307d706e06ba1c9bba1573f300e7bf79fefa1/modules/desktop_capture/linux/pipewire.sigs [delete] https://crrev.com/1d8307d706e06ba1c9bba1573f300e7bf79fefa1/modules/desktop_capture/linux/pipewire_stub_header.fragment [modify] https://crrev.com/0697ce2a766315ee846173c3ec441d6756baed7d/webrtc.gni
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8788015d2b2efa354c641f4e0ed38fba726f3ae7 commit 8788015d2b2efa354c641f4e0ed38fba726f3ae7 Author: Tomas Popela <tomas.popela@gmail.com> Date: Wed Dec 12 14:56:54 2018 Add about flag for enabling the PipeWire support in WebRTC Add a new enable-webrtc-pipewire-capturer about flag, that when enabled, will allow to use the PipeWire media server for providing the screen content for screen casting when user is running on Wayland display server on Linux. The flag is disabled by default, due to the user experience as it involves two extra confirmation dialogs outside of Chromium - requested by Weiyong Yao. It could change the default, once it goes through Chromium UI review. Bug: 682122 Change-Id: I70c07a4a170b2bf1717f6c155905625eba84ff5a Reviewed-on: https://chromium-review.googlesource.com/c/1365444 Reviewed-by: Weiyong Yao <braveyao@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#615886} [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/chrome/browser/BUILD.gn [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/chrome/browser/about_flags.cc [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/chrome/browser/flag_descriptions.h [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/content/public/browser/BUILD.gn [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/content/public/browser/desktop_capture.cc [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/content/public/common/BUILD.gn [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/content/public/common/content_features.cc [modify] https://crrev.com/8788015d2b2efa354c641f4e0ed38fba726f3ae7/content/public/common/content_features.h
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cc2518facb66f4d33379561b18fa5dfb0abad12 commit 4cc2518facb66f4d33379561b18fa5dfb0abad12 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Dec 12 21:12:59 2018 Roll src/third_party/webrtc f6b10fbe4ad7..f7f13e0742a9 (12 commits) https://webrtc.googlesource.com/src.git/+log/f6b10fbe4ad7..f7f13e0742a9 git log f6b10fbe4ad7..f7f13e0742a9 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 kron@webrtc.org Add end-to-end test for ColorSpace information 2018-12-12 phensman@webrtc.org Switch to literals in playout delay tests 2018-12-12 kron@webrtc.org Add chroma siting to color space RTP extension 2018-12-12 henrikg@webrtc.org Revert "Reland "Default to dlopening the PipeWire."" 2018-12-12 nisse@webrtc.org Delete VideoCodec::targetBitrate 2018-12-12 mbonadei@webrtc.org Using fully qualified names for using declarations. 2018-12-12 phensman@webrtc.org Reintroduce division by two for audio playout delay 2018-12-12 mbonadei@webrtc.org Stop using 'using namespace'. 2018-12-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7f93585b0f..23962c3887 (615733:615838) 2018-12-12 srte@webrtc.org Signals start rate when registering to TargetTransferRateObserver. 2018-12-12 nisse@webrtc.org Convert NetEq Cng-related test to not use RegisterExternalDecoder 2018-12-12 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire." Created with: gclient setdep -r src/third_party/webrtc@f7f13e0742a9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122,chromium:None,chromium:None,chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf6f6fc19cf09dfc783ca117f3ae0206218f5731 Reviewed-on: https://chromium-review.googlesource.com/c/1374136 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616042} [modify] https://crrev.com/4cc2518facb66f4d33379561b18fa5dfb0abad12/DEPS
,
Dec 13
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/0cc42d47389c039c57e47d7ec0c76b97e2da2b0b commit 0cc42d47389c039c57e47d7ec0c76b97e2da2b0b Author: Tomas Popela <tomas.popela@gmail.com> Date: Thu Dec 13 19:45:59 2018 Reland "Default to dlopening the PipeWire." This is a reland of a099877d8946eb942046ca1295cc142e4fa7ea6f Original change's description: > Reland "Default to dlopening the PipeWire." > > This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 > > Original change's description: > > Default to dlopening the PipeWire. > > > > Reuse the existing infra from Chromium to do that. Additionally the > > target_gen_dir needs to the added to the include directories, otherwise > > the Chromium build will fail as it won't find the generated stubs. Also the > > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > > doesn't work with them correctly. With all these changes in place the PipeWire > > support is enabled when compiling on Linux. > > > > Bug: chromium:682122 > > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > > Cr-Commit-Position: refs/heads/master@{#25720} > > Bug: chromium:682122 > Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 > Reviewed-on: https://webrtc-review.googlesource.com/c/113040 > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25981} Bug: chromium:682122 Change-Id: Ief26c93069f946f981340664a267fcb412229285 Reviewed-on: https://webrtc-review.googlesource.com/c/114163 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26004} [modify] https://crrev.com/0cc42d47389c039c57e47d7ec0c76b97e2da2b0b/BUILD.gn [modify] https://crrev.com/0cc42d47389c039c57e47d7ec0c76b97e2da2b0b/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/0cc42d47389c039c57e47d7ec0c76b97e2da2b0b/modules/desktop_capture/linux/base_capturer_pipewire.cc [add] https://crrev.com/0cc42d47389c039c57e47d7ec0c76b97e2da2b0b/modules/desktop_capture/linux/pipewire.sigs [add] https://crrev.com/0cc42d47389c039c57e47d7ec0c76b97e2da2b0b/modules/desktop_capture/linux/pipewire_stub_header.fragment [modify] https://crrev.com/0cc42d47389c039c57e47d7ec0c76b97e2da2b0b/webrtc.gni
,
Dec 14
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/3073f3d1488cd899e59d60fdaf207e2d6c5c9ea0 commit 3073f3d1488cd899e59d60fdaf207e2d6c5c9ea0 Author: Henrik Grunell <henrikg@webrtc.org> Date: Fri Dec 14 14:23:58 2018 Revert "Reland "Default to dlopening the PipeWire."" This reverts commit 0cc42d47389c039c57e47d7ec0c76b97e2da2b0b. Reason for revert: Sorry, broke WebRTC roll to Chromium again: https://chromium-review.googlesource.com/c/chromium/src/+/1377299. This time the define now set enabled code around the feature flag already landed and there were failures related to that. I suggest to revert that Chromium CL and re-land it after this CL has landed and been rolled into Chromium (if possible to do so). Original change's description: > Reland "Default to dlopening the PipeWire." > > This is a reland of a099877d8946eb942046ca1295cc142e4fa7ea6f > > Original change's description: > > Reland "Default to dlopening the PipeWire." > > > > This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 > > > > Original change's description: > > > Default to dlopening the PipeWire. > > > > > > Reuse the existing infra from Chromium to do that. Additionally the > > > target_gen_dir needs to the added to the include directories, otherwise > > > the Chromium build will fail as it won't find the generated stubs. Also the > > > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > > > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > > > doesn't work with them correctly. With all these changes in place the PipeWire > > > support is enabled when compiling on Linux. > > > > > > Bug: chromium:682122 > > > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > > > Cr-Commit-Position: refs/heads/master@{#25720} > > > > Bug: chromium:682122 > > Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 > > Reviewed-on: https://webrtc-review.googlesource.com/c/113040 > > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25981} > > Bug: chromium:682122 > Change-Id: Ief26c93069f946f981340664a267fcb412229285 > Reviewed-on: https://webrtc-review.googlesource.com/c/114163 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26004} TBR=phoglund@webrtc.org,mbonadei@webrtc.org,oprypin@webrtc.org,braveyao@webrtc.org,braveyao@chromium.org,tomas.popela@gmail.com Change-Id: I9ca52c61210e94182dd6b6a26a136c7f79a2dd0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:682122 Reviewed-on: https://webrtc-review.googlesource.com/c/114427 Reviewed-by: Henrik Grunell <henrikg@webrtc.org> Commit-Queue: Henrik Grunell <henrikg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26014} [modify] https://crrev.com/3073f3d1488cd899e59d60fdaf207e2d6c5c9ea0/BUILD.gn [modify] https://crrev.com/3073f3d1488cd899e59d60fdaf207e2d6c5c9ea0/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/3073f3d1488cd899e59d60fdaf207e2d6c5c9ea0/modules/desktop_capture/linux/base_capturer_pipewire.cc [delete] https://crrev.com/3be607f2bc8d59120e2191dece67089f97618456/modules/desktop_capture/linux/pipewire.sigs [delete] https://crrev.com/3be607f2bc8d59120e2191dece67089f97618456/modules/desktop_capture/linux/pipewire_stub_header.fragment [modify] https://crrev.com/3073f3d1488cd899e59d60fdaf207e2d6c5c9ea0/webrtc.gni
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54a631f03d888aadfd1a5d3af371f4748412a99f commit 54a631f03d888aadfd1a5d3af371f4748412a99f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 20:32:43 2018 Roll src/third_party/webrtc d96b275cd686..24779d82292e (15 commits) https://webrtc.googlesource.com/src.git/+log/d96b275cd686..24779d82292e git log d96b275cd686..24779d82292e --date=short --no-merges --format='%ad %ae %s' 2018-12-14 terelius@webrtc.org Missing packet send time should not cause BWE backoff. 2018-12-14 oprypin@webrtc.org Switch to logdog binary provided by IMPLIED_CIPD_BINARIES 2018-12-14 henrikg@webrtc.org Revert "Reland "Default to dlopening the PipeWire."" 2018-12-14 tikuta@google.com Use output_dir instead of output_name 2018-12-14 kron@webrtc.org Refactor creation of ColorSpace test data 2018-12-14 nisse@webrtc.org Delete log severity LS_SENSITIVE 2018-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55b877610b..6d37479eb8 (615952:616603) 2018-12-14 tikuta@google.com update luci-go client 2018-12-14 steveanton@webrtc.org Use unique_ptr in DataChannel PacketQueue 2018-12-13 steveanton@webrtc.org Remove unused cryptoparams.h header 2018-12-13 zstein@webrtc.org Set LoggedIceCandidatePairEvent.transaction_id to default value if missing. 2018-12-13 benwright@webrtc.org Adding fuzzing configuration files for Rtp Replay Fuzzing. 2018-12-13 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire." 2018-12-13 jeroendb@webrtc.org Adding metrics for hostname candidate use. 2018-12-13 kron@webrtc.org Reorder methods and members of HdrMetadata Created with: gclient setdep -r src/third_party/webrtc@24779d82292e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:755660,chromium:682122,chromium:914264,chromium:None,chromium:894045,chromium:914164,chromium:None,chromium:None,chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5286b9abd8b5c2110cdcc85633079001b3689e71 Reviewed-on: https://chromium-review.googlesource.com/c/1378445 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616810} [modify] https://crrev.com/54a631f03d888aadfd1a5d3af371f4748412a99f/DEPS
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9498866749c4616db35b086c2e69f0dae09ec2ad commit 9498866749c4616db35b086c2e69f0dae09ec2ad Author: Tomáš Popela <tomas.popela@gmail.com> Date: Fri Jan 04 21:49:39 2019 Revert "Add about flag for enabling the PipeWire support in WebRTC" This reverts commit 8788015d2b2efa354c641f4e0ed38fba726f3ae7. Reason for revert: This change is not complete, because it makes some unit tests to fail (this was found during the WebRTC roll). It's safer to revert this and let the WebRTC roll succeed and then fix the unit tests. Original change's description: > Add about flag for enabling the PipeWire support in WebRTC > > Add a new enable-webrtc-pipewire-capturer about flag, that when > enabled, will allow to use the PipeWire media server for providing > the screen content for screen casting when user is running on Wayland > display server on Linux. > > The flag is disabled by default, due to the user experience as it > involves two extra confirmation dialogs outside of Chromium - requested > by Weiyong Yao. It could change the default, once it goes through Chromium > UI review. > > Bug: 682122 > Change-Id: I70c07a4a170b2bf1717f6c155905625eba84ff5a > Reviewed-on: https://chromium-review.googlesource.com/c/1365444 > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > Cr-Commit-Position: refs/heads/master@{#615886} TBR=braveyao@chromium.org,jochen@chromium.org,tomas.popela@gmail.com Bug: 682122 Change-Id: I71376def29423accafe94344c9a385ff4a038df5 Reviewed-on: https://chromium-review.googlesource.com/c/1379756 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#620075} [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/chrome/browser/BUILD.gn [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/chrome/browser/about_flags.cc [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/chrome/browser/flag_descriptions.h [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/content/public/browser/BUILD.gn [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/content/public/browser/desktop_capture.cc [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/content/public/common/BUILD.gn [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/content/public/common/content_features.cc [modify] https://crrev.com/9498866749c4616db35b086c2e69f0dae09ec2ad/content/public/common/content_features.h
,
Jan 8
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/762543fcab2c50c2799cbaee1564c9a9d0621f27 commit 762543fcab2c50c2799cbaee1564c9a9d0621f27 Author: Tomas Popela <tomas.popela@gmail.com> Date: Tue Jan 08 08:09:42 2019 Reland "Default to dlopening the PipeWire." This is a reland of 0cc42d47389c039c57e47d7ec0c76b97e2da2b0b Original change's description: > Reland "Default to dlopening the PipeWire." > > This is a reland of a099877d8946eb942046ca1295cc142e4fa7ea6f > > Original change's description: > > Reland "Default to dlopening the PipeWire." > > > > This is a reland of a13be019017449c57f48203d0fb778f34f7553a7 > > > > Original change's description: > > > Default to dlopening the PipeWire. > > > > > > Reuse the existing infra from Chromium to do that. Additionally the > > > target_gen_dir needs to the added to the include directories, otherwise > > > the Chromium build will fail as it won't find the generated stubs. Also the > > > pw_properties_new() was replaced with pw_properties_new_string() as it doesn't > > > require a variadic parameter because the //tools/generate_stubs/generate_stubs.py > > > doesn't work with them correctly. With all these changes in place the PipeWire > > > support is enabled when compiling on Linux. > > > > > > Bug: chromium:682122 > > > Change-Id: I3bbc5efaecd9a08e20cbcf998b2cb534224eae7d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/111081 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > > > Cr-Commit-Position: refs/heads/master@{#25720} > > > > Bug: chromium:682122 > > Change-Id: I3cca3d4d961dc7a088346c8fd3c970d3dfde3b79 > > Reviewed-on: https://webrtc-review.googlesource.com/c/113040 > > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > > Reviewed-by: Brave Yao <braveyao@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25981} > > Bug: chromium:682122 > Change-Id: Ief26c93069f946f981340664a267fcb412229285 > Reviewed-on: https://webrtc-review.googlesource.com/c/114163 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26004} Bug: chromium:682122 Change-Id: I0a4ea7b39be5970f26df6dbc3e437dd63cdb8708 Reviewed-on: https://webrtc-review.googlesource.com/c/116280 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26154} [modify] https://crrev.com/762543fcab2c50c2799cbaee1564c9a9d0621f27/BUILD.gn [modify] https://crrev.com/762543fcab2c50c2799cbaee1564c9a9d0621f27/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/762543fcab2c50c2799cbaee1564c9a9d0621f27/modules/desktop_capture/linux/base_capturer_pipewire.cc [add] https://crrev.com/762543fcab2c50c2799cbaee1564c9a9d0621f27/modules/desktop_capture/linux/pipewire.sigs [add] https://crrev.com/762543fcab2c50c2799cbaee1564c9a9d0621f27/modules/desktop_capture/linux/pipewire_stub_header.fragment [modify] https://crrev.com/762543fcab2c50c2799cbaee1564c9a9d0621f27/webrtc.gni
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4da5808b74f84d120696dd2f8dae94d86a02d58 commit e4da5808b74f84d120696dd2f8dae94d86a02d58 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Jan 08 12:40:03 2019 Roll src/third_party/webrtc f8a6974e753e..762543fcab2c (1 commits) https://webrtc.googlesource.com/src.git/+log/f8a6974e753e..762543fcab2c git log f8a6974e753e..762543fcab2c --date=short --no-merges --format='%ad %ae %s' 2019-01-08 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire." Created with: gclient setdep -r src/third_party/webrtc@762543fcab2c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I00c6e6f7c6eea43cc3dd9646a0f30c69de3ce507 Reviewed-on: https://chromium-review.googlesource.com/c/1400605 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620694} [modify] https://crrev.com/e4da5808b74f84d120696dd2f8dae94d86a02d58/DEPS
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/253a583b6b687c3484a1568c319f05aaa8274938 commit 253a583b6b687c3484a1568c319f05aaa8274938 Author: Tomas Popela <tomas.popela@gmail.com> Date: Mon Jan 14 17:22:10 2019 Reland "Add about flag for enabling the PipeWire support in WebRTC" This is a reland of 8788015d2b2efa354c641f4e0ed38fba726f3ae7 Unit tests are fixed in the reland. Original change's description: > Add about flag for enabling the PipeWire support in WebRTC > > Add a new enable-webrtc-pipewire-capturer about flag, that when > enabled, will allow to use the PipeWire media server for providing > the screen content for screen casting when user is running on Wayland > display server on Linux. > > The flag is disabled by default, due to the user experience as it > involves two extra confirmation dialogs outside of Chromium - requested > by Weiyong Yao. It could change the default, once it goes through Chromium > UI review. > > Bug: 682122 > Reviewed-on: https://chromium-review.googlesource.com/c/1365444 > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > Cr-Commit-Position: refs/heads/master@{#615886} Bug: 682122 Change-Id: Ie5d0bf4945f621121c14e95a4addad3afac5bec1 Reviewed-on: https://chromium-review.googlesource.com/c/1402441 Reviewed-by: Weiyong Yao <braveyao@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#622491} [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/chrome/browser/BUILD.gn [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/chrome/browser/about_flags.cc [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/chrome/browser/flag-metadata.json [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/chrome/browser/flag_descriptions.h [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/content/public/browser/BUILD.gn [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/content/public/browser/desktop_capture.cc [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/content/public/common/BUILD.gn [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/content/public/common/content_features.cc [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/content/public/common/content_features.h [modify] https://crrev.com/253a583b6b687c3484a1568c319f05aaa8274938/tools/metrics/histograms/enums.xml |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by nyerramilli@chromium.org
, Jan 18 2017