New issue
Advanced search Search tips

Issue 682115 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 530015



Sign in to add a comment

font-display should be exposed on fontface and cssfontfacerule

Project Member Reported by kenjibaheux@chromium.org, Jan 18 2017

Issue description

Spec issue: https://github.com/tabatkins/specs/issues/54

Apparent resolution: "The font-display value should be exposed on fontface and CSSFontFaceRule" (FYI: unicodeRange was also mentioned, same conclusion)
 
CSSOM already exposes fontDisplay property (behind the experimental flag).

We need to add the 'display' property to FontFace.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec812adbe02d56c9efafcaa77c7dfd9121510959

commit ec812adbe02d56c9efafcaa77c7dfd9121510959
Author: ksakamoto <ksakamoto@chromium.org>
Date: Thu Jan 19 03:04:59 2017

CSS font-display: expose display property on FontFace

This adds "display" attribute to FontFace interface that reflects the
font-display value of corresponding @font-face CSS rule. Also, this adds
"display" field to FontFaceDescriptors dictionary, to make it possible
to construct a FontFace with specified font-display value. These
are still protected behind the experimental features flag.

This matches Firefox's experimental implementation.

Spec discussion: https://github.com/tabatkins/specs/issues/54

BUG= 682115 

Review-Url: https://codereview.chromium.org/2640753002
Cr-Commit-Position: refs/heads/master@{#444617}

[modify] https://crrev.com/ec812adbe02d56c9efafcaa77c7dfd9121510959/third_party/WebKit/LayoutTests/fast/css/fontface-properties-expected.txt
[modify] https://crrev.com/ec812adbe02d56c9efafcaa77c7dfd9121510959/third_party/WebKit/LayoutTests/fast/css/fontface-properties.html
[modify] https://crrev.com/ec812adbe02d56c9efafcaa77c7dfd9121510959/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ec812adbe02d56c9efafcaa77c7dfd9121510959/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/ec812adbe02d56c9efafcaa77c7dfd9121510959/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/ec812adbe02d56c9efafcaa77c7dfd9121510959/third_party/WebKit/Source/core/css/FontFace.idl
[modify] https://crrev.com/ec812adbe02d56c9efafcaa77c7dfd9121510959/third_party/WebKit/Source/core/css/FontFaceDescriptors.idl

Status: Fixed (was: Assigned)

Sign in to add a comment